You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 13:44:55 UTC

[GitHub] [beam] damccorm opened a new issue, #19851: Side inputs not working in CombineGlobally

damccorm opened a new issue, #19851:
URL: https://github.com/apache/beam/issues/19851

   Side inputs are not working in CombineGlobally. They do work as expected in CombinePerKey and CombineValues.
   
    
   
   The function argument still has the value of `AsSingleton` rather than being resolved into the real value.
   
    
   
   Here is a [Notebook where you can reproduce the issue](https://colab.research.google.com/drive/149By0ZKJjb_JdDOsFywdT_OLj1hMEPBa).
   
   https://colab.research.google.com/drive/149By0ZKJjb_JdDOsFywdT_OLj1hMEPBa
   
   Imported from Jira [BEAM-8400](https://issues.apache.org/jira/browse/BEAM-8400). Original Jira may contain additional context.
   Reported by: dcavazos.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Side inputs not working in CombineGlobally [beam]

Posted by "hjtran (via GitHub)" <gi...@apache.org>.
hjtran commented on issue #19851:
URL: https://github.com/apache/beam/issues/19851#issuecomment-2019327457

   I haven't put much thought into whether this will work with windowed pcollections. If not, maybe we can just have this implement side inputs for the batch case and error for the streaming case and punt on the streaming case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Side inputs not working in CombineGlobally [beam]

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on issue #19851:
URL: https://github.com/apache/beam/issues/19851#issuecomment-1986517576

   From mailing list thread a while back:
   
   You can work around this by specifying
   without_defaults() on the global combine (as the default is computed
   at pipeline construction time). Note that even in the cases where it
   works, it disables combiner lifting, so side inputs in combiners is
   generally discouraged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org