You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2016/03/16 16:50:21 UTC
Review Request 44913: HIVE-11424
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44913/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-11424
https://issues.apache.org/jira/browse/HIVE-11424
Repository: hive-git
Description
-------
HIVE-11424
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveOrToInClauseRule.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f8860b73aed79786571bc27674e7f861e1217c8b
ql/src/test/queries/clientpositive/filter_in_or_dup.q PRE-CREATION
ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out b7a87fd52858530cc214cf0135755e505e1a8050
ql/src/test/results/clientpositive/annotate_stats_filter.q.out 7e697f1ac8aec489fc4be88cca18360049d2ac6f
ql/src/test/results/clientpositive/annotate_stats_part.q.out 131cf6a67678498faaaadbf6ae26dea1617c09c5
ql/src/test/results/clientpositive/auto_join19.q.out 3f70055d81ef3c3676d498c6c08d4058b85fda09
ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out fa73acf3bfca7b0e96a0a4dfb884b3a91e872a78
ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out e0168b3f953d65ed1368bfa0fc40f9432f503749
ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 738286ebbbada17083dec466bba1ab51fd67ed5b
ql/src/test/results/clientpositive/filter_in_or_dup.q.out PRE-CREATION
ql/src/test/results/clientpositive/flatten_and_or.q.out 1d88fc98ddceb4a9c24ea425e3734a41580fac61
ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 106ad6b836b6c2dbf43e236c488621ef21bae47b
ql/src/test/results/clientpositive/list_bucket_query_multiskew_2.q.out 83576f10d1fb306ebe8d578c999c6cd3855f61d1
ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out 05f05aa9e8a959d207ed7fb1dd1a189e2d82caba
ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out 3f159a38e5aa9b8c53a83da8f535707c39f1c2f1
ql/src/test/results/clientpositive/pcr.q.out 684d4d736d65ef8d61bff41b32f7269b069c0429
ql/src/test/results/clientpositive/perf/query13.q.out cc40e796ba9a0a47c79ff99c69925ead9ae3c045
ql/src/test/results/clientpositive/perf/query34.q.out 6fa6985acd03dd2a84c76ab34dfa10416a05aa76
ql/src/test/results/clientpositive/perf/query71.q.out 504705bef7daa52b46bc628a9cd082c1f19723fa
ql/src/test/results/clientpositive/perf/query73.q.out e367f51a6eaf21835bbad29842d96357ffcdb022
ql/src/test/results/clientpositive/perf/query85.q.out 72ac500adb8e52ed95b15715c7a42f64e5ce568c
ql/src/test/results/clientpositive/perf/query91.q.out 66d8056f6873622e66b5e527cf60fc2539771e29
ql/src/test/results/clientpositive/pointlookup.q.out 460cc748e9560a8319d7bcc100af190db3c7887f
ql/src/test/results/clientpositive/pointlookup2.q.out fb17e720d086196c7fed33d527b5d468826337f9
ql/src/test/results/clientpositive/pointlookup3.q.out d5c41574c415cdb930b0b4df6ce0b89de19c6d9e
ql/src/test/results/clientpositive/pointlookup4.q.out 0a9bd3eea6b40a1ae9a3490e8c8c29a37ed5e020
ql/src/test/results/clientpositive/spark/auto_join19.q.out 88ef3f19818009fc0aa3f2a64dcebdb648aa4130
ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_7.q.out 0b64a8735a6e9a668650db8907abce38c31ab70e
ql/src/test/results/clientpositive/spark/pcr.q.out 6345effb2b0d0668170d7020e4a2029a15d0b78b
ql/src/test/results/clientpositive/spark/vectorized_case.q.out c06ea94e39cd82516290c2bb9985a47006c3d368
ql/src/test/results/clientpositive/tez/bucketpruning1.q.out 5315f2cff7064fc2ef51b6f72e2374d27d666122
ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 159415d0300ae6b3f63900d0ead083746e06f67e
ql/src/test/results/clientpositive/tez/explainuser_1.q.out b501f9745b9e3a60f581a19064ab3284b559c8c3
ql/src/test/results/clientpositive/tez/vectorized_case.q.out 28b7f9be84c10a9f2f55eb2f7d2b827990c1e554
ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out f3e31d4f4009bfec9abe972ee1e9720af59036c2
ql/src/test/results/clientpositive/vectorized_case.q.out 08c1412098f2be4f18c222569261f092ed918ebd
Diff: https://reviews.apache.org/r/44913/diff/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 44913: HIVE-11424
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44913/#review123887
-----------------------------------------------------------
ql/src/test/results/clientpositive/annotate_stats_part.q.out (line 266)
<https://reviews.apache.org/r/44913/#comment186171>
Seems like PCR failed to remove filter on partition columns.
ql/src/test/results/clientpositive/auto_join19.q.out (line 56)
<https://reviews.apache.org/r/44913/#comment186172>
PCR failed to remove filter on partition columns
ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out (line 377)
<https://reviews.apache.org/r/44913/#comment186173>
PCR failed to remove filter on partition columns
ql/src/test/results/clientpositive/pcr.q.out (line 1720)
<https://reviews.apache.org/r/44913/#comment186174>
PCR failed to remove filter on partition columns
ql/src/test/results/clientpositive/pcr.q.out (line 1933)
<https://reviews.apache.org/r/44913/#comment186175>
PCR failed to remove filter on partition columns
ql/src/test/results/clientpositive/pcr.q.out (line 5528)
<https://reviews.apache.org/r/44913/#comment186176>
PCR failed to remove filter on partition columns
ql/src/test/results/clientpositive/pointlookup3.q.out (line 384)
<https://reviews.apache.org/r/44913/#comment186177>
Constant propagation broke.
ql/src/test/results/clientpositive/pointlookup4.q.out (lines 250 - 261)
<https://reviews.apache.org/r/44913/#comment186179>
Partition pruning didnt prune partitions.
ql/src/test/results/clientpositive/spark/auto_join19.q.out (line 59)
<https://reviews.apache.org/r/44913/#comment186180>
PCR failed to remove filter on partition columns
ql/src/test/results/clientpositive/tez/bucketpruning1.q.out (line 1106)
<https://reviews.apache.org/r/44913/#comment186187>
Pretty neat. Bucket pruning kicked in.
- Ashutosh Chauhan
On March 16, 2016, 3:50 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44913/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 3:50 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-11424
> https://issues.apache.org/jira/browse/HIVE-11424
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-11424
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveOrToInClauseRule.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f8860b73aed79786571bc27674e7f861e1217c8b
> ql/src/test/queries/clientpositive/filter_in_or_dup.q PRE-CREATION
> ql/src/test/results/clientpositive/annotate_stats_deep_filters.q.out b7a87fd52858530cc214cf0135755e505e1a8050
> ql/src/test/results/clientpositive/annotate_stats_filter.q.out 7e697f1ac8aec489fc4be88cca18360049d2ac6f
> ql/src/test/results/clientpositive/annotate_stats_part.q.out 131cf6a67678498faaaadbf6ae26dea1617c09c5
> ql/src/test/results/clientpositive/auto_join19.q.out 3f70055d81ef3c3676d498c6c08d4058b85fda09
> ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out fa73acf3bfca7b0e96a0a4dfb884b3a91e872a78
> ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out e0168b3f953d65ed1368bfa0fc40f9432f503749
> ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 738286ebbbada17083dec466bba1ab51fd67ed5b
> ql/src/test/results/clientpositive/filter_in_or_dup.q.out PRE-CREATION
> ql/src/test/results/clientpositive/flatten_and_or.q.out 1d88fc98ddceb4a9c24ea425e3734a41580fac61
> ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out 106ad6b836b6c2dbf43e236c488621ef21bae47b
> ql/src/test/results/clientpositive/list_bucket_query_multiskew_2.q.out 83576f10d1fb306ebe8d578c999c6cd3855f61d1
> ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out 05f05aa9e8a959d207ed7fb1dd1a189e2d82caba
> ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out 3f159a38e5aa9b8c53a83da8f535707c39f1c2f1
> ql/src/test/results/clientpositive/pcr.q.out 684d4d736d65ef8d61bff41b32f7269b069c0429
> ql/src/test/results/clientpositive/perf/query13.q.out cc40e796ba9a0a47c79ff99c69925ead9ae3c045
> ql/src/test/results/clientpositive/perf/query34.q.out 6fa6985acd03dd2a84c76ab34dfa10416a05aa76
> ql/src/test/results/clientpositive/perf/query71.q.out 504705bef7daa52b46bc628a9cd082c1f19723fa
> ql/src/test/results/clientpositive/perf/query73.q.out e367f51a6eaf21835bbad29842d96357ffcdb022
> ql/src/test/results/clientpositive/perf/query85.q.out 72ac500adb8e52ed95b15715c7a42f64e5ce568c
> ql/src/test/results/clientpositive/perf/query91.q.out 66d8056f6873622e66b5e527cf60fc2539771e29
> ql/src/test/results/clientpositive/pointlookup.q.out 460cc748e9560a8319d7bcc100af190db3c7887f
> ql/src/test/results/clientpositive/pointlookup2.q.out fb17e720d086196c7fed33d527b5d468826337f9
> ql/src/test/results/clientpositive/pointlookup3.q.out d5c41574c415cdb930b0b4df6ce0b89de19c6d9e
> ql/src/test/results/clientpositive/pointlookup4.q.out 0a9bd3eea6b40a1ae9a3490e8c8c29a37ed5e020
> ql/src/test/results/clientpositive/spark/auto_join19.q.out 88ef3f19818009fc0aa3f2a64dcebdb648aa4130
> ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_7.q.out 0b64a8735a6e9a668650db8907abce38c31ab70e
> ql/src/test/results/clientpositive/spark/pcr.q.out 6345effb2b0d0668170d7020e4a2029a15d0b78b
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out c06ea94e39cd82516290c2bb9985a47006c3d368
> ql/src/test/results/clientpositive/tez/bucketpruning1.q.out 5315f2cff7064fc2ef51b6f72e2374d27d666122
> ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 159415d0300ae6b3f63900d0ead083746e06f67e
> ql/src/test/results/clientpositive/tez/explainuser_1.q.out b501f9745b9e3a60f581a19064ab3284b559c8c3
> ql/src/test/results/clientpositive/tez/vectorized_case.q.out 28b7f9be84c10a9f2f55eb2f7d2b827990c1e554
> ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out f3e31d4f4009bfec9abe972ee1e9720af59036c2
> ql/src/test/results/clientpositive/vectorized_case.q.out 08c1412098f2be4f18c222569261f092ed918ebd
>
> Diff: https://reviews.apache.org/r/44913/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>