You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Attila Szabo <as...@cloudera.com> on 2016/09/23 13:39:38 UTC
Re: Review Request 50987: SQOOP-2913: Make sqoop fail if user uses
--direct connector for case when --direct connector is not available
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50987/#review150175
-----------------------------------------------------------
Hey Anna,
The final implementation looks great.
I have only one naming convention related request for you:
Could you please give a much more concrete name to your Manager enum? Like SupportedManagers, SuppoertedConnManagers, etc.
Like this it's too abstract and could be confusing.
Thanks,
Maugli
- Attila Szabo
On Aug. 23, 2016, 2:11 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50987/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 2:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2913
> https://issues.apache.org/jira/browse/SQOOP-2913
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-2913: Make sqoop fail if user uses --direct connector for case when --direct connector is not available
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java a5f72f7
> src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 58ff745
> src/java/org/apache/sqoop/manager/Manager.java PRE-CREATION
> src/java/org/apache/sqoop/tool/ExportTool.java 15ecddf
> src/java/org/apache/sqoop/tool/ImportTool.java ff7b822
> src/test/com/cloudera/sqoop/TestDirectImport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/TestDefaultManagerFactory.java PRE-CREATION
> src/test/org/apache/sqoop/tool/TestExportToolValidateOptions.java PRE-CREATION
> src/test/org/apache/sqoop/tool/TestValidateImportOptions.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/50987/diff/
>
>
> Testing
> -------
>
> Added new test cases
>
>
> Thanks,
>
> Anna Szonyi
>
>