You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/11/11 20:38:13 UTC

[GitHub] [helix] xyuanlu opened a new pull request #1902: Split BatchGetInstancesStoppableChecks

xyuanlu opened a new pull request #1902:
URL: https://github.com/apache/helix/pull/1902


   ### Issues
   
   - [X] My PR addresses the following Helix issues and references them in the PR description:
   
   #1896
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   This PR Split function batchGetInstancesStoppableChecks into batchHelixInstanceStoppableCheck and batchCustomInstanceStoppableCheck for future common use. 
   
   ### Tests
   
   - [X] The following tests are written for this issue:
   
   NA
   
   - The following is the result of the "mvn test" command on the appropriate module:
   
   (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
   
   (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] junkaixue commented on a change in pull request #1902: Split BatchGetInstancesStoppableChecks

Posted by GitBox <gi...@apache.org>.
junkaixue commented on a change in pull request #1902:
URL: https://github.com/apache/helix/pull/1902#discussion_r748503217



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -318,6 +330,9 @@ private StoppableCheck performCustomInstanceCheck(String clusterId, String insta
 
   private Map<String, String> getCustomPayLoads(String jsonContent) throws IOException {
     Map<String, String> result = new HashMap<>();
+    if (jsonContent == null) {
+      return result;
+    }

Review comment:
       This is the fix for recent asking, right? I have not tested but I am not sure if we pass empty map in customize check would cause problem?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] xyuanlu commented on a change in pull request #1902: Split BatchGetInstancesStoppableChecks

Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1902:
URL: https://github.com/apache/helix/pull/1902#discussion_r749543588



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -318,6 +330,9 @@ private StoppableCheck performCustomInstanceCheck(String clusterId, String insta
 
   private Map<String, String> getCustomPayLoads(String jsonContent) throws IOException {
     Map<String, String> result = new HashMap<>();
+    if (jsonContent == null) {
+      return result;
+    }

Review comment:
       I created another PR that fixes the input issue for stoppable API that depends on this refactor PR. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] xyuanlu commented on pull request #1902: Split BatchGetInstancesStoppableChecks

Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1902:
URL: https://github.com/apache/helix/pull/1902#issuecomment-974352143


   This PR is ready to be merged. Approved by @junkaixue   #Thanks!!
   
   Commit message:
   Split BatchGetInstancesStoppableChecks into 2 private util functions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] xyuanlu commented on a change in pull request #1902: Split BatchGetInstancesStoppableChecks

Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1902:
URL: https://github.com/apache/helix/pull/1902#discussion_r751777708



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -318,6 +330,9 @@ private StoppableCheck performCustomInstanceCheck(String clusterId, String insta
 
   private Map<String, String> getCustomPayLoads(String jsonContent) throws IOException {
     Map<String, String> result = new HashMap<>();
+    if (jsonContent == null) {
+      return result;
+    }

Review comment:
       rebased and updated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] zhangmeng916 merged pull request #1902: Split BatchGetInstancesStoppableChecks

Posted by GitBox <gi...@apache.org>.
zhangmeng916 merged pull request #1902:
URL: https://github.com/apache/helix/pull/1902


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] junkaixue commented on a change in pull request #1902: Split BatchGetInstancesStoppableChecks

Posted by GitBox <gi...@apache.org>.
junkaixue commented on a change in pull request #1902:
URL: https://github.com/apache/helix/pull/1902#discussion_r750611320



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -318,6 +330,9 @@ private StoppableCheck performCustomInstanceCheck(String clusterId, String insta
 
   private Map<String, String> getCustomPayLoads(String jsonContent) throws IOException {
     Map<String, String> result = new HashMap<>();
+    if (jsonContent == null) {
+      return result;
+    }

Review comment:
       This has been fixed in a different PR. Let's update this PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] xyuanlu commented on a change in pull request #1902: Split BatchGetInstancesStoppableChecks

Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1902:
URL: https://github.com/apache/helix/pull/1902#discussion_r749543588



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -318,6 +330,9 @@ private StoppableCheck performCustomInstanceCheck(String clusterId, String insta
 
   private Map<String, String> getCustomPayLoads(String jsonContent) throws IOException {
     Map<String, String> result = new HashMap<>();
+    if (jsonContent == null) {
+      return result;
+    }

Review comment:
       I created another PR that fixes the input issue for stoppable API that depends on this refactor PR. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] xyuanlu commented on a change in pull request #1902: Split BatchGetInstancesStoppableChecks

Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1902:
URL: https://github.com/apache/helix/pull/1902#discussion_r750621829



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -318,6 +330,9 @@ private StoppableCheck performCustomInstanceCheck(String clusterId, String insta
 
   private Map<String, String> getCustomPayLoads(String jsonContent) throws IOException {
     Map<String, String> result = new HashMap<>();
+    if (jsonContent == null) {
+      return result;
+    }

Review comment:
       TFTR. Test will fail is we do not add this line. Will rebase when #1905 is merged.

##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -318,6 +330,9 @@ private StoppableCheck performCustomInstanceCheck(String clusterId, String insta
 
   private Map<String, String> getCustomPayLoads(String jsonContent) throws IOException {
     Map<String, String> result = new HashMap<>();
+    if (jsonContent == null) {
+      return result;
+    }

Review comment:
       TFTR. Test will fail if we do not add this line. Will rebase when #1905 is merged.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org