You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2020/08/04 16:11:08 UTC

[GitHub] [madlib] khannaekta commented on a change in pull request #508: Various: Do not drop output tables

khannaekta commented on a change in pull request #508:
URL: https://github.com/apache/madlib/pull/508#discussion_r464727148



##########
File path: src/ports/postgres/modules/glm/glm.py_in
##########
@@ -250,7 +250,6 @@ def __glm_compute(schema_madlib, tbl_source, tbl_output, col_dep_var, col_ind_va
 
     plpy.execute(
         """
-        DROP TABLE IF EXISTS {tbl_output};

Review comment:
       We should probably call `output_tbl_valid(tbl_output)`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org