You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/12/23 09:12:24 UTC
[PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
laglangyue opened a new pull request, #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57
This pr includes:
migrate cleanup-dependencies-project to pekko
motivation:
it is a subtask of migrating akka to pekko
test:
test localy，there still some problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#issuecomment-1868265735
> > 1.0.1 of pekko-grpc-sbt-plugin will cause conflict and 1.0.0 is ok
> > ```shell
> > [error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
> > [error]
> > [error] * org.scala-lang.modules:scala-xml_2.12:2.2.0 (early-semver) is selected over 1.1.1
> > [error] +- com.typesafe.play:twirl-api_2.12:1.6.1 (depends on 2.2.0)
> > [error] +- com.typesafe.sbt:sbt-native-packager:1.8.1 (sbtVersion=1.0, scalaVersion=2.12) (depends on 1.1.1)
> > ```
>
> I added [23c29bf](https://github.com/apache/incubator-pekko-platform-guide/commit/23c29bf4c28906ab9811b2eb8aeadc5e430289a7) - we've had to do that in other builds too
should we use this,sbt-native-packager maybe remove to it,but not `com.typesafe.sbt`
addSbtPlugin("com.github.sbt" % "sbt-native-packager" % "1.9.16")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#discussion_r1435542185
##########
docs-source/docs/modules/how-to/examples/cleanup-dependencies-project/build.sbt:
##########
@@ -50,51 +50,51 @@ dockerRepository := sys.props.get("docker.registry")
ThisBuild / dynverSeparator := "-"
libraryDependencies ++= Seq(
- "com.typesafe.akka" %% "akka-cluster-sharding-typed" % AkkaVersion,
- "com.typesafe.akka" %% "akka-stream" % AkkaVersion,
- // tag::remove-akka-persistence-cassandra[]
- "com.typesafe.akka" %% "akka-persistence-cassandra" % AkkaPersistenceCassandraVersion,
- // end::remove-akka-persistence-cassandra[]
+ "org.apache.pekko" %% "pekko-cluster-sharding-typed" % PekkoVersion,
+ "org.apache.pekko" %% "pekko-stream" % PekkoVersion,
+ // tag::remove-pekko-persistence-cassandra[]
+ "org.apache.pekko" %% "pekko-persistence-cassandra" % PekkoPersistenceCassandraVersion,
+ // end::remove-pekko-persistence-cassandra[]
- // tag::add-akka-persistence-jdbc[]
- "com.lightbend.akka" %% "akka-persistence-jdbc" % AkkaPersistenceJdbcVersion,
- // end::add-akka-persistence-jdbc[]
+ // tag::add-pekko-persistence-jdbc[]
+ "org.apache.pekko" %% "pekko-persistence-jdbc" % PekkoPersistenceJdbcVersion,
+ // end::add-pekko-persistence-jdbc[]
- // tag::remove-akka-projection[]
- "com.lightbend.akka" %% "akka-projection-eventsourced" % AkkaProjectionVersion,
- "com.lightbend.akka" %% "akka-projection-cassandra" % AkkaProjectionVersion,
- "com.lightbend.akka" %% "akka-projection-jdbc" % AkkaProjectionVersion,
- "com.typesafe.akka" %% "akka-persistence-query" % AkkaVersion,
- "com.lightbend.akka" %% "akka-projection-testkit" % AkkaProjectionVersion % Test,
- // end::remove-akka-projection[]
+ // tag::remove-pekko-projection[]
+ "org.apache.pekko" %% "pekko-projection-eventsourced" % PekkoProjectionVersion,
+ "org.apache.pekko" %% "pekko-projection-cassandra" % PekkoProjectionVersion,
+ "org.apache.pekko" %% "pekko-projection-jdbc" % PekkoProjectionVersion,
+ "org.apache.pekko" %% "pekko-persistence-query" % PekkoVersion,
+ "org.apache.pekko" %% "pekko-projection-testkit" % PekkoProjectionVersion % Test,
+ // end::remove-pekko-projection[]
/*
// tag::replace-offset-store-for-projections-jdbc[]
- - "com.lightbend.akka" %% "akka-projection-cassandra" % AkkaProjectionVersion,
- + "com.lightbend.akka" %% "akka-projection-jdbc" % AkkaProjectionVersion,
+ - "org.apache.pekko" %% "pekko-projection-cassandra" % PekkoProjectionVersion,
+ + "org.apache.pekko" %% "pekko-projection-jdbc" % PekkoProjectionVersion,
// end::replace-offset-store-for-projections-jdbc[]
*/
- "com.typesafe.akka" %% "akka-http" % AkkaHttpVersion,
+ "org.apache.pekko" %% "pekko-http" % PekkoHttpVersion,
// tag::remove-grpc-optional[]
- "com.typesafe.akka" %% "akka-http2-support" % AkkaHttpVersion,
+ // "org.apache.pekko" %% "pekko-http2-support" % PekkoHttpVersion,
Review Comment:
well I didn't find pekko-http2-support，Is this included in pekko http or not published ?
@pjfanning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#issuecomment-1868249975
I didn;t find a `sbt-pekko-grpc`
```
// tag::remove-grpc-plugin[]
addSbtPlugin("com.lightbend.akka.grpc" % "sbt-akka-grpc" % "2.1.5")
// end::remove-grpc-plugin[]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#discussion_r1435547861
##########
docs-source/docs/modules/how-to/examples/cleanup-dependencies-project/project/plugins.sbt:
##########
@@ -1,5 +1,5 @@
// tag::remove-grpc-plugin[]
-addSbtPlugin("com.lightbend.akka.grpc" % "sbt-akka-grpc" % "2.1.5")
+addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.0")
Review Comment:
I changed this myself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#issuecomment-1868266440
yeah, sbt-native-packager was migrated to
// https://mvnrepository.com/artifact/com.github.sbt/sbt-native-packager_2.12_1.0
libraryDependencies += "com.github.sbt" % "sbt-native-packager_2.12_1.0" % "1.9.16"
this is rep
https://github.com/sbt/sbt-native-packager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#issuecomment-1868251226
> I didn't find a `sbt-pekko-grpc`
>
> ```
> // tag::remove-grpc-plugin[]
> addSbtPlugin("com.lightbend.akka.grpc" % "sbt-akka-grpc" % "2.1.5")
> // end::remove-grpc-plugin[]
> ```
Use
```
addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.2")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#discussion_r1435547396
##########
docs-source/docs/modules/how-to/examples/cleanup-dependencies-project/project/plugins.sbt:
##########
@@ -1,5 +1,5 @@
// tag::remove-grpc-plugin[]
-addSbtPlugin("com.lightbend.akka.grpc" % "sbt-akka-grpc" % "2.1.5")
+addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.0")
Review Comment:
1.0.1 please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#issuecomment-1868266876
Please trigger the workflow
@pjfanning
PTAL, waitting for CI.
I would away from my compute and go home.If there are still any problems, I will handle them tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#discussion_r1435544569
##########
docs-source/docs/modules/how-to/examples/cleanup-dependencies-project/build.sbt:
##########
@@ -50,51 +50,51 @@ dockerRepository := sys.props.get("docker.registry")
ThisBuild / dynverSeparator := "-"
libraryDependencies ++= Seq(
- "com.typesafe.akka" %% "akka-cluster-sharding-typed" % AkkaVersion,
- "com.typesafe.akka" %% "akka-stream" % AkkaVersion,
- // tag::remove-akka-persistence-cassandra[]
- "com.typesafe.akka" %% "akka-persistence-cassandra" % AkkaPersistenceCassandraVersion,
- // end::remove-akka-persistence-cassandra[]
+ "org.apache.pekko" %% "pekko-cluster-sharding-typed" % PekkoVersion,
+ "org.apache.pekko" %% "pekko-stream" % PekkoVersion,
+ // tag::remove-pekko-persistence-cassandra[]
+ "org.apache.pekko" %% "pekko-persistence-cassandra" % PekkoPersistenceCassandraVersion,
+ // end::remove-pekko-persistence-cassandra[]
- // tag::add-akka-persistence-jdbc[]
- "com.lightbend.akka" %% "akka-persistence-jdbc" % AkkaPersistenceJdbcVersion,
- // end::add-akka-persistence-jdbc[]
+ // tag::add-pekko-persistence-jdbc[]
+ "org.apache.pekko" %% "pekko-persistence-jdbc" % PekkoPersistenceJdbcVersion,
+ // end::add-pekko-persistence-jdbc[]
- // tag::remove-akka-projection[]
- "com.lightbend.akka" %% "akka-projection-eventsourced" % AkkaProjectionVersion,
- "com.lightbend.akka" %% "akka-projection-cassandra" % AkkaProjectionVersion,
- "com.lightbend.akka" %% "akka-projection-jdbc" % AkkaProjectionVersion,
- "com.typesafe.akka" %% "akka-persistence-query" % AkkaVersion,
- "com.lightbend.akka" %% "akka-projection-testkit" % AkkaProjectionVersion % Test,
- // end::remove-akka-projection[]
+ // tag::remove-pekko-projection[]
+ "org.apache.pekko" %% "pekko-projection-eventsourced" % PekkoProjectionVersion,
+ "org.apache.pekko" %% "pekko-projection-cassandra" % PekkoProjectionVersion,
+ "org.apache.pekko" %% "pekko-projection-jdbc" % PekkoProjectionVersion,
+ "org.apache.pekko" %% "pekko-persistence-query" % PekkoVersion,
+ "org.apache.pekko" %% "pekko-projection-testkit" % PekkoProjectionVersion % Test,
+ // end::remove-pekko-projection[]
/*
// tag::replace-offset-store-for-projections-jdbc[]
- - "com.lightbend.akka" %% "akka-projection-cassandra" % AkkaProjectionVersion,
- + "com.lightbend.akka" %% "akka-projection-jdbc" % AkkaProjectionVersion,
+ - "org.apache.pekko" %% "pekko-projection-cassandra" % PekkoProjectionVersion,
+ + "org.apache.pekko" %% "pekko-projection-jdbc" % PekkoProjectionVersion,
// end::replace-offset-store-for-projections-jdbc[]
*/
- "com.typesafe.akka" %% "akka-http" % AkkaHttpVersion,
+ "org.apache.pekko" %% "pekko-http" % PekkoHttpVersion,
// tag::remove-grpc-optional[]
- "com.typesafe.akka" %% "akka-http2-support" % AkkaHttpVersion,
+ // "org.apache.pekko" %% "pekko-http2-support" % PekkoHttpVersion,
Review Comment:
not published - not needed for pekko (code was moved to pekko-http-core)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#issuecomment-1868264081
> 1.0.1 of pekko-grpc-sbt-plugin will cause conflict and 1.0.0 is ok
>
> ```shell
> [error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
> [error]
> [error] * org.scala-lang.modules:scala-xml_2.12:2.2.0 (early-semver) is selected over 1.1.1
> [error] +- com.typesafe.play:twirl-api_2.12:1.6.1 (depends on 2.2.0)
> [error] +- com.typesafe.sbt:sbt-native-packager:1.8.1 (sbtVersion=1.0, scalaVersion=2.12) (depends on 1.1.1)
> ```
I added https://github.com/apache/incubator-pekko-platform-guide/pull/57/commits/23c29bf4c28906ab9811b2eb8aeadc5e430289a7 - we've had to do that in other builds too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] migrate cleanup-dependencies-project to pekko [incubator-pekko-platform-guide]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #57:
URL: https://github.com/apache/incubator-pekko-platform-guide/pull/57#issuecomment-1868260592
1.0.1 of pekko-grpc-sbt-plugin will cause conflict
and 1.0.0 is ok
```shell
[error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error]
[error] * org.scala-lang.modules:scala-xml_2.12:2.2.0 (early-semver) is selected over 1.1.1
[error] +- com.typesafe.play:twirl-api_2.12:1.6.1 (depends on 2.2.0)
[error] +- com.typesafe.sbt:sbt-native-packager:1.8.1 (sbtVersion=1.0, scalaVersion=2.12) (depends on 1.1.1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org