You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "GoyalRocks007 (via GitHub)" <gi...@apache.org> on 2024/01/24 16:54:29 UTC
[PR] FINERACT-1477: Change the logging level for InsufficientAccountBalanceException in batch job [fineract]
GoyalRocks007 opened a new pull request, #3708:
URL: https://github.com/apache/fineract/pull/3708
Changed the logging level for InsufficientAccountBalanceException in batch job from error to warn.
Removed errors.add(e) to avoid abrupt stopping of batch job due to this exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1477: Change the logging level for InsufficientAccountBalanceException in batch job [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #3708:
URL: https://github.com/apache/fineract/pull/3708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1477: Change the logging level for InsufficientAccountBalanceException in batch job [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3708:
URL: https://github.com/apache/fineract/pull/3708#issuecomment-1948034086
@GoyalRocks007 Please squash your commits!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1477: Change the logging level for InsufficientAccountBalanceException in batch job [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3708:
URL: https://github.com/apache/fineract/pull/3708#issuecomment-1912081083
@bharathc27 When the `Transfer Interest To Savings` job running and one of the savings account throw `InsufficientAccountBalanceException`, should the whole job stop and marked as FAILED?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1477: Change the logging level for InsufficientAccountBalanceException in batch job [fineract]
Posted by "GoyalRocks007 (via GitHub)" <gi...@apache.org>.
GoyalRocks007 commented on PR #3708:
URL: https://github.com/apache/fineract/pull/3708#issuecomment-1948659575
Hello @adamsaghy, done as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1477: Change the logging level for InsufficientAccountBalanceException in batch job [fineract]
Posted by "bharathcgowda (via GitHub)" <gi...@apache.org>.
bharathcgowda commented on PR #3708:
URL: https://github.com/apache/fineract/pull/3708#issuecomment-1943730238
@adamsaghy in that scenario the job should continue for the remaining loans and at the end should throw an error message only for the savings account that had the insufficient balance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1477: Change the logging level for InsufficientAccountBalanceException in batch job [fineract]
Posted by "GoyalRocks007 (via GitHub)" <gi...@apache.org>.
GoyalRocks007 commented on PR #3708:
URL: https://github.com/apache/fineract/pull/3708#issuecomment-1947672075
Hello @adamsaghy @bharathcgowda, I have made the required changes. Please check and let me know.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org