You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/07 12:20:12 UTC
[GitHub] [airflow] Nishant-Mishra opened a new pull request #14121: Correction in 'Relationship Builders' section
Nishant-Mishra opened a new pull request #14121:
URL: https://github.com/apache/airflow/pull/14121
The documentation paragraphs were not in correct order.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14121: Correction in 'Relationship Builders' section
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14121:
URL: https://github.com/apache/airflow/pull/14121#issuecomment-808986720
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14121: Correction in 'Relationship Builders' section
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14121:
URL: https://github.com/apache/airflow/pull/14121#issuecomment-774665431
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a change in pull request #14121: Correction in 'Relationship Builders' section
Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #14121:
URL: https://github.com/apache/airflow/pull/14121#discussion_r574225180
##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -655,11 +655,12 @@ Relationship Builders
*Moved in Airflow 2.0*
-In Airflow 2.0 those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
-
-``chain`` and ``cross_downstream`` function provide easier ways to set relationships
+:func:`airflow.models.baseoperator.chain` and :func:`airflow.models.baseoperator..cross_downstream` function provide easier ways to set relationships
between operators in specific situation.
+.. versionchanged:: 2.0.0
+ Those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
Review comment:
```suggestion
They have been moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
```
##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -655,11 +655,12 @@ Relationship Builders
*Moved in Airflow 2.0*
-In Airflow 2.0 those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
-
-``chain`` and ``cross_downstream`` function provide easier ways to set relationships
+:func:`airflow.models.baseoperator.chain` and :func:`airflow.models.baseoperator..cross_downstream` function provide easier ways to set relationships
between operators in specific situation.
Review comment:
```suggestion
between tasks.
```
"in specific situation" doesn't really say anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14121: Correction in 'Relationship Builders' section
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14121:
URL: https://github.com/apache/airflow/pull/14121#discussion_r573463758
##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -655,11 +655,11 @@ Relationship Builders
*Moved in Airflow 2.0*
-In Airflow 2.0 those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
-
``chain`` and ``cross_downstream`` function provide easier ways to set relationships
between operators in specific situation.
+In Airflow 2.0 those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
Review comment:
```suggestion
.. versionchanged:: 2.0.0
Those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
```
See: https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-versionadded
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14121: Correction in 'Relationship Builders' section
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14121:
URL: https://github.com/apache/airflow/pull/14121#discussion_r573463286
##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -655,11 +655,11 @@ Relationship Builders
*Moved in Airflow 2.0*
-In Airflow 2.0 those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
-
``chain`` and ``cross_downstream`` function provide easier ways to set relationships
Review comment:
```suggestion
:func:`airflow.models.baseoperator.chain` and :func:`airflow.models.baseoperator..cross_downstream` function provide easier ways to set relationships
```
This will ensure easy access to the reference documentation. See: https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#python-roles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #14121: Correction in 'Relationship Builders' section
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #14121:
URL: https://github.com/apache/airflow/pull/14121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org