You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/21 12:27:04 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

tillrohrmann opened a new pull request #13726:
URL: https://github.com/apache/flink/pull/13726


   Backport of #13725 to `release-1.11`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13726:
URL: https://github.com/apache/flink/pull/13726#issuecomment-713567666


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8020",
       "triggerID" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f0ac074feed577550c7026b190db031561a25f77",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8087",
       "triggerID" : "f0ac074feed577550c7026b190db031561a25f77",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c673d6c2530a3484e2a315301d0eee7154a3a5d9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8020) 
   * f0ac074feed577550c7026b190db031561a25f77 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8087) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13726:
URL: https://github.com/apache/flink/pull/13726#issuecomment-713533892


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c673d6c2530a3484e2a315301d0eee7154a3a5d9 (Wed Oct 21 12:29:34 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #13726:
URL: https://github.com/apache/flink/pull/13726#issuecomment-715321162


   Merged manually via 751d42ca4a9642f53cb68f4b315b1a2cd000a42f


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13726:
URL: https://github.com/apache/flink/pull/13726#issuecomment-713567666


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8020",
       "triggerID" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c673d6c2530a3484e2a315301d0eee7154a3a5d9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8020) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13726:
URL: https://github.com/apache/flink/pull/13726#issuecomment-713567666


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8020",
       "triggerID" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f0ac074feed577550c7026b190db031561a25f77",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8087",
       "triggerID" : "f0ac074feed577550c7026b190db031561a25f77",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f0ac074feed577550c7026b190db031561a25f77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8087) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13726:
URL: https://github.com/apache/flink/pull/13726#issuecomment-713567666


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c673d6c2530a3484e2a315301d0eee7154a3a5d9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13726:
URL: https://github.com/apache/flink/pull/13726#issuecomment-713567666


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8020",
       "triggerID" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c673d6c2530a3484e2a315301d0eee7154a3a5d9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8020) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #13726:
URL: https://github.com/apache/flink/pull/13726#issuecomment-715320666


   Thanks for the review @rmetzger. Merging this PR now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13726:
URL: https://github.com/apache/flink/pull/13726#issuecomment-713567666


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8020",
       "triggerID" : "c673d6c2530a3484e2a315301d0eee7154a3a5d9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f0ac074feed577550c7026b190db031561a25f77",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f0ac074feed577550c7026b190db031561a25f77",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c673d6c2530a3484e2a315301d0eee7154a3a5d9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8020) 
   * f0ac074feed577550c7026b190db031561a25f77 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #13726: [BP-1.11][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #13726:
URL: https://github.com/apache/flink/pull/13726


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org