You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2021/02/25 00:56:55 UTC

[GitHub] [madlib] kaknikhil commented on a change in pull request #553: DL: Remove AOcontrol from model selection functions

kaknikhil commented on a change in pull request #553:
URL: https://github.com/apache/madlib/pull/553#discussion_r582413471



##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_model_selection.sql_in
##########
@@ -873,9 +872,9 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.generate_model_configs(
     object_table            VARCHAR DEFAULT NULL
 ) RETURNS VOID AS $$
     PythonFunctionBodyOnly(`deep_learning', `madlib_keras_model_selection')
-    with AOControl(False):

Review comment:
       If the user has appendonly set to true, then our code will fail if we don't have the `with aocontrol(False)` code. 
   You can reproduce this by setting `set gp_default_storage_options='appendonly=true';` and then running load_model_selection_table/generate_model_configs will error out with
   ```
   ERROR:  spiexceptions.FeatureNotSupported: append-only tables do not support unique indexes
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org