You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by je...@apache.org on 2005/06/09 10:49:27 UTC
cvs commit: xml-fop/src/java/org/apache/fop/render RendererFactory.java
jeremias 2005/06/09 01:49:27
Modified: src/java/org/apache/fop/render/awt AWTRenderer.java
src/java/org/apache/fop/render/awt/viewer PreviewDialog.java
PreviewDialogAboutBox.java
src/java/org/apache/fop/area PageViewport.java
src/java/org/apache/fop/tools/anttasks Fop.java
src/java/org/apache/fop/apps FOUserAgent.java Fop.java
CommandLineOptions.java
src/java/org/apache/fop/fo Constants.java
src/java/org/apache/fop/render/svg SVGRenderer.java
src/java/org/apache/fop/render RendererFactory.java
Added: src/java/org/apache/fop/render/java2d FontMetricsMapper.java
Java2DFontMetrics.java Java2DRenderer.java
FontSetup.java Java2DGraphicsState.java
RendererState.java
src/java/org/apache/fop/render/awt/viewer/images fopLogo.gif
logo_big.jpg
src/java/org/apache/fop/render/bitmap TIFFRenderer.java
PNGRenderer.java PNGRenderer_onthefly.java
src/java/org/apache/fop/render/print PrintRenderer.java
Removed: src/java/org/apache/fop/render/awt AWTGraphicsState.java
FontSetup.java AWTFontMetrics.java
AWTPrintRenderer.java RendererState.java
FontMetricsMapper.java
Log:
Bugzilla: #33760
Resurrected Java2D/AWT Renderer (including bitmap output to PNG and TIFF using the Batik codecs and print capability).
Submitted by: Renaud Richardet <renaud.richardet.at.gmail.com>
Changes on the original patch:
- PageViewport: isResolved() caused a NPE which I fixed.
Revision Changes Path
1.1 xml-fop/src/java/org/apache/fop/render/java2d/FontMetricsMapper.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/FontMetricsMapper.java?rev=1.1
1.1 xml-fop/src/java/org/apache/fop/render/java2d/Java2DFontMetrics.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/Java2DFontMetrics.java?rev=1.1
1.1 xml-fop/src/java/org/apache/fop/render/java2d/Java2DRenderer.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/Java2DRenderer.java?rev=1.1
1.1 xml-fop/src/java/org/apache/fop/render/java2d/FontSetup.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/FontSetup.java?rev=1.1
1.1 xml-fop/src/java/org/apache/fop/render/java2d/Java2DGraphicsState.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/Java2DGraphicsState.java?rev=1.1
1.1 xml-fop/src/java/org/apache/fop/render/java2d/RendererState.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/RendererState.java?rev=1.1
1.1 xml-fop/src/java/org/apache/fop/render/awt/viewer/images/fopLogo.gif
<<Binary file>>
1.1 xml-fop/src/java/org/apache/fop/render/awt/viewer/images/logo_big.jpg
<<Binary file>>
1.35 +82 -1037 xml-fop/src/java/org/apache/fop/render/awt/AWTRenderer.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/awt/AWTRenderer.java.diff?r1=1.34&r2=1.35
1.9 +121 -90 xml-fop/src/java/org/apache/fop/render/awt/viewer/PreviewDialog.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/awt/viewer/PreviewDialog.java.diff?r1=1.8&r2=1.9
1.4 +7 -7 xml-fop/src/java/org/apache/fop/render/awt/viewer/PreviewDialogAboutBox.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/awt/viewer/PreviewDialogAboutBox.java.diff?r1=1.3&r2=1.4
1.18 +3 -1 xml-fop/src/java/org/apache/fop/area/PageViewport.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/area/PageViewport.java.diff?r1=1.17&r2=1.18
1.1 xml-fop/src/java/org/apache/fop/render/bitmap/TIFFRenderer.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/bitmap/TIFFRenderer.java?rev=1.1
1.1 xml-fop/src/java/org/apache/fop/render/bitmap/PNGRenderer.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/bitmap/PNGRenderer.java?rev=1.1
1.1 xml-fop/src/java/org/apache/fop/render/bitmap/PNGRenderer_onthefly.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/bitmap/PNGRenderer_onthefly.java?rev=1.1
1.20 +11 -0 xml-fop/src/java/org/apache/fop/tools/anttasks/Fop.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/tools/anttasks/Fop.java.diff?r1=1.19&r2=1.20
1.24 +21 -3 xml-fop/src/java/org/apache/fop/apps/FOUserAgent.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/apps/FOUserAgent.java.diff?r1=1.23&r2=1.24
1.22 +6 -3 xml-fop/src/java/org/apache/fop/apps/Fop.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/apps/Fop.java.diff?r1=1.21&r2=1.22
1.34 +39 -1 xml-fop/src/java/org/apache/fop/apps/CommandLineOptions.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/apps/CommandLineOptions.java.diff?r1=1.33&r2=1.34
1.27 +7 -3 xml-fop/src/java/org/apache/fop/fo/Constants.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/fo/Constants.java.diff?r1=1.26&r2=1.27
1.1 xml-fop/src/java/org/apache/fop/render/print/PrintRenderer.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/print/PrintRenderer.java?rev=1.1
1.22 +1 -1 xml-fop/src/java/org/apache/fop/render/svg/SVGRenderer.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/svg/SVGRenderer.java.diff?r1=1.21&r2=1.22
1.3 +6 -2 xml-fop/src/java/org/apache/fop/render/RendererFactory.java
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/RendererFactory.java.diff?r1=1.2&r2=1.3
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
Re: cvs commit: xml-fop/src/java/org/apache/fop/render RendererFactory.java
Posted by Jeremias Maerki <de...@greenmail.ch>.
No problem. I've fixed it.
On 10.06.2005 15:57:16 Renaud Richardet wrote:
> Bonjour
>
> Jeremias Maerki wrote:
>
> >You're right. I didn't check them when reviewing the patch. I tried
> >again but I don't get valid images.
> >
> >Renaud, would you please post the two images separately? Thank you.
> >
> >
> <Humhum/>
>
> 1) I can't find the pictures anymore (changed computer, and failed to
> copy those ressources :( ).
> 2) fopLogo.gif was a logo that appeared on the viewer itself [1] and
> logo_big.jpg was for the menu help>about [2].
> 3) Anyway, those pictures were a quick fix for me (low quality), just to
> make the viewer more attractive.
>
> Sorry,
> Renaud
>
>
> [1] PreviewDialog.java line 141
> [2] PreviewDialogAboutBox.java line 68
>
> >On 09.06.2005 16:33:59 richardw wrote:
> >
> >
> >>jeremias@apache.org writes:
> >> > jeremias 2005/06/09 01:49:27
> >> >
> >> > Modified:
> >> > src/java/org/apache/fop/render/awt/viewer/images fopLogo.gif
> >> > logo_big.jpg
> >>
> >> > Submitted by: Renaud Richardet <renaud.richardet.at.gmail.com>
> >>
> >>Both of these files appear to be corrupt. Can you please confirm this and
> >>either upload the correct versions or point me to them,
> >>
> >>Richard
> >>
> >>
> >
> >
> >
> >Jeremias Maerki
> >
> >
> >
> >
Jeremias Maerki
Re: cvs commit: xml-fop/src/java/org/apache/fop/render RendererFactory.java
Posted by Renaud Richardet <re...@gmail.com>.
Bonjour
Jeremias Maerki wrote:
>You're right. I didn't check them when reviewing the patch. I tried
>again but I don't get valid images.
>
>Renaud, would you please post the two images separately? Thank you.
>
>
<Humhum/>
1) I can't find the pictures anymore (changed computer, and failed to
copy those ressources :( ).
2) fopLogo.gif was a logo that appeared on the viewer itself [1] and
logo_big.jpg was for the menu help>about [2].
3) Anyway, those pictures were a quick fix for me (low quality), just to
make the viewer more attractive.
Sorry,
Renaud
[1] PreviewDialog.java line 141
[2] PreviewDialogAboutBox.java line 68
>On 09.06.2005 16:33:59 richardw wrote:
>
>
>>jeremias@apache.org writes:
>> > jeremias 2005/06/09 01:49:27
>> >
>> > Modified:
>> > src/java/org/apache/fop/render/awt/viewer/images fopLogo.gif
>> > logo_big.jpg
>>
>> > Submitted by: Renaud Richardet <renaud.richardet.at.gmail.com>
>>
>>Both of these files appear to be corrupt. Can you please confirm this and
>>either upload the correct versions or point me to them,
>>
>>Richard
>>
>>
>
>
>
>Jeremias Maerki
>
>
>
>
Re: cvs commit: xml-fop/src/java/org/apache/fop/render RendererFactory.java
Posted by Jeremias Maerki <de...@greenmail.ch>.
You're right. I didn't check them when reviewing the patch. I tried
again but I don't get valid images.
Renaud, would you please post the two images separately? Thank you.
On 09.06.2005 16:33:59 richardw wrote:
> jeremias@apache.org writes:
> > jeremias 2005/06/09 01:49:27
> >
> > Modified:
> > src/java/org/apache/fop/render/awt/viewer/images fopLogo.gif
> > logo_big.jpg
>
> > Submitted by: Renaud Richardet <renaud.richardet.at.gmail.com>
>
> Both of these files appear to be corrupt. Can you please confirm this and
> either upload the correct versions or point me to them,
>
> Richard
Jeremias Maerki
The need for a Contributor License Agreement (was: cvs commit: xml-fop/src/java/org/apache/fop/render RendererFactory.java)
Posted by Jeremias Maerki <de...@greenmail.ch>.
Richard, to put what Glen wrote a little more politely: The Apache
Software Foundation established a policy after which every contributor
who submits more than just a little bugfix or patch (i.e. who is
contributing substantially), should send a signed Contributor License
Agreement to the Foundation. Small contributions such as bugfixes are
covered by the Apache license v2.0 (section 5). Since your work will
likely not fit the latter category, we'd be grateful if you would send
in a signed CLA in due time. You can find it here:
http://www.apache.org/licenses/icla.pdf
You can find more info on the following page (scroll to bottom):
http://www.apache.org/licenses/
Thank you.
Glen, couldn't you just have asked Richard politely to state his full name
and to send in a CLA? I don't think we can afford to scare potential
contributors away by writing messages like yours.
On 09.06.2005 19:19:05 Glen Mazza wrote:
> I think we're going to need to know Richard's last name, as well as have a
> CLA from him, before we can accept work from him. I don't know the
> situation, but if he would rather stay anonymous because he can't donate
> work to Apache, it would appear then he can't donate work to Apache.
Jeremias Maerki
Re: cvs commit: xml-fop/src/java/org/apache/fop/render
RendererFactory.java
Posted by ri...@geoquip-rnd.demon.co.uk.
Glen Mazza writes:
> I think we're going to need to know Richard's last name
Wheeldon. Slightly more details are on my website: www.rswheeldon.com
> as well as have a CLA from him
I'll fax an ICLA to Apache later today.
Richard
Re: cvs commit: xml-fop/src/java/org/apache/fop/render
RendererFactory.java
Posted by Glen Mazza <gr...@verizon.net>.
I think we're going to need to know Richard's last name, as well as have a
CLA from him, before we can accept work from him. I don't know the
situation, but if he would rather stay anonymous because he can't donate
work to Apache, it would appear then he can't donate work to Apache.
Glen
----- Original Message -----
From: <ri...@geoquip-rnd.demon.co.uk>
To: <fo...@xmlgraphics.apache.org>
Sent: Thursday, June 09, 2005 10:33 AM
Subject: Re: cvs commit: xml-fop/src/java/org/apache/fop/render
RendererFactory.java
> jeremias@apache.org writes:
> > jeremias 2005/06/09 01:49:27
> >
> > Modified:
> > src/java/org/apache/fop/render/awt/viewer/images
fopLogo.gif
> > logo_big.jpg
>
> > Submitted by: Renaud Richardet <renaud.richardet.at.gmail.com>
>
> Both of these files appear to be corrupt. Can you please confirm this and
> either upload the correct versions or point me to them,
>
> Richard
>
Re: cvs commit: xml-fop/src/java/org/apache/fop/render RendererFactory.java
Posted by ri...@geoquip-rnd.demon.co.uk.
jeremias@apache.org writes:
> jeremias 2005/06/09 01:49:27
>
> Modified:
> src/java/org/apache/fop/render/awt/viewer/images fopLogo.gif
> logo_big.jpg
> Submitted by: Renaud Richardet <renaud.richardet.at.gmail.com>
Both of these files appear to be corrupt. Can you please confirm this and
either upload the correct versions or point me to them,
Richard
Re: cvs commit: xml-fop/src/java/org/apache/fop/render
RendererFactory.java
Posted by Glen Mazza <gr...@verizon.net>.
No big deal for me, but offhand it would appear clearer to have all the
Java2DRenderer-based subrenderers under /render/java2d (or
whatever)/xxxxRenderer subdirectories.
Glen
----- Original Message -----
From: <je...@apache.org>
To: <xm...@apache.org>
Sent: Thursday, June 09, 2005 4:49 AM
Subject: cvs commit: xml-fop/src/java/org/apache/fop/render
RendererFactory.java
> jeremias 2005/06/09 01:49:27
>
> Modified: src/java/org/apache/fop/render/awt AWTRenderer.java
> src/java/org/apache/fop/render/awt/viewer
PreviewDialog.java
> PreviewDialogAboutBox.java
> src/java/org/apache/fop/area PageViewport.java
> src/java/org/apache/fop/tools/anttasks Fop.java
> src/java/org/apache/fop/apps FOUserAgent.java Fop.java
> CommandLineOptions.java
> src/java/org/apache/fop/fo Constants.java
> src/java/org/apache/fop/render/svg SVGRenderer.java
> src/java/org/apache/fop/render RendererFactory.java
> Added: src/java/org/apache/fop/render/java2d
FontMetricsMapper.java
> Java2DFontMetrics.java Java2DRenderer.java
> FontSetup.java Java2DGraphicsState.java
> RendererState.java
> src/java/org/apache/fop/render/awt/viewer/images
fopLogo.gif
> logo_big.jpg
> src/java/org/apache/fop/render/bitmap TIFFRenderer.java
> PNGRenderer.java PNGRenderer_onthefly.java
> src/java/org/apache/fop/render/print PrintRenderer.java
> Removed: src/java/org/apache/fop/render/awt AWTGraphicsState.java
> FontSetup.java AWTFontMetrics.java
> AWTPrintRenderer.java RendererState.java
> FontMetricsMapper.java
> Log:
> Bugzilla: #33760
> Resurrected Java2D/AWT Renderer (including bitmap output to PNG and TIFF
using the Batik codecs and print capability).
> Submitted by: Renaud Richardet <renaud.richardet.at.gmail.com>
>
> Changes on the original patch:
> - PageViewport: isResolved() caused a NPE which I fixed.
>
> Revision Changes Path
> 1.1
xml-fop/src/java/org/apache/fop/render/java2d/FontMetricsMapper.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/FontMetricsMapper.java?rev=1.1
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/java2d/Java2DFontMetrics.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/Java2DFontMetrics.java?rev=1.1
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/java2d/Java2DRenderer.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/Java2DRenderer.java?rev=1.1
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/java2d/FontSetup.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/FontSetup.java?rev=1.1
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/java2d/Java2DGraphicsState.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/Java2DGraphicsState.java?rev=1.1
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/java2d/RendererState.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/java2d/RendererState.java?rev=1.1
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/awt/viewer/images/fopLogo.gif
>
> <<Binary file>>
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/awt/viewer/images/logo_big.jpg
>
> <<Binary file>>
>
>
> 1.35 +82 -1037
xml-fop/src/java/org/apache/fop/render/awt/AWTRenderer.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/awt/AWTRenderer.java.diff?r1=1.34&r2=1.35
>
>
> 1.9 +121 -90
xml-fop/src/java/org/apache/fop/render/awt/viewer/PreviewDialog.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/awt/viewer/PreviewDialog.java.diff?r1=1.8&r2=1.9
>
>
> 1.4 +7 -7
xml-fop/src/java/org/apache/fop/render/awt/viewer/PreviewDialogAboutBox.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/awt/viewer/PreviewDialogAboutBox.java.diff?r1=1.3&r2=1.4
>
>
> 1.18 +3 -1
xml-fop/src/java/org/apache/fop/area/PageViewport.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/area/PageViewport.java.diff?r1=1.17&r2=1.18
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/bitmap/TIFFRenderer.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/bitmap/TIFFRenderer.java?rev=1.1
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/bitmap/PNGRenderer.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/bitmap/PNGRenderer.java?rev=1.1
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/bitmap/PNGRenderer_onthefly.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/bitmap/PNGRenderer_onthefly.java?rev=1.1
>
>
> 1.20 +11 -0
xml-fop/src/java/org/apache/fop/tools/anttasks/Fop.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/tools/anttasks/Fop.java.diff?r1=1.19&r2=1.20
>
>
> 1.24 +21 -3
xml-fop/src/java/org/apache/fop/apps/FOUserAgent.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/apps/FOUserAgent.java.diff?r1=1.23&r2=1.24
>
>
> 1.22 +6 -3 xml-fop/src/java/org/apache/fop/apps/Fop.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/apps/Fop.java.diff?r1=1.21&r2=1.22
>
>
> 1.34 +39 -1
xml-fop/src/java/org/apache/fop/apps/CommandLineOptions.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/apps/CommandLineOptions.java.diff?r1=1.33&r2=1.34
>
>
> 1.27 +7 -3 xml-fop/src/java/org/apache/fop/fo/Constants.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/fo/Constants.java.diff?r1=1.26&r2=1.27
>
>
> 1.1
xml-fop/src/java/org/apache/fop/render/print/PrintRenderer.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/print/PrintRenderer.java?rev=1.1
>
>
> 1.22 +1 -1
xml-fop/src/java/org/apache/fop/render/svg/SVGRenderer.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/svg/SVGRenderer.java.diff?r1=1.21&r2=1.22
>
>
> 1.3 +6 -2
xml-fop/src/java/org/apache/fop/render/RendererFactory.java
>
>
http://cvs.apache.org/viewcvs/xml-fop/src/java/org/apache/fop/render/RendererFactory.java.diff?r1=1.2&r2=1.3
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
>