You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "shukitchan (via GitHub)" <gi...@apache.org> on 2024/01/08 19:30:05 UTC
[PR] Fix problem with the negation in TextView/libswoc [trafficserver]
shukitchan opened a new pull request, #10971:
URL: https://github.com/apache/trafficserver/pull/10971
ABS_MIN is 9223372036854775808
intmax_t is -9223372036854775808
negation of that is overflow for intmax_t with max of 9223372036854775807
And I think that's the intention as well.
So I need to make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem with the negation in TextView/libswoc [trafficserver]
Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on PR #10971:
URL: https://github.com/apache/trafficserver/pull/10971#issuecomment-1881700334
This is needed for the problem found in oss fuzz - https://oss-fuzz.com/testcase-detail/5196561539530752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem with the negation in TextView/libswoc [trafficserver]
Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on PR #10971:
URL: https://github.com/apache/trafficserver/pull/10971#issuecomment-1881700666
/src/trafficserver/lib/swoc/src/TextView.cc:66:16: runtime error: negation of -9223372036854775808 cannot be represented in type 'intmax_t' (aka 'long'); cast to an unsigned type to negate this value to itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem with the negation in TextView/libswoc [trafficserver]
Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan merged PR #10971:
URL: https://github.com/apache/trafficserver/pull/10971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem with the negation in TextView/libswoc [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10971:
URL: https://github.com/apache/trafficserver/pull/10971#issuecomment-1881935085
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix problem with the negation in TextView/libswoc [trafficserver]
Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on PR #10971:
URL: https://github.com/apache/trafficserver/pull/10971#issuecomment-1890882693
Created https://github.com/SolidWallOfCode/libswoc/pull/92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org