[GitHub] [lucene-solr] dweiss commented on issue #1390: LUCENE-9266 remove gradle wrapper jar from source

[GitBox <gi...@apache.org>]

dweiss commented on issue #1390: LUCENE-9266 remove gradle wrapper jar from source
URL: https://github.com/apache/lucene-solr/pull/1390#issuecomment-607224015
 
 
   [changes.patch.txt](https://github.com/apache/lucene-solr/files/4415071/changes.patch.txt)
   
   Hi Mike. I've restructured the downloader class a bit so that gradle wrapper version and checksum are aligned with the target file - makes it a single place to change things (instead of messing with the scripts). I also simplified error messaging a bit, hope it's ok.
   
   More interestingly I discovered a hideous problem with CLASSPATH environment variable: this is used by java in single-source mode and was locking the wrapper file (on Windows), effectively preventing any changes (in case of overwriting due to a wrong checksum, for example). Corrected.
   
   Looks good to me to commit this in (removing the gradle-wrapper.jar file). Anything else can be a follow-up.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org