[jira] [Commented] (TS-4074) build_* variables need to be escaped

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059319#comment-15059319 ] 

ASF GitHub Bot commented on TS-4074:
------------------------------------

GitHub user maskit opened a pull request:

    https://github.com/apache/trafficserver/pull/379

    TS-4074: Escape backslashes in user/group/machine name

    https://issues.apache.org/jira/browse/TS-4074
    
    The patch just replace one backslash with two backslashes.
    Is there more general way, like AC_FOO?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maskit/trafficserver ts4074

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #379
    
----
commit ac7c624309359de6a04835fd47a579cbf93a5354
Author: Masakazu Kitajo <mk...@yahoo-corp.jp>
Date:   2015-12-14T08:29:25Z

    TS-4074: Escape backslashes in user/group/machine name

----


> build_* variables need to be escaped
> ------------------------------------
>
>                 Key: TS-4074
>                 URL: https://issues.apache.org/jira/browse/TS-4074
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: Masakazu Kitajo
>            Assignee: Masakazu Kitajo
>             Fix For: 6.2.0
>
>
> BUILD_PERSON, BUILD_GROUP and BUILD_MACHINE need to be escaped.
> {noformat}
> traffic_layout.cc:79:32: error: unknown escape sequence '\D' [-Werror,-Wunknown-escape-sequence]
>   print_feature("BUILD_GROUP", BUILD_GROUP, json);
>                                ^
> ../../lib/ts/ink_config.h:49:46: note: expanded from macro 'BUILD_GROUP'
> #define BUILD_GROUP                    "XXX\Domain Users"
> {noformat}
> Current configure.ac
> {code}
> build_person="`id -nu`"
> build_group="`id -ng`"
> build_machine="`uname -n`"
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)