You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2016/04/29 20:01:25 UTC
[1/2] incubator-beam git commit: Remove redundant close in
BoundedReadEvaluatorFactory
Repository: incubator-beam
Updated Branches:
refs/heads/master 593bf0c53 -> bba4c64d3
Remove redundant close in BoundedReadEvaluatorFactory
The reader is already closed by virtue of being the target of the
try-with-resources block that encompasses all of #finishBundle().
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/08c05e01
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/08c05e01
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/08c05e01
Branch: refs/heads/master
Commit: 08c05e01b6248de853e8bc3d8446ed98d3408a6e
Parents: a9387fc
Author: Thomas Groh <tg...@google.com>
Authored: Wed Apr 27 17:03:44 2016 -0700
Committer: Thomas Groh <tg...@google.com>
Committed: Wed Apr 27 17:08:41 2016 -0700
----------------------------------------------------------------------
.../beam/sdk/runners/inprocess/BoundedReadEvaluatorFactory.java | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/08c05e01/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/BoundedReadEvaluatorFactory.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/BoundedReadEvaluatorFactory.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/BoundedReadEvaluatorFactory.java
index ef5581d..a394090 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/BoundedReadEvaluatorFactory.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/inprocess/BoundedReadEvaluatorFactory.java
@@ -146,7 +146,6 @@ final class BoundedReadEvaluatorFactory implements TransformEvaluatorFactory {
reader.getCurrent(), reader.getCurrentTimestamp()));
contentsRemaining = reader.advance();
}
- reader.close();
return StepTransformResult.withHold(transform, BoundedWindow.TIMESTAMP_MAX_VALUE)
.addOutput(output)
.build();
[2/2] incubator-beam git commit: This closes #257
Posted by ke...@apache.org.
This closes #257
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/bba4c64d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/bba4c64d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/bba4c64d
Branch: refs/heads/master
Commit: bba4c64d341e9b1d7961a5e89426950b3a387155
Parents: 593bf0c 08c05e0
Author: Kenneth Knowles <kl...@google.com>
Authored: Fri Apr 29 11:01:10 2016 -0700
Committer: Kenneth Knowles <kl...@google.com>
Committed: Fri Apr 29 11:01:10 2016 -0700
----------------------------------------------------------------------
.../beam/sdk/runners/inprocess/BoundedReadEvaluatorFactory.java | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------