You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/01/24 18:09:31 UTC
[GitHub] mgaido91 commented on issue #138: [LIVY-547]do not check expire
when session in state busy
mgaido91 commented on issue #138: [LIVY-547]do not check expire when session in state busy
URL: https://github.com/apache/incubator-livy/pull/138#issuecomment-457298811
This would be a behavior change, so at very least I think we should add a config option and documentation for it. Anyway, it depends on what you consider as "Inactive". In the current behavior, "Inactive" refers to the session abstraction in Livy server. So if a user doesn't access it, that object is inactive. If you consider the Spark job, instead, the right behavior is the one described in this PR.
I agree the current behavior is confusing (I got confused myself at the beginning) and despite the workaround is easy (there is a REST endpoint for avoiding the timeout...), it would be good to clarify and document it better. So, to summarize, I think we should first document properly the current status rather than doing a behavior change as proposed in this PR.
cc @vanzin too for his opinion on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services