You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/02 02:44:28 UTC
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6211: check mysql keyword
tristaZero commented on a change in pull request #6211:
URL: https://github.com/apache/shardingsphere/pull/6211#discussion_r448717115
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DDLStatement.g4
##########
@@ -65,11 +65,11 @@ dropIndex
;
algorithmOption
- : ALGORITHM EQ_? (DEFAULT | INPLACE | COPY)
+ : ALGORITHM EQ_? (DEFAULT | 'INPLACE' | 'COPY')
;
lockOption
- : LOCK EQ_? (DEFAULT | NONE | SHARED | EXCLUSIVE)
+ : LOCK EQ_? (DEFAULT | NONE | 'SHARED' | 'EXCLUSIVE')
Review comment:
Please double-check `'SHARED' | 'EXCLUSIVE' 'SHARED' | 'EXCLUSIVE'`
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DALStatement.g4
##########
@@ -151,7 +151,7 @@ showEngines
;
showErrors
- : SHOW (COUNT LP_ ASTERISK_ RP_)? ERRORS (LIMIT (NUMBER_ COMMA_)? NUMBER_)?
+ : SHOW (('COUNT'|'count') LP_ ASTERISK_ RP_)? ERRORS (LIMIT (NUMBER_ COMMA_)? NUMBER_)?
Review comment:
You missed this one `('COUNT'|'count') `, didn't you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org