You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by er...@apache.org on 2005/08/19 10:00:30 UTC

svn commit: r233452 - in /directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain: ./ Chain.java Command.java Context.java Filter.java impl/ impl/ChainBase.java impl/CommandBase.java impl/ContextBase.java

Author: erodriguez
Date: Fri Aug 19 01:00:24 2005
New Revision: 233452

URL: http://svn.apache.org/viewcvs?rev=233452&view=rev
Log:
Infrastructure for supporting the chain pattern.

Added:
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Chain.java   (with props)
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Command.java   (with props)
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Context.java   (with props)
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Filter.java   (with props)
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ChainBase.java   (with props)
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/CommandBase.java   (with props)
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ContextBase.java   (with props)

Added: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Chain.java
URL: http://svn.apache.org/viewcvs/directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Chain.java?rev=233452&view=auto
==============================================================================
--- directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Chain.java (added)
+++ directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Chain.java Fri Aug 19 01:00:24 2005
@@ -0,0 +1,117 @@
+/*
+ * Copyright 2003-2004 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kerberos.chain;
+
+
+/**
+ * <p>A {@link Chain} represents a configured list of
+ * {@link Command}s that will be executed in order to perform processing
+ * on a specified {@link Context}.  Each included {@link Command} will be
+ * executed in turn, until either one of them returns <code>true</code>,
+ * one of the executed {@link Command}s throws an exception,
+ * or the end of the chain has been reached.  The {@link Chain} itself will
+ * return the return value of the last {@link Command} that was executed
+ * (if no exception was thrown), or rethrow the thrown exception.</p>
+ *
+ * <p>Note that {@link Chain} extends {@link Command}, so that the two can
+ * be used interchangeably when a {@link Command} is expected.  This makes it
+ * easy to assemble workflows in a hierarchical manner by combining subchains
+ * into an overall processing chain.</p>
+ *
+ * <p>To protect applications from evolution of this interface, specialized
+ * implementations of {@link Chain} should generally be created by extending
+ * the provided base class {@link org.apache.kerberos.chain.impl.ChainBase})
+ * rather than directly implementing this interface.</p>
+ *
+ * <p>{@link Chain} implementations should be designed in a thread-safe
+ * manner, suitable for execution on multiple threads simultaneously.  In
+ * general, this implies that the state information identifying which
+ * {@link Command} is currently being executed should be maintained in a
+ * local variable inside the <code>execute()</code> method, rather than
+ * in an instance variable.  The {@link Command}s in a {@link Chain} may be
+ * configured (via calls to <code>addCommand()</code>) at any time before
+ * the <code>execute()</code> method of the {@link Chain} is first called.
+ * After that, the configuration of the {@link Chain} is frozen.</p>
+ *
+ * @author Craig R. McClanahan
+ * @version $Revision: 1.6 $ $Date: 2004/02/25 00:01:07 $
+ */
+
+public interface Chain extends Command {
+
+
+    /**
+     * <p>Add a {@link Command} to the list of {@link Command}s that will
+     * be called in turn when this {@link Chain}'s <code>execute()</code>
+     * method is called.  Once <code>execute()</code> has been called
+     * at least once, it is no longer possible to add additional
+     * {@link Command}s; instead, an exception will be thrown.</p>
+     *
+     * @param command The {@link Command} to be added
+     *
+     * @exception IllegalArgumentException if <code>command</code>
+     *  is <code>null</code>
+     * @exception IllegalStateException if this {@link Chain} has already
+     *  been executed at least once, so no further configuration is allowed
+     */
+    void addCommand(Command command);
+
+
+    /**
+     * <p>Execute the processing represented by this {@link Chain} according
+     * to the following algorithm.</p>
+     * <ul>
+     * <li>If there are no configured {@link Command}s in the {@link Chain},
+     *     return <code>false</code>.</li>
+     * <li>Call the <code>execute()</code> method of each {@link Command}
+     *     configured on this chain, in the order they were added via calls
+     *     to the <code>addCommand()</code> method, until the end of the
+     *     configured {@link Command}s is encountered, or until one of
+     *     the executed {@link Command}s returns <code>true</code>
+     *     or throws an exception.</li>
+     * <li>Walk backwards through the {@link Command}s whose
+     *     <code>execute()</code> methods, starting with the last one that
+     *     was executed.  If this {@link Command} instance is also a
+     *     {@link Filter}, call its <code>postprocess()</code> method,
+     *     discarding any exception that is thrown.</li>
+     * <li>If the last {@link Command} whose <code>execute()</code> method
+     *     was called threw an exception, rethrow that exception.</li>
+     * <li>Otherwise, return the value returned by the <code>execute()</code>
+     *     method of the last {@link Command} that was executed.  This will be
+     *     <code>true</code> if the last {@link Command} indicated that
+     *     processing of this {@link Context} has been completed, or
+     *     <code>false</code> if none of the called {@link Command}s
+     *     returned <code>true</code>.</li>
+     * </ul>
+     *
+     * @param context The {@link Context} to be processed by this
+     *  {@link Chain}
+     *
+     * @exception Exception if thrown by one of the {@link Command}s
+     *  in this {@link Chain} but not handled by a <code>postprocess()</code>
+     *  method of a {@link Filter}
+     * @exception IllegalArgumentException if <code>context</code>
+     *  is <code>null</code>
+     *
+     * @return <code>true</code> if the processing of this {@link Context}
+     *  has been completed, or <code>false</code> if the processing
+     *  of this {@link Context} should be delegated to a subsequent
+     *  {@link Command} in an enclosing {@link Chain}
+     */
+    boolean execute(Context context) throws Exception;
+
+
+}

Propchange: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Chain.java
------------------------------------------------------------------------------
    svn:eol-style = native

Added: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Command.java
URL: http://svn.apache.org/viewcvs/directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Command.java?rev=233452&view=auto
==============================================================================
--- directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Command.java (added)
+++ directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Command.java Fri Aug 19 01:00:24 2005
@@ -0,0 +1,105 @@
+/*
+ * Copyright 2003-2004 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kerberos.chain;
+
+
+/**
+ * <p>A {@link Command} encapsulates a unit of processing work to be
+ * performed, whose purpose is to examine and/or modify the state of a
+ * transaction that is represented by a {@link Context}.  Individual
+ * {@link Command}s can be assembled into a {@link Chain}, which allows
+ * them to either complete the required processing or delegate further
+ * processing to the next {@link Command} in the {@link Chain}.</p>
+ *
+ * <p>{@link Command} implementations should be designed in a thread-safe
+ * manner, suitable for inclusion in multiple {@link Chain}s that might be
+ * processed by different threads simultaneously.  In general, this implies
+ * that {@link Command} classes should not maintain state information in
+ * instance variables.  Instead, state information should be maintained via
+ * suitable modifications to the attributes of the {@link Context} that is
+ * passed to the <code>execute()</code> command.</p>
+ *
+ * <p>{@link Command} implementations typically retrieve and store state
+ * information in the {@link Context} instance that is passed as a parameter
+ * to the <code>execute()</code> method, using particular keys into the
+ * <code>Map</code> that can be acquired via
+ * <code>Context.getAttributes()</code>.  To improve interoperability of
+ * {@link Command} implementations, a useful design pattern is to expose the
+ * key values used as JavaBeans properties of the {@link Command}
+ * implementation class itself.  For example, a {@link Command} that requires
+ * an input and an output key might implement the following properties:</p>
+ *
+ * <pre>
+ *   private String inputKey = "input";
+ *   public String getInputKey() {
+ *     return (this.inputKey);
+ *   }
+ *   public void setInputKey(String inputKey) {
+ *     this.inputKey = inputKey;
+ *   }
+ *
+ *   private String outputKey = "output";
+ *   public String getOutputKey() {
+ *     return (this.outputKey);
+ *   }
+ *   public void setOutputKey(String outputKey) {
+ *     this.outputKey = outputKey;
+ *   }
+ * </pre>
+ *
+ * <p>And the operation of accessing the "input" information in the context
+ * would be executed by calling:</p>
+ *
+ * <pre>
+ *   String input = (String) context.get(getInputKey());
+ * </pre>
+ *
+ * <p>instead of hard coding the attribute name.  The use of the "Key"
+ * suffix on such property names is a useful convention to identify properties
+ * being used in this fashion, as opposed to JavaBeans properties that simply
+ * configure the internal operation of this {@link Command}.</p>
+ *
+ * @author Craig R. McClanahan
+ * @version $Revision: 1.5 $ $Date: 2004/02/25 00:01:07 $
+ */
+
+public interface Command {
+
+
+    /**
+     * <p>Execute a unit of processing work to be performed.  This
+     * {@link Command} may either complete the required processing
+     * and return <code>true</code>, or delegate remaining processing
+     * to the next {@link Command} in a {@link Chain} containing this
+     * {@link Command} by returning <code>false</code>
+     *
+     * @param context The {@link Context} to be processed by this
+     *  {@link Command}
+     *
+     * @exception Exception general purpose exception return
+     *  to indicate abnormal termination
+     * @exception IllegalArgumentException if <code>context</code>
+     *  is <code>null</code>
+     *
+     * @return <code>true</code> if the processing of this {@link Context}
+     *  has been completed, or <code>false</code> if the processing
+     *  of this {@link Context} should be delegated to a subsequent
+     *  {@link Command} in an enclosing {@link Chain}
+     */
+    boolean execute(Context context) throws Exception;
+
+
+}

Propchange: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Command.java
------------------------------------------------------------------------------
    svn:eol-style = native

Added: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Context.java
URL: http://svn.apache.org/viewcvs/directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Context.java?rev=233452&view=auto
==============================================================================
--- directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Context.java (added)
+++ directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Context.java Fri Aug 19 01:00:24 2005
@@ -0,0 +1,65 @@
+/*
+ * Copyright 2003-2004 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kerberos.chain;
+
+
+import java.util.Map;
+
+
+/**
+ * <p>A {@link Context} represents the state information that is
+ * accessed and manipulated by the execution of a {@link Command} or a
+ * {@link Chain}.  Specialized implementations of {@link Context} will
+ * typically add JavaBeans properties that contain typesafe accessors
+ * to information that is relevant to a particular use case for this
+ * context, and/or add operations that affect the state information
+ * that is saved in the context.</p>
+ *
+ * <p>Implementations of {@link Context} must also implement all of the
+ * required and optional contracts of the <code>java.util.Map</code>
+ * interface.</p>
+ *
+ * <p>It is strongly recommended, but not required, that JavaBeans
+ * properties added to a particular {@link Context} implementation exhibit
+ * <em>Attribute-Property Transparency</em>.  In other words,
+ * a value stored via a call to <code>setFoo(value)</code> should be visible
+ * by calling <code>get("foo")</code>, and a value stored
+ * via a call to <code>put("foo", value)</code> should be
+ * visible by calling <code>getFoo()</code>.  If your {@link Context}
+ * implementation class exhibits this featue, it becomes easier to reuse the
+ * implementation in multiple environments, without the need to cast to a
+ * particular implementation class in order to access the property getter
+ * and setter methods.</p>
+ *
+ * <p>To protect applications from evolution of this interface, specialized
+ * implementations of {@link Context} should generally be created by extending
+ * the provided base class ({@link org.apache.kerberos.chain.impl.ContextBase})
+ * rather than directly implementing this interface.</p>
+ *
+ * <p>Applications should <strong>NOT</strong> assume that
+ * {@link Context} implementations, or the values stored in its
+ * attributes, may be accessed from multiple threads
+ * simultaneously unless this is explicitly documented for a particular
+ * implementation.</p>
+ *
+ * @author Craig R. McClanahan
+ * @version $Revision: 1.6 $ $Date: 2004/02/25 00:01:07 $
+ */
+
+public interface Context extends Map {
+
+
+}

Propchange: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Context.java
------------------------------------------------------------------------------
    svn:eol-style = native

Added: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Filter.java
URL: http://svn.apache.org/viewcvs/directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Filter.java?rev=233452&view=auto
==============================================================================
--- directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Filter.java (added)
+++ directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Filter.java Fri Aug 19 01:00:24 2005
@@ -0,0 +1,67 @@
+/*
+ * Copyright 2003-2004 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kerberos.chain;
+
+
+/**
+ * <p>A {@link Filter} is a specialized {@link Command} that also expects
+ * the {@link Chain} that is executing it to call the
+ * <code>postprocess()</code> method if it called the <code>execute()</code>
+ * method.  This promise must be fulfilled in spite of any possible
+ * exceptions thrown by the <code>execute()</code> method of this
+ * {@link Command}, or any subsequent {@link Command} whose
+ * <code>execute()</code> method was called.  The owning {@link Chain}
+ * must call the <code>postprocess()</code> method of each {@link Filter}
+ * in a {@link Chain} in reverse order of the invocation of their
+ * <code>execute()</code> methods.</p>
+ *
+ * <p>The most common use case for a {@link Filter}, as opposed to a
+ * {@link Command}, is where potentially expensive resources must be acquired
+ * and held until the processing of a particular request has been completed,
+ * even it execution is delegated to a subsequent {@link Command} via the
+ * <code>execute()</code> returning <code>false</code>.  A {@link Filter}
+ * can reliably release such resources in the <code>postprocess()</code>
+ * method, which is guaranteed to be called by the owning {@link Chain}.</p>
+ *
+ * @author Craig R. McClanahan
+ * @version $Revision: 1.6 $ $Date: 2004/11/30 05:52:23 $
+ */
+
+public interface Filter extends Command {
+
+
+    /**
+     * <p>Execute any cleanup activities, such as releasing resources that
+     * were acquired during the <code>execute()</code> method of this
+     * {@link Filter} instance.</p>
+     *
+     * @param context The {@link Context} to be processed by this
+     *  {@link Filter}
+     * @param exception The <code>Exception</code> (if any) that was thrown
+     *  by the last {@link Command} that was executed; otherwise
+     *  <code>null</code>
+     *
+     * @exception IllegalArgumentException if <code>context</code>
+     *  is <code>null</code>
+     *
+     * @return If a non-null <code>exception</code> was "handled" by this
+     *  method (and therefore need not be rethrown), return <code>true</code>;
+     *  otherwise return <code>false</code>
+     */
+   boolean postprocess(Context context, Exception exception);
+
+
+}

Propchange: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/Filter.java
------------------------------------------------------------------------------
    svn:eol-style = native

Added: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ChainBase.java
URL: http://svn.apache.org/viewcvs/directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ChainBase.java?rev=233452&view=auto
==============================================================================
--- directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ChainBase.java (added)
+++ directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ChainBase.java Fri Aug 19 01:00:24 2005
@@ -0,0 +1,223 @@
+/*
+ * Copyright 1999-2004 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kerberos.chain.impl;
+
+
+import java.util.Collection;
+import java.util.Iterator;
+
+import org.apache.kerberos.chain.Chain;
+import org.apache.kerberos.chain.Command;
+import org.apache.kerberos.chain.Context;
+import org.apache.kerberos.chain.Filter;
+
+
+/**
+ * <p>Convenience base class for {@link Chain} implementations.</p>
+ *
+ * @author Craig R. McClanahan
+ * @version $Revision: 1.6 $ $Date: 2004/11/30 05:52:23 $
+ */
+
+public class ChainBase implements Chain {
+
+
+    // ----------------------------------------------------------- Constructors
+
+
+    /**
+     * <p>Construct a {@link Chain} with no configured {@link Command}s.</p>
+     */
+    public ChainBase() {
+
+    }
+
+
+    /**
+     * <p>Construct a {@link Chain} configured with the specified
+     * {@link Command}.</p>
+     *
+     * @param command The {@link Command} to be configured
+     *
+     * @exception IllegalArgumentException if <code>command</code>
+     *  is <code>null</code>
+     */
+    public ChainBase(Command command) {
+
+        addCommand(command);
+
+    }
+
+
+    /**
+     * <p>Construct a {@link Chain} configured with the specified
+     * {@link Command}s.</p>
+     *
+     * @param commands The {@link Command}s to be configured
+     *
+     * @exception IllegalArgumentException if <code>commands</code>,
+     *  or one of the individual {@link Command} elements,
+     *  is <code>null</code>
+     */
+    public ChainBase(Command[] commands) {
+
+        if (commands == null) {
+            throw new IllegalArgumentException();
+        }
+        for (int i = 0; i < commands.length; i++) {
+            addCommand(commands[i]);
+        }
+
+    }
+
+
+    /**
+     * <p>Construct a {@link Chain} configured with the specified
+     * {@link Command}s.</p>
+     *
+     * @param commands The {@link Command}s to be configured
+     *
+     * @exception IllegalArgumentException if <code>commands</code>,
+     *  or one of the individual {@link Command} elements,
+     *  is <code>null</code>
+     */
+    public ChainBase(Collection commands) {
+
+        if (commands == null) {
+            throw new IllegalArgumentException();
+        }
+        Iterator elements = commands.iterator();
+        while (elements.hasNext()) {
+            addCommand((Command) elements.next());
+        }
+
+    }
+
+
+    // ----------------------------------------------------- Instance Variables
+
+
+    /**
+     * <p>The list of {@link Command}s configured for this {@link Chain}, in
+     * the order in which they may delegate processing to the remainder of
+     * the {@link Chain}.</p>
+     */
+    protected Command[] commands = new Command[0];
+
+
+    /**
+     * <p>Flag indicating whether the configuration of our commands list
+     * has been frozen by a call to the <code>execute()</code> method.</p>
+     */
+    protected boolean frozen = false;
+
+
+    // ---------------------------------------------------------- Chain Methods
+
+
+    // Documented in Chain interface
+    public void addCommand(Command command) {
+
+        if (command == null) {
+            throw new IllegalArgumentException();
+        }
+        if (frozen) {
+            throw new IllegalStateException();
+        }
+        Command[] results = new Command[commands.length + 1];
+        System.arraycopy(commands, 0, results, 0, commands.length);
+        results[commands.length] = command;
+        commands = results;
+
+    }
+
+
+    // Documented in Chain interface
+    public boolean execute(Context context) throws Exception {
+
+        // Verify our parameters
+        if (context == null) {
+            throw new IllegalArgumentException();
+        }
+
+        // Freeze the configuration of the command list
+        frozen = true;
+
+        // Execute the commands in this list until one returns true
+        // or throws an exception
+        boolean saveResult = false;
+        Exception saveException = null;
+        int i = 0;
+        int n = commands.length;;
+        for (i = 0; i < n; i++) {
+            try {
+                saveResult = commands[i].execute(context);
+                if (saveResult) {
+                    break;
+                }
+            } catch (Exception e) {
+                saveException = e;
+                break;
+            }
+        }
+
+        // Call postprocess methods on Filters in reverse order
+        if (i >= n) { // Fell off the end of the chain
+            i--;
+        }
+        boolean handled = false;
+        boolean result = false;
+        for (int j = i; j >= 0; j--) {
+            if (commands[j] instanceof Filter) {
+                try {
+                    result =
+                        ((Filter) commands[j]).postprocess(context,
+                                                           saveException);
+                    if (result) {
+                        handled = true;
+                    }
+                } catch (Exception e) {
+                    ; // Silently ignore
+                }
+            }
+        }
+
+        // Return the exception or result state from the last execute()
+        if ((saveException != null) && !handled) {
+            throw saveException;
+        } else {
+            return (saveResult);
+        }
+
+    }
+
+
+    // -------------------------------------------------------- Package Methods
+
+
+    /**
+     * <p>Return an array of the configured {@link Command}s for this
+     * {@link Chain}.  This method is package private, and is used only
+     * for the unit tests.</p>
+     */
+    Command[] getCommands() {
+
+        return (commands);
+
+    }
+
+
+}

Propchange: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ChainBase.java
------------------------------------------------------------------------------
    svn:eol-style = native

Added: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/CommandBase.java
URL: http://svn.apache.org/viewcvs/directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/CommandBase.java?rev=233452&view=auto
==============================================================================
--- directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/CommandBase.java (added)
+++ directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/CommandBase.java Fri Aug 19 01:00:24 2005
@@ -0,0 +1,31 @@
+/*
+ *   Copyright 2005 The Apache Software Foundation
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ *
+ */
+package org.apache.kerberos.chain.impl;
+
+import org.apache.kerberos.chain.Command;
+
+/**
+ * <p>Convenience base class for {@link Command} implementations.</p>
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$
+ */
+public abstract class CommandBase implements Command
+{
+    public static final boolean STOP_CHAIN = true;
+    public static final boolean CONTINUE_CHAIN = false;
+}

Propchange: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/CommandBase.java
------------------------------------------------------------------------------
    svn:eol-style = native

Added: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ContextBase.java
URL: http://svn.apache.org/viewcvs/directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ContextBase.java?rev=233452&view=auto
==============================================================================
--- directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ContextBase.java (added)
+++ directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ContextBase.java Fri Aug 19 01:00:24 2005
@@ -0,0 +1,790 @@
+/*
+ * Copyright 1999-2004 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kerberos.chain.impl;
+
+
+import java.beans.IntrospectionException;
+import java.beans.Introspector;
+import java.beans.PropertyDescriptor;
+import java.lang.reflect.Method;
+import java.util.AbstractCollection;
+import java.util.AbstractSet;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.Set;
+
+import org.apache.kerberos.chain.Context;
+
+
+/**
+ * <p>Convenience base class for {@link Context} implementations.</p>
+ *
+ * <p>In addition to the minimal functionality required by the {@link Context}
+ * interface, this class implements the recommended support for
+ * <em>Attribute-Property Transparency</p>.  This is implemented by
+ * analyzing the available JavaBeans properties of this class (or its
+ * subclass), exposes them as key-value pairs in the <code>Map</code>,
+ * with the key being the name of the property itself.</p>
+ *
+ * <p><strong>IMPLEMENTATION NOTE</strong> - Because <code>empty</code> is a
+ * read-only property defined by the <code>Map</code> interface, it may not
+ * be utilized as an attribute key or property name.</p>
+ *
+ * @author Craig R. McClanahan
+ * @version $Revision: 1.7 $ $Date: 2004/11/30 05:52:23 $
+ */
+
+public class ContextBase extends HashMap implements Context {
+
+
+    // ------------------------------------------------------------ Constructors
+
+
+    /**
+     * Default, no argument constructor.
+     */
+    public ContextBase() {
+
+        super();
+        initialize();
+
+    }
+
+
+    /**
+     * <p>Initialize the contents of this {@link Context} by copying the
+     * values from the specified <code>Map</code>.  Any keys in <code>map</code>
+     * that correspond to local properties will cause the setter method for
+     * that property to be called.</p>
+     *
+     * @param map Map whose key-value pairs are added
+     *
+     * @exception IllegalArgumentException if an exception is thrown
+     *  writing a local property value
+     * @exception UnsupportedOperationException if a local property does not
+     *  have a write method.
+     */
+    public ContextBase(Map map) {
+
+        super(map);
+        initialize();
+        putAll(map);
+
+    }
+
+
+    // ------------------------------------------------------ Instance Variables
+
+
+    /**
+     * <p>The <code>PropertyDescriptor</code>s for all JavaBeans properties
+     * of this {@link Context} implementation class, keyed by property name.
+     * This collection is allocated only if there are any JavaBeans
+     * properties.</p>
+     */
+    private Map descriptors = null;
+
+
+    /**
+     * <p>The same <code>PropertyDescriptor</code>s as an array.</p>
+     */
+    private PropertyDescriptor[] pd = null;
+
+
+    /**
+     * <p>Distinguished singleton value that is stored in the map for each
+     * key that is actually a property.  This value is used to ensure that
+     * <code>equals()</code> comparisons will always fail.</p>
+     */
+    private static Object singleton;
+
+    static {
+
+        singleton = new Object() {
+                public boolean equals(Object object) {
+                    return (false);
+                }
+            };
+
+    }
+
+
+    /**
+     * <p>Zero-length array of parameter values for calling property getters.
+     * </p>
+     */
+    private static Object[] zeroParams = new Object[0];
+
+
+    // ------------------------------------------------------------- Map Methods
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to clear all keys and
+     * values except those corresponding to JavaBeans properties.</p>
+     */
+    public void clear() {
+
+        if (descriptors == null) {
+            super.clear();
+        } else {
+            Iterator keys = keySet().iterator();
+            while (keys.hasNext()) {
+                Object key = keys.next();
+                if (!descriptors.containsKey(key)) {
+                    keys.remove();
+                }
+            }
+        }
+
+    }
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to return
+     * <code>true</code> if the specified value is present in either the
+     * underlying <code>Map</code> or one of the local property values.</p>
+     *
+     * @exception IllegalArgumentException if a property getter
+     *  throws an exception
+     */
+    public boolean containsValue(Object value) {
+
+        // Case 1 -- no local properties
+        if (descriptors == null) {
+            return (super.containsValue(value));
+        }
+
+        // Case 2 -- value found in the underlying Map
+        else if (super.containsValue(value)) {
+            return (true);
+        }
+
+        // Case 3 -- check the values of our readable properties
+        for (int i = 0; i < pd.length; i++) {
+            if (pd[i].getReadMethod() != null) {
+                Object prop = readProperty(pd[i]);
+                if (value == null) {
+                    if (prop == null) {
+                        return (true);
+                    }
+                } else if (value.equals(prop)) {
+                    return (true);
+                }
+            }
+        }
+        return (false);
+
+    }
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to return a
+     * <code>Set</code> that meets the specified default behavior except
+     * for attempts to remove the key for a property of the {@link Context}
+     * implementation class, which will throw
+     * <code>UnsupportedOperationException</code>.</p>
+     */
+    public Set entrySet() {
+
+        return (new EntrySetImpl());
+
+    }
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to return the value
+     * of a local property if the specified key matches a local property name.
+     * </p>
+     *
+     * <p><strong>IMPLEMENTATION NOTE</strong> - If the specified
+     * <code>key</code> identifies a write-only property, <code>null</code>
+     * will arbitrarily be returned, in order to avoid difficulties implementing
+     * the contracts of the <code>Map</code> interface.</p>
+     *
+     * @param key Key of the value to be returned
+     *
+     * @exception IllegalArgumentException if an exception is thrown
+     *  reading this local property value
+     * @exception UnsupportedOperationException if this local property does not
+     *  have a read method.
+     */
+    public Object get(Object key) {
+
+        // Case 1 -- no local properties
+        if (descriptors == null) {
+            return (super.get(key));
+        }
+
+        // Case 2 -- this is a local property
+        if (key != null) {
+            PropertyDescriptor descriptor =
+                (PropertyDescriptor) descriptors.get(key);
+            if (descriptor != null) {
+                if (descriptor.getReadMethod() != null) {
+                    return (readProperty(descriptor));
+                } else {
+                    return (null);
+                }
+            }
+        }
+
+        // Case 3 -- retrieve value from our underlying Map
+        return (super.get(key));
+
+    }
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to return
+     * <code>true</code> if the underlying <code>Map</code> only contains
+     * key-value pairs for local properties (if any).</p>
+     */
+    public boolean isEmpty() {
+
+        // Case 1 -- no local properties
+        if (descriptors == null) {
+            return (super.isEmpty());
+        }
+
+        // Case 2 -- compare key count to property count
+        return (super.size() <= descriptors.size());
+
+    }
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to return a
+     * <code>Set</code> that meets the specified default behavior except
+     * for attempts to remove the key for a property of the {@link Context}
+     * implementation class, which will throw
+     * <code>UnsupportedOperationException</code>.</p>
+     */
+    public Set keySet() {
+
+
+        return (super.keySet());
+
+    }
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to set the value
+     * of a local property if the specified key matches a local property name.
+     * </p>
+     *
+     * @param key Key of the value to be stored or replaced
+     * @param value New value to be stored
+     *
+     * @exception IllegalArgumentException if an exception is thrown
+     *  reading or wrting this local property value
+     * @exception UnsupportedOperationException if this local property does not
+     *  have both a read method and a write method
+     */
+    public Object put(Object key, Object value) {
+
+        // Case 1 -- no local properties
+        if (descriptors == null) {
+            return (super.put(key, value));
+        }
+
+        // Case 2 -- this is a local property
+        if (key != null) {
+            PropertyDescriptor descriptor =
+                (PropertyDescriptor) descriptors.get(key);
+            if (descriptor != null) {
+                Object previous = null;
+                if (descriptor.getReadMethod() != null) {
+                    previous = readProperty(descriptor);
+                }
+                writeProperty(descriptor, value);
+                return (previous);
+            }
+        }
+
+        // Case 3 -- store or replace value in our underlying map
+        return (super.put(key, value));
+
+    }
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to call the
+     * <code>put()</code> method individually for each key-value pair
+     * in the specified <code>Map</code>.</p>
+     *
+     * @param map <code>Map</code> containing key-value pairs to store
+     *  (or replace)
+     *
+     * @exception IllegalArgumentException if an exception is thrown
+     *  reading or wrting a local property value
+     * @exception UnsupportedOperationException if a local property does not
+     *  have both a read method and a write method
+     */
+    public void putAll(Map map) {
+
+        Iterator pairs = map.entrySet().iterator();
+        while (pairs.hasNext()) {
+            Map.Entry pair = (Map.Entry) pairs.next();
+            put(pair.getKey(), pair.getValue());
+        }
+
+    }
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to throw
+     * <code>UnsupportedOperationException</code> on any attempt to
+     * remove a key that is the name of a local property.</p>
+     *
+     * @param key Key to be removed
+     *
+     * @exception UnsupportedOperationException if the specified
+     *  <code>key</code> matches the name of a local property
+     */
+    public Object remove(Object key) {
+
+        // Case 1 -- no local properties
+        if (descriptors == null) {
+            return (super.remove(key));
+        }
+
+        // Case 2 -- this is a local property
+        if (key != null) {
+            PropertyDescriptor descriptor =
+                (PropertyDescriptor) descriptors.get(key);
+            if (descriptor != null) {
+                throw new UnsupportedOperationException
+                    ("Local property '" + key + "' cannot be removed");
+            }
+        }
+
+        // Case 3 -- remove from underlying Map
+        return (super.remove(key));
+
+    }
+
+
+    /**
+     * <p>Override the default <code>Map</code> behavior to return a
+     * <code>Collection</code> that meets the specified default behavior except
+     * for attempts to remove the key for a property of the {@link Context}
+     * implementation class, which will throw
+     * <code>UnsupportedOperationException</code>.</p>
+     */
+    public Collection values() {
+
+        return (new ValuesImpl());
+
+    }
+
+
+    // --------------------------------------------------------- Private Methods
+
+
+    /**
+     * <p>Eliminate the specified property descriptor from the list of
+     * property descriptors in <code>pd</code>.</p>
+     *
+     * @param name Name of the property to eliminate
+     *
+     * @exception IllegalArgumentException if the specified property name
+     *  is not present
+     */
+    private void eliminate(String name) {
+
+        int j = -1;
+        for (int i = 0; i < pd.length; i++) {
+            if (name.equals(pd[i].getName())) {
+                j = i;
+                break;
+            }
+        }
+        if (j < 0) {
+            throw new IllegalArgumentException("Property '" + name
+                                               + "' is not present");
+        }
+        PropertyDescriptor[] results = new PropertyDescriptor[pd.length - 1];
+        System.arraycopy(pd, 0, results, 0, j);
+        System.arraycopy(pd, j + 1, results, j, pd.length - (j + 1));
+        pd = results;
+
+    }
+
+
+    /**
+     * <p>Return an <code>Iterator</code> over the set of <code>Map.Entry</code>
+     * objects representing our key-value pairs.</p>
+     */
+    private Iterator entriesIterator() {
+
+        return (new EntrySetIterator());
+
+    }
+
+
+    /**
+     * <p>Return a <code>Map.Entry</code> for the specified key value, if it
+     * is present; otherwise, return <code>null</code>.</p>
+     *
+     * @param key Attribute key or property name
+     */
+    private Map.Entry entry(Object key) {
+
+        if (containsKey(key)) {
+            return (new MapEntryImpl(key, get(key)));
+        } else {
+            return (null);
+        }
+
+    }
+
+
+    /**
+     * <p>Customize the contents of our underlying <code>Map</code> so that
+     * it contains keys corresponding to all of the JavaBeans properties of
+     * the {@link Context} implementation class.</p>
+     *
+     *
+     * @exception IllegalArgumentException if an exception is thrown
+     *  writing this local property value
+     * @exception UnsupportedOperationException if this local property does not
+     *  have a write method.
+     */
+    private void initialize() {
+
+        // Retrieve the set of property descriptors for this Context class
+        try {
+            pd = Introspector.getBeanInfo
+                (getClass()).getPropertyDescriptors();
+        } catch (IntrospectionException e) {
+            pd = new PropertyDescriptor[0]; // Should never happen
+        }
+        eliminate("class"); // Because of "getClass()"
+        eliminate("empty"); // Because of "isEmpty()"
+
+        // Initialize the underlying Map contents
+        if (pd.length > 0) {
+            descriptors = new HashMap();
+            for (int i = 0; i < pd.length; i++) {
+                descriptors.put(pd[i].getName(), pd[i]);
+                super.put(pd[i].getName(), singleton);
+            }
+        }
+
+    }
+
+
+    /**
+     * <p>Get and return the value for the specified property.</p>
+     *
+     * @param descriptor <code>PropertyDescriptor</code> for the
+     *  specified property
+     *
+     * @exception IllegalArgumentException if an exception is thrown
+     *  reading this local property value
+     * @exception UnsupportedOperationException if this local property does not
+     *  have a read method.
+     */
+    private Object readProperty(PropertyDescriptor descriptor) {
+
+        try {
+            Method method = descriptor.getReadMethod();
+            if (method == null) {
+                throw new UnsupportedOperationException
+                    ("Property '" + descriptor.getName()
+                     + "' is not readable");
+            }
+            return (method.invoke(this, zeroParams));
+        } catch (Exception e) {
+            throw new UnsupportedOperationException
+                ("Exception reading property '" + descriptor.getName()
+                 + "': " + e.getMessage());
+        }
+
+    }
+
+
+    /**
+     * <p>Remove the specified key-value pair, if it exists, and return
+     * <code>true</code>.  If this pair does not exist, return
+     * <code>false</code>.</p>
+     *
+     * @param entry Key-value pair to be removed
+     *
+     * @exception UnsupportedOperationException if the specified key
+     *  identifies a property instead of an attribute
+     */
+    private boolean remove(Map.Entry entry) {
+
+        Map.Entry actual = entry(entry.getKey());
+        if (actual == null) {
+            return (false);
+        } else if (!entry.equals(actual)) {
+            return (false);
+        } else {
+            remove(entry.getKey());
+            return (true);
+        }
+
+    }
+
+
+    /**
+     * <p>Return an <code>Iterator</code> over the set of values in this
+     * <code>Map</code>.</p>
+     */
+    private Iterator valuesIterator() {
+
+        return (new ValuesIterator());
+
+    }
+
+
+    /**
+     * <p>Set the value for the specified property.</p>
+     *
+     * @param descriptor <code>PropertyDescriptor</code> for the
+     *  specified property
+     * @param value The new value for this property (must be of the
+     *  correct type)
+     *
+     * @exception IllegalArgumentException if an exception is thrown
+     *  writing this local property value
+     * @exception UnsupportedOperationException if this local property does not
+     *  have a write method.
+     */
+    private void writeProperty(PropertyDescriptor descriptor, Object value) {
+
+        try {
+            Method method = descriptor.getWriteMethod();
+            if (method == null) {
+                throw new UnsupportedOperationException
+                    ("Property '" + descriptor.getName()
+                     + "' is not writeable");
+            }
+            method.invoke(this, new Object[] { value });
+        } catch (Exception e) {
+            throw new UnsupportedOperationException
+                ("Exception writing property '" + descriptor.getName()
+                 + "': " + e.getMessage());
+        }
+
+    }
+
+
+    // --------------------------------------------------------- Private Classes
+
+
+    /**
+     * <p>Private implementation of <code>Set</code> that implements the
+     * semantics required for the value returned by <code>entrySet()</code>.</p>
+     */
+    private class EntrySetImpl extends AbstractSet {
+
+        public void clear() {
+            ContextBase.this.clear();
+        }
+
+        public boolean contains(Object obj) {
+            if (!(obj instanceof Map.Entry)) {
+                return (false);
+            }
+            Map.Entry entry = (Map.Entry) obj;
+            Entry actual = ContextBase.this.entry(entry.getKey());
+            if (actual != null) {
+                return (actual.equals(entry));
+            } else {
+                return (false);
+            }
+        }
+
+        public boolean isEmpty() {
+            return (ContextBase.this.isEmpty());
+        }
+
+        public Iterator iterator() {
+            return (ContextBase.this.entriesIterator());
+        }
+
+        public boolean remove(Object obj) {
+            if (obj instanceof Map.Entry) {
+                return (ContextBase.this.remove((Map.Entry) obj));
+            } else {
+                return (false);
+            }
+        }
+
+        public int size() {
+            return (ContextBase.this.size());
+        }
+
+    }
+
+
+    /**
+     * <p>Private implementation of <code>Iterator</code> for the
+     * <code>Set</code> returned by <code>entrySet()</code>.</p>
+     */
+    private class EntrySetIterator implements Iterator {
+
+        Map.Entry entry = null;
+        private Iterator keys = ContextBase.this.keySet().iterator();
+
+        public boolean hasNext() {
+            return (keys.hasNext());
+        }
+
+        public Object next() {
+            entry = ContextBase.this.entry(keys.next());
+            return (entry);
+        }
+
+        public void remove() {
+            ContextBase.this.remove(entry);
+        }
+
+    }
+
+
+    /**
+     * <p>Private implementation of <code>Map.Entry</code> for each item in
+     * <code>EntrySetImpl</code>.</p>
+     */
+    private class MapEntryImpl implements Map.Entry {
+
+        MapEntryImpl(Object key, Object value) {
+            this.key = key;
+            this.value = value;
+        }
+
+        private Object key;
+        private Object value;
+
+        public boolean equals(Object obj) {
+            if (obj == null) {
+                return (false);
+            } else if (!(obj instanceof Map.Entry)) {
+                return (false);
+            }
+            Map.Entry entry = (Map.Entry) obj;
+            if (key == null) {
+                return (entry.getKey() == null);
+            }
+            if (key.equals(entry.getKey())) {
+                if (value == null) {
+                    return (entry.getValue() == null);
+                } else {
+                    return (value.equals(entry.getValue()));
+                }
+            } else {
+                return (false);
+            }
+        }
+
+        public Object getKey() {
+            return (this.key);
+        }
+
+        public Object getValue() {
+            return (this.value);
+        }
+
+        public int hashCode() {
+            return (((key == null) ? 0 : key.hashCode())
+                   ^ ((value == null) ? 0 : value.hashCode()));
+        }
+
+        public Object setValue(Object value) {
+            Object previous = this.value;
+            ContextBase.this.put(this.key, value);
+            this.value = value;
+            return (previous);
+        }
+
+
+    }
+
+
+    /**
+     * <p>Private implementation of <code>Collection</code> that implements the
+     * semantics required for the value returned by <code>values()</code>.</p>
+     */
+    private class ValuesImpl extends AbstractCollection {
+
+        public void clear() {
+            ContextBase.this.clear();
+        }
+
+        public boolean contains(Object obj) {
+            if (!(obj instanceof Map.Entry)) {
+                return (false);
+            }
+            Map.Entry entry = (Map.Entry) obj;
+            return (ContextBase.this.containsValue(entry.getValue()));
+        }
+
+        public boolean isEmpty() {
+            return (ContextBase.this.isEmpty());
+        }
+
+        public Iterator iterator() {
+            return (ContextBase.this.valuesIterator());
+        }
+
+        public boolean remove(Object obj) {
+            if (obj instanceof Map.Entry) {
+                return (ContextBase.this.remove((Map.Entry) obj));
+            } else {
+                return (false);
+            }
+        }
+
+        public int size() {
+            return (ContextBase.this.size());
+        }
+
+    }
+
+
+    /**
+     * <p>Private implementation of <code>Iterator</code> for the
+     * <code>Collection</code> returned by <code>values()</code>.</p>
+     */
+    private class ValuesIterator implements Iterator {
+
+        Map.Entry entry = null;
+        private Iterator keys = ContextBase.this.keySet().iterator();
+
+        public boolean hasNext() {
+            return (keys.hasNext());
+        }
+
+        public Object next() {
+            entry = ContextBase.this.entry(keys.next());
+            return (entry.getValue());
+        }
+
+        public void remove() {
+            ContextBase.this.remove(entry);
+        }
+
+    }
+
+
+}

Propchange: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/chain/impl/ContextBase.java
------------------------------------------------------------------------------
    svn:eol-style = native