You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2017/01/05 01:50:29 UTC
Review Request 55193: Executing ambari-server unit tests with JDK 1.8
results in unit test failures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55193/
-----------------------------------------------------------
Review request for Ambari, Eugene Chekanskiy, Jaimin Jetly, Jonathan Hurley, Laszlo Puskas, and Nate Cole.
Bugs: AMBARI-19365
https://issues.apache.org/jira/browse/AMBARI-19365
Repository: ambari
Description
-------
Following unit tests fails when executed with JDK 1.8
```
mvn test -Dtest=DataStoreImplTest
mvn clean test -Dtest=UpgradeCatalog222Test
mvn test -Dtest=KerberosCheckerTest,AmbariBasicAuthenticationFilterTest
```
Same unit tests passes if the environment is switched to use JDK 1.7
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java e0a3d55
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/LoginContextHelper.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosCheckerTest.java 570a50b
ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/JvmMetricsSourceTest.java a6aa5d5
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilterTest.java 7e36128
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 9d4fb3e
ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java 60643b3
Diff: https://reviews.apache.org/r/55193/diff/
Testing
-------
Ran unit tests with Oracle JDK 1.7 and Oracle JDK 1.8.
Manually tested Ambari
Thanks,
Robert Levas
Re: Review Request 55193: Executing ambari-server unit tests with JDK
1.8 results in unit test failures
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55193/#review160589
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 4, 2017, 8:50 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55193/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 8:50 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Jaimin Jetly, Jonathan Hurley, Laszlo Puskas, and Nate Cole.
>
>
> Bugs: AMBARI-19365
> https://issues.apache.org/jira/browse/AMBARI-19365
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Following unit tests fails when executed with JDK 1.8
> ```
> mvn test -Dtest=DataStoreImplTest
> mvn clean test -Dtest=UpgradeCatalog222Test
> mvn test -Dtest=KerberosCheckerTest,AmbariBasicAuthenticationFilterTest
> ```
> Same unit tests passes if the environment is switched to use JDK 1.7
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java e0a3d55
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/LoginContextHelper.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosCheckerTest.java 570a50b
> ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/JvmMetricsSourceTest.java a6aa5d5
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilterTest.java 7e36128
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 9d4fb3e
> ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java 60643b3
>
> Diff: https://reviews.apache.org/r/55193/diff/
>
>
> Testing
> -------
>
> Ran unit tests with Oracle JDK 1.7 and Oracle JDK 1.8.
> Manually tested Ambari
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 55193: Executing ambari-server unit tests with JDK
1.8 results in unit test failures
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55193/#review160594
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 4, 2017, 8:50 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55193/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 8:50 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Jaimin Jetly, Jonathan Hurley, Laszlo Puskas, and Nate Cole.
>
>
> Bugs: AMBARI-19365
> https://issues.apache.org/jira/browse/AMBARI-19365
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Following unit tests fails when executed with JDK 1.8
> ```
> mvn test -Dtest=DataStoreImplTest
> mvn clean test -Dtest=UpgradeCatalog222Test
> mvn test -Dtest=KerberosCheckerTest,AmbariBasicAuthenticationFilterTest
> ```
> Same unit tests passes if the environment is switched to use JDK 1.7
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java e0a3d55
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/LoginContextHelper.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosCheckerTest.java 570a50b
> ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/JvmMetricsSourceTest.java a6aa5d5
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilterTest.java 7e36128
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 9d4fb3e
> ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java 60643b3
>
> Diff: https://reviews.apache.org/r/55193/diff/
>
>
> Testing
> -------
>
> Ran unit tests with Oracle JDK 1.7 and Oracle JDK 1.8.
> Manually tested Ambari
>
>
> Thanks,
>
> Robert Levas
>
>