You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "James Mitchell (JIRA)" <ji...@codehaus.org> on 2006/04/29 19:39:19 UTC
[jira] Created: (MPECLIPSE-117) Add the ability to specify source
exclusions
Add the ability to specify source exclusions
--------------------------------------------
Key: MPECLIPSE-117
URL: http://jira.codehaus.org/browse/MPECLIPSE-117
Project: maven-eclipse-plugin
Type: New Feature
Reporter: James Mitchell
Priority: Minor
Attachments: srcExclusions-patch.zip
When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
Thanks so much for your attention.
--
James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-104) Add the ability to specify source
inclusions/exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Barrie Treloar updated MECLIPSE-104:
------------------------------------
Fix Version/s: (was: 2.7)
2.6.1
> Add the ability to specify source inclusions/exclusions
> -------------------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Barrie Treloar
> Priority: Minor
> Fix For: 2.6.1
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-104) Add the ability to specify source
inclusions/exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Barrie Treloar updated MECLIPSE-104:
------------------------------------
Summary: Add the ability to specify source inclusions/exclusions (was: Add the ability to specify source exclusions)
> Add the ability to specify source inclusions/exclusions
> -------------------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Barrie Treloar
> Priority: Minor
> Fix For: 2.7
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MECLIPSE-104) Add the ability to
specify source exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158104#action_158104 ]
Barrie Treloar edited comment on MECLIPSE-104 at 12/16/08 12:19 AM:
--------------------------------------------------------------------
Can you try the latest snapshot please?
-Source exclusions can be specified with the excludes tag in the configuration section for the eclipse plugin.-
*Correction* source exclusions are still not possible EclipsePlugin.extractSourceDirs() does not pass through any values for includes/excludes.
Resource exclusions are specified via normal pom syntax for resources.
However the default behavior of the classpath writer is to specify an includes of **/*.java for source directories and therefore your .svn and CVS directories will never match this.
I would need to know more details about the problem you are facing, but I think the current behavior should be acceptable and we can mark this as already fixed.
was (Author: baerrach):
Can you try the latest snapshot please?
Source exclusions can be specified with the excludes tag in the configuration section for the eclipse plugin.
Resource exclusions are specified via normal pom syntax for resources.
However the default behavior of the classpath writer is to specify an includes of **/*.java for source directories and therefore your .svn and CVS directories will never match this.
I would need to know more details about the problem you are facing, but I think the current behavior should be acceptable and we can mark this as already fixed.
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Arnaud Heritier
> Priority: Minor
> Fix For: 2.6
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier updated MECLIPSE-104:
-------------------------------------
Assignee: Arnaud Heritier
Fix Version/s: 2.5.2
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Arnaud Heritier
> Priority: Minor
> Fix For: 2.5.2
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Richard van der Hoff (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=171089#action_171089 ]
Richard van der Hoff commented on MECLIPSE-104:
-----------------------------------------------
Yes - just before patching the proposed 2.6 to fix the problem and uploading the patch here.
As I mentioned before, I need to exclude some .java files from my build; including only "**/*.java" is therefore insufficient to resolve the issue.
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Arnaud Heritier
> Priority: Minor
> Fix For: 2.7
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Barrie Treloar updated MECLIPSE-104:
------------------------------------
Fix Version/s: (was: 2.6)
2.7
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Arnaud Heritier
> Priority: Minor
> Fix For: 2.7
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Richard van der Hoff (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=171004#action_171004 ]
Richard van der Hoff commented on MECLIPSE-104:
-----------------------------------------------
The problem I am facing is that some of the .java files in my source tree won't build against the dependency versions maven chooses for me.
Unfortunately fixing this isn't an option. It would require moving lots of stuff around in CVS which I really don't have time for.
The compiler plugin allows me to exclude classes with the <excludes> tag. It therefore seems to make sense for the eclipse plugin to do so as well.
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Arnaud Heritier
> Priority: Minor
> Fix For: 2.7
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "James Mitchell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=comments#action_80843 ]
James Mitchell commented on MECLIPSE-104:
-----------------------------------------
The patch I provided is probably useless at this point, there's been so much refactoring since I did this.
Oh well, can't say I didn't try.
BTW -- Thanks for the script!
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Priority: Minor
> Attachments: fix-eclipse-classpaths.sh, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MECLIPSE-104) Add the ability to specify source
inclusions/exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Barrie Treloar closed MECLIPSE-104.
-----------------------------------
Resolution: Fixed
Site documentation added
> Add the ability to specify source inclusions/exclusions
> -------------------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Barrie Treloar
> Priority: Minor
> Fix For: 2.6.1
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=171008#action_171008 ]
Barrie Treloar commented on MECLIPSE-104:
-----------------------------------------
Have you tried 2.6-SNAPSHOT, or the proposed release 2.6?
[MECLIPSE-443] has added includes ="**\*.java" to the classpath entry - which will do a similar thing, i.e constrain the source folder to only use .java files.
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Arnaud Heritier
> Priority: Minor
> Fix For: 2.7
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Cameron Fieber (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=all ]
Cameron Fieber updated MECLIPSE-104:
------------------------------------
Attachment: fix-eclipse-classpaths.sh
I wouldn't mind seeing this one fixed if it's easy.
In the meantime I'm attaching a simple shell script I use to add the exclusion for the .svn directory to the generated .classpath files. It should be easy enough to modify if you use CVS
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Priority: Minor
> Attachments: fix-eclipse-classpaths.sh, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Cameron Fieber (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_87759 ]
Cameron Fieber commented on MECLIPSE-104:
-----------------------------------------
Two things:
1) the script I provided will bork your .classpath files by adding an extra excluding= attribute on the classpathentry elements for resource directories. I could fix that but..
2) Under Window/Preferences... Java>Compiler>Building there is an Output folder expandable section. Under there there is an entry for Filtered resources. Just add the appropriate filter for your SCM.
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Priority: Minor
> Attachments: fix-eclipse-classpaths.sh, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-104) Add the ability to specify source
inclusions/exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=171358#action_171358 ]
Barrie Treloar commented on MECLIPSE-104:
-----------------------------------------
Committed to trunk for 2.6.1
The configuration for EclipsePlugin now accepts
<sourceInclusions>
<sourceInclusion>XXX</sourceInclusion>
<sourceInclusions>
(same for sourceExclusions)
to modifiy the classpath entries for source directories.
**/*.java is always added if it is a java (or pde) project
**/*.aj is always added if it is an ajdt project.
> Add the ability to specify source inclusions/exclusions
> -------------------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Barrie Treloar
> Priority: Minor
> Fix For: 2.7
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Richard van der Hoff (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard van der Hoff updated MECLIPSE-104:
------------------------------------------
Attachment: MECLIPSE-104.patch
An updated version of the patch.
It's pretty trivial, so it would be nice if it could be applied before it bitrots this time! :)
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Priority: Minor
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MECLIPSE-104) Add the ability to specify
source exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MECLIPSE-104 started by Barrie Treloar.
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Barrie Treloar
> Priority: Minor
> Fix For: 2.7
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158104#action_158104 ]
Barrie Treloar commented on MECLIPSE-104:
-----------------------------------------
Can you try the latest snapshot please?
Source exclusions can be specified with the excludes tag in the configuration section for the eclipse plugin.
Resource exclusions are specified via normal pom syntax for resources.
However the default behavior of the classpath writer is to specify an includes of **/*.java for source directories and therefore your .svn and CVS directories will never match this.
I would need to know more details about the problem you are facing, but I think the current behavior should be acceptable and we can mark this as already fixed.
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Arnaud Heritier
> Priority: Minor
> Fix For: 2.6
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-104) Add the ability to specify source
exclusions
Posted by "Richard van der Hoff (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard van der Hoff updated MECLIPSE-104:
------------------------------------------
Attachment: MECLIPSE-104.patch
Here is yet another version of this patch, updated to trunk as of 2009-03-26.
> Add the ability to specify source exclusions
> --------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Arnaud Heritier
> Priority: Minor
> Fix For: 2.7
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-104) Add the ability to specify source
inclusions/exclusions
Posted by "Barrie Treloar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=171359#action_171359 ]
Barrie Treloar commented on MECLIPSE-104:
-----------------------------------------
Still need to add documentation before I close this.
> Add the ability to specify source inclusions/exclusions
> -------------------------------------------------------
>
> Key: MECLIPSE-104
> URL: http://jira.codehaus.org/browse/MECLIPSE-104
> Project: Maven 2.x Eclipse Plugin
> Issue Type: New Feature
> Reporter: James Mitchell
> Assignee: Barrie Treloar
> Priority: Minor
> Fix For: 2.6.1
>
> Attachments: fix-eclipse-classpaths.sh, MECLIPSE-104.patch, MECLIPSE-104.patch, srcExclusions-patch.zip
>
>
> When source files contain scm information (**/.svn/** or **/CVS/**), which is pretty much a given, there's currently no way to specify that those directories be excluded except through the GUI. This isn't so much of a problem except that the next time a change is needed and this plugin is ran, it will overwrite this exclusion and will force me to exclude it, by hand, again.
> The above case is the driving reason why I decided to get involved and help out. So, I have written everything (I think) that is needed for this enhancement including, adding to the javadoc, creating a new test that verifies this enhancement, and fully testing this with my own projects (many of them @ Struts). If there is anything else I need to do as far as site documentation, please tell me where it is and I'll add it.
> This is my first patch to Maven. If this sucks, please don't ignore it, just say 'it sucks, no thanks" and I'll go about working on something else.
> Thanks so much for your attention.
> --
> James Mitchell
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira