You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Navis (Created) (JIRA)" <ji...@apache.org> on 2012/02/27 09:01:38 UTC
[jira] [Created] (HIVE-2827) Implement nullsafe equi-join
Implement nullsafe equi-join
----------------------------
Key: HIVE-2827
URL: https://issues.apache.org/jira/browse/HIVE-2827
Project: Hive
Issue Type: Improvement
Components: Query Processor
Environment: ubuntu 10.04
Reporter: Navis
Assignee: Navis
Priority: Minor
was part of HIVE-2810, but separated because it affected more classes than expected.
{noformat}
SELECT * FROM a JOIN b ON a.key <=> b.key
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2827) Implement nullsafe equi-join
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224439#comment-13224439 ]
Hudson commented on HIVE-2827:
------------------------------
Integrated in Hive-trunk-h0.21 #1295 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1295/])
HIVE-2827 [jira] Implement nullsafe equi-join
(Navis Ryu via Carl Steinbach)
Summary:
DPAL-873 Implement nullsafe equi-join
was part of HIVE-2810, but separated because it affected more classes than
expected.
SELECT * FROM a JOIN b ON a.key <=> b.key
Test Plan: EMPTY
Reviewers: JIRA, cwsteinbach
Reviewed By: cwsteinbach
Differential Revision: https://reviews.facebook.net/D1971 (Revision 1297919)
Result = SUCCESS
cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1297919
Files :
* /hive/trunk/data/files/in8.txt
* /hive/trunk/data/files/in9.txt
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
* /hive/trunk/ql/src/test/queries/clientpositive/join_nullsafe.q
* /hive/trunk/ql/src/test/results/clientpositive/join_nullsafe.q.out
* /hive/trunk/ql/src/test/results/compiler/plan/join1.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/join2.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/join3.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/join4.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/join5.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/join6.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/join7.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/join8.q.xml
* /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch, HIVE-2827.D1971.5.patch, HIVE-2827.D1971.6.patch, HIVE-2827.D1971.7.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2827:
------------------------------
Attachment: HIVE-2827.D1971.5.patch
navis updated the revision "HIVE-2827 [jira] Implement nullsafe equi-join".
Reviewers: JIRA, cwsteinbach
1. Removed disabling option
2. Fixed path in testcase appropriately (not my local fs)
I've tried '${system:test.src.data.dir}/files/~~' instead of '../data/files/~~' but it logs (my) local fs dirs into test result which seemed to make test failures.
If '${system:test.src.data.dir}' is to be used for data loading, test utils and all the test results should be fixed all together, which seemed to be a separated issue.
REVISION DETAIL
https://reviews.facebook.net/D1971
AFFECTED FILES
data/files/in8.txt
data/files/in9.txt
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
ql/src/test/queries/clientpositive/join_nullsafe.q
ql/src/test/results/clientpositive/join_nullsafe.q.out
ql/src/test/results/compiler/plan/join1.q.xml
ql/src/test/results/compiler/plan/join2.q.xml
ql/src/test/results/compiler/plan/join3.q.xml
ql/src/test/results/compiler/plan/join4.q.xml
ql/src/test/results/compiler/plan/join5.q.xml
ql/src/test/results/compiler/plan/join6.q.xml
ql/src/test/results/compiler/plan/join7.q.xml
ql/src/test/results/compiler/plan/join8.q.xml
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch, HIVE-2827.D1971.5.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Navis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Navis updated HIVE-2827:
------------------------
Status: Patch Available (was: Open)
Passed all tests.
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2827:
------------------------------
Attachment: HIVE-2827.D1971.3.patch
navis updated the revision "HIVE-2827 [jira] Implement nullsafe equi-join".
Reviewers: JIRA
Fix test failures (uniquejoin.q, etc.)
REVISION DETAIL
https://reviews.facebook.net/D1971
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
data/files/in8.txt
data/files/in9.txt
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
ql/src/test/queries/clientpositive/join_nullsafe.q
ql/src/test/results/clientpositive/join_nullsafe.q.out
ql/src/test/results/compiler/plan/join1.q.xml
ql/src/test/results/compiler/plan/join2.q.xml
ql/src/test/results/compiler/plan/join3.q.xml
ql/src/test/results/compiler/plan/join4.q.xml
ql/src/test/results/compiler/plan/join5.q.xml
ql/src/test/results/compiler/plan/join6.q.xml
ql/src/test/results/compiler/plan/join7.q.xml
ql/src/test/results/compiler/plan/join8.q.xml
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Navis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Navis updated HIVE-2827:
------------------------
Fix Version/s: 0.9.0
Status: Patch Available (was: Open)
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch, HIVE-2827.D1971.5.patch, HIVE-2827.D1971.6.patch, HIVE-2827.D1971.7.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Carl Steinbach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2827:
---------------------------------
Status: Open (was: Patch Available)
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223627#comment-13223627 ]
Phabricator commented on HIVE-2827:
-----------------------------------
cwsteinbach has accepted the revision "HIVE-2827 [jira] Implement nullsafe equi-join".
Will commit if tests pass.
REVISION DETAIL
https://reviews.facebook.net/D1971
BRANCH
DPAL-873
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch, HIVE-2827.D1971.5.patch, HIVE-2827.D1971.6.patch, HIVE-2827.D1971.7.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220546#comment-13220546 ]
Phabricator commented on HIVE-2827:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2827 [jira] Implement nullsafe equi-join".
Looks good overall. I will test and commit once the requested changes have been applied. Thanks.
INLINE COMMENTS
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:412 I wanted to see this included in HIVE-2810 since it sounded like it would take some time to implement the fix for JOINs, and in the meantime I didn't want people to accidentally use <=> in JOINs. However, since this patch implements correct JOIN handling for <=>, I don't think it makes sense to provide the option of disabling this. Please remove.
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java:50 Spelling: s/jon/join/
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:1339 Please remove.
ql/src/test/queries/clientpositive/join_nullsafe.q:4 please reference the path using the appropriate test system property, e.g. "${system:test.src.data.dir}/files/in8.txt"
REVISION DETAIL
https://reviews.facebook.net/D1971
BRANCH
DPAL-873
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2827:
------------------------------
Attachment: HIVE-2827.D1971.1.patch
navis requested code review of "HIVE-2827 [jira] Implement nullsafe equi-join".
Reviewers: JIRA
DPAL-873 Implement nullsafe equi-join
was part of HIVE-2810, but separated because it affected more classes than expected.
SELECT * FROM a JOIN b ON a.key <=> b.key
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1971
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
data/files/in8.txt
data/files/in9.txt
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ConditionalTask.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
ql/src/test/queries/clientpositive/join_nullsafe.q
ql/src/test/results/clientpositive/join_nullsafe.q.out
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4185/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Carl Steinbach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2827:
---------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Navis!
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch, HIVE-2827.D1971.5.patch, HIVE-2827.D1971.6.patch, HIVE-2827.D1971.7.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2827:
------------------------------
Attachment: HIVE-2827.D1971.7.patch
navis updated the revision "HIVE-2827 [jira] Implement nullsafe equi-join".
Reviewers: JIRA, cwsteinbach
Removed not-used error message
REVISION DETAIL
https://reviews.facebook.net/D1971
AFFECTED FILES
data/files/in8.txt
data/files/in9.txt
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
ql/src/test/queries/clientpositive/join_nullsafe.q
ql/src/test/results/clientpositive/join_nullsafe.q.out
ql/src/test/results/compiler/plan/join1.q.xml
ql/src/test/results/compiler/plan/join2.q.xml
ql/src/test/results/compiler/plan/join3.q.xml
ql/src/test/results/compiler/plan/join4.q.xml
ql/src/test/results/compiler/plan/join5.q.xml
ql/src/test/results/compiler/plan/join6.q.xml
ql/src/test/results/compiler/plan/join7.q.xml
ql/src/test/results/compiler/plan/join8.q.xml
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch, HIVE-2827.D1971.5.patch, HIVE-2827.D1971.6.patch, HIVE-2827.D1971.7.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224193#comment-13224193 ]
Phabricator commented on HIVE-2827:
-----------------------------------
navis has committed the revision "HIVE-2827 [jira] Implement nullsafe equi-join".
Change committed by cws.
REVISION DETAIL
https://reviews.facebook.net/D1971
COMMIT
https://reviews.facebook.net/rHIVE1297919
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch, HIVE-2827.D1971.5.patch, HIVE-2827.D1971.6.patch, HIVE-2827.D1971.7.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2827:
------------------------------
Attachment: HIVE-2827.D1971.2.patch
navis updated the revision "HIVE-2827 [jira] Implement nullsafe equi-join".
Reviewers: JIRA
Removed debugging message
REVISION DETAIL
https://reviews.facebook.net/D1971
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
data/files/in8.txt
data/files/in9.txt
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
ql/src/test/queries/clientpositive/join_nullsafe.q
ql/src/test/results/clientpositive/join_nullsafe.q.out
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2827:
------------------------------
Attachment: HIVE-2827.D1971.4.patch
navis updated the revision "HIVE-2827 [jira] Implement nullsafe equi-join".
Reviewers: JIRA
Rebased on HIVE-2810
REVISION DETAIL
https://reviews.facebook.net/D1971
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
data/files/in8.txt
data/files/in9.txt
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
ql/src/test/queries/clientpositive/join_nullsafe.q
ql/src/test/results/clientpositive/join_nullsafe.q.out
ql/src/test/results/compiler/plan/join1.q.xml
ql/src/test/results/compiler/plan/join2.q.xml
ql/src/test/results/compiler/plan/join3.q.xml
ql/src/test/results/compiler/plan/join4.q.xml
ql/src/test/results/compiler/plan/join5.q.xml
ql/src/test/results/compiler/plan/join6.q.xml
ql/src/test/results/compiler/plan/join7.q.xml
ql/src/test/results/compiler/plan/join8.q.xml
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2827) Implement nullsafe equi-join
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2827:
------------------------------
Attachment: HIVE-2827.D1971.6.patch
navis updated the revision "HIVE-2827 [jira] Implement nullsafe equi-join".
Reviewers: JIRA, cwsteinbach
rebased on HIVE-2810
REVISION DETAIL
https://reviews.facebook.net/D1971
AFFECTED FILES
data/files/in8.txt
data/files/in9.txt
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
ql/src/test/queries/clientpositive/join_nullsafe.q
ql/src/test/results/clientpositive/join_nullsafe.q.out
ql/src/test/results/compiler/plan/join1.q.xml
ql/src/test/results/compiler/plan/join2.q.xml
ql/src/test/results/compiler/plan/join3.q.xml
ql/src/test/results/compiler/plan/join4.q.xml
ql/src/test/results/compiler/plan/join5.q.xml
ql/src/test/results/compiler/plan/join6.q.xml
ql/src/test/results/compiler/plan/join7.q.xml
ql/src/test/results/compiler/plan/join8.q.xml
serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch, HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch, HIVE-2827.D1971.5.patch, HIVE-2827.D1971.6.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira