You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2020/05/28 17:32:23 UTC
[pulsar] branch master updated: C++ tests should use sensible
timeouts for receive (#7071)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new b7a4fef C++ tests should use sensible timeouts for receive (#7071)
b7a4fef is described below
commit b7a4fef3e69a44e47213f016f3ade723d19d0d0c
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Thu May 28 10:32:11 2020 -0700
C++ tests should use sensible timeouts for receive (#7071)
### Motivation
A bunch of tests were using 100ms as the timeout for receive. 100ms is
way too short. The broker for these tests is standalone, so everything
is running in one process on one machine. I/O, locks, GC etc can
easily make reads take longer than 100ms.
We are testing functionality, not performance with these tests, so
I've increased the timeout to 3s.
---
pulsar-client-cpp/tests/BasicEndToEndTest.cc | 12 ++++++------
pulsar-client-cpp/tests/ConsumerTest.cc | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/pulsar-client-cpp/tests/BasicEndToEndTest.cc b/pulsar-client-cpp/tests/BasicEndToEndTest.cc
index e50b67b..e6ad0c3 100644
--- a/pulsar-client-cpp/tests/BasicEndToEndTest.cc
+++ b/pulsar-client-cpp/tests/BasicEndToEndTest.cc
@@ -1536,7 +1536,7 @@ TEST(BasicEndToEndTest, testSeek) {
LOG_INFO("Trying to receive 100 messages");
Message msgReceived;
for (msgNum = 0; msgNum < 100; msgNum++) {
- consumer.receive(msgReceived, 100);
+ consumer.receive(msgReceived, 3000);
LOG_DEBUG("Received message :" << msgReceived.getMessageId());
std::stringstream expected;
expected << msgContent << msgNum;
@@ -1550,7 +1550,7 @@ TEST(BasicEndToEndTest, testSeek) {
std::this_thread::sleep_for(std::chrono::microseconds(500 * 1000));
ASSERT_EQ(ResultOk, result);
- consumer.receive(msgReceived, 100);
+ consumer.receive(msgReceived, 3000);
LOG_ERROR("Received message :" << msgReceived.getMessageId());
std::stringstream expected;
msgNum = 0;
@@ -3123,11 +3123,11 @@ TEST(BasicEndToEndTest, testPartitionedTopicWithOnePartition) {
LOG_INFO("begin to receive message " << i);
Message msg;
- Result res = consumer1.receive(msg, 100);
+ Result res = consumer1.receive(msg, 3000);
ASSERT_EQ(ResultOk, res);
consumer1.acknowledge(msg);
- res = consumer2.receive(msg, 100);
+ res = consumer2.receive(msg, 3000);
ASSERT_EQ(ResultOk, res);
consumer2.acknowledge(msg);
}
@@ -3206,7 +3206,7 @@ TEST(BasicEndToEndTest, testCumulativeAcknowledgeNotAllowed) {
// test cannot use acknowledgeCumulative on Shared subscription
for (int i = 0; i < numMessages; i++) {
Message msg;
- Result res = consumer1.receive(msg, 100);
+ Result res = consumer1.receive(msg, 3000);
ASSERT_EQ(ResultOk, res);
if (i == 9) {
res = consumer1.acknowledgeCumulative(msg);
@@ -3217,7 +3217,7 @@ TEST(BasicEndToEndTest, testCumulativeAcknowledgeNotAllowed) {
// test cannot use acknowledgeCumulative on Key_Shared subscription
for (int i = 0; i < numMessages; i++) {
Message msg;
- Result res = consumer2.receive(msg, 100);
+ Result res = consumer2.receive(msg, 3000);
ASSERT_EQ(ResultOk, res);
if (i == 9) {
res = consumer2.acknowledgeCumulative(msg);
diff --git a/pulsar-client-cpp/tests/ConsumerTest.cc b/pulsar-client-cpp/tests/ConsumerTest.cc
index af9c577..f2cf18a 100644
--- a/pulsar-client-cpp/tests/ConsumerTest.cc
+++ b/pulsar-client-cpp/tests/ConsumerTest.cc
@@ -32,7 +32,7 @@ TEST(ConsumerTest, consumerNotInitialized) {
Message msg;
ASSERT_EQ(ResultConsumerNotInitialized, consumer.receive(msg));
- ASSERT_EQ(ResultConsumerNotInitialized, consumer.receive(msg, 100));
+ ASSERT_EQ(ResultConsumerNotInitialized, consumer.receive(msg, 3000));
ASSERT_EQ(ResultConsumerNotInitialized, consumer.acknowledge(msg));