You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/06/23 13:59:03 UTC
[commons-jxpath] 01/02: JDOMNodePointer.compareChildNodePointers(NodePointer, NodePointer) now throws IllegalStateException instead of RuntimeException.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jxpath.git
commit 9ac612e7d96908ee5c0dc63eeaba411f3165bb37
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Jun 23 09:50:23 2023 -0400
JDOMNodePointer.compareChildNodePointers(NodePointer, NodePointer) now
throws IllegalStateException instead of RuntimeException.
---
src/changes/changes.xml | 3 +++
.../org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java | 5 +----
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 7c285ed..d582b7c 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -86,6 +86,9 @@ The <action> type attribute can be add,update,fix,remove.
<action dev="ggregory" type="fix">
Fix possible NPE in PackageFunctions.getFunction(String, String, Object[]).
</action>
+ <action dev="ggregory" type="fix" due-to="Gary Gregory">
+ JDOMNodePointer.compareChildNodePointers() now throws IllegalStateException instead of RuntimeException.
+ </action>
<!-- ADD -->
<action issue="JXPATH-123" dev="mbenson" type="add">
XPath function "ends-with" is not implemented (although "starts-with" is).
diff --git a/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java b/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java
index f04dca0..f3b5324 100644
--- a/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java
+++ b/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java
@@ -198,10 +198,7 @@ public class JDOMNodePointer extends NodePointer {
}
if (!(node instanceof Element)) {
- throw new RuntimeException(
- "JXPath internal error: "
- + "compareChildNodes called for "
- + node);
+ throw new IllegalStateException("JXPath internal error: " + "compareChildNodes called for " + node);
}
final List children = ((Element) node).getContent();