You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/10/24 23:48:34 UTC
Review Request 27168: Externalize all hard-coded config properties
from Timeline service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27168/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
Bugs: AMBARI-7965
https://issues.apache.org/jira/browse/AMBARI-7965
Repository: ambari
Description
-------
- All TTLs, aggregators configurations should be in the timeline service's site.xml
- This task is a followup of getting rid of Yarn dependent classes.
- Add AMS service skeleton to the stack
Diffs
-----
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/conf/YarnConfig.java fe5a553
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractTimelineAggregator.java 2630846
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java bc1fcf5
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 19f41b5
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java f74c4a9
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricAggregatorHourly.java 6418322
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricAggregatorMinute.java 8661821
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregator.java fe2f791
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregatorHourly.java 1caf809
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java PRE-CREATION
ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/util/timeline/TimelineUtilsExt.java 31e8017
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-hbase-env.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-hbase-log4j.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-hbase-policy.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-hbase-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/files/hbaseSmokeVerify.sh PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/__init__.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/hbase.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/hbase_master.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/hbase_regionserver.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/hbase_service.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/hbase_client_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/hbase_grant_permissions.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/hbase_master_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/hbase_regionserver_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/regionservers.j2 PRE-CREATION
Diff: https://reviews.apache.org/r/27168/diff/
Testing
-------
Thanks,
Sid Wagle
Re: Review Request 27168: Externalize all hard-coded config
properties from Timeline service
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27168/#review58623
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Жов. 25, 2014, 12:48 до полудня, Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27168/
> -----------------------------------------------------------
>
> (Updated Жов. 25, 2014, 12:48 до полудня)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
>
>
> Bugs: AMBARI-7965
> https://issues.apache.org/jira/browse/AMBARI-7965
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - All TTLs, aggregators configurations should be in the timeline service's site.xml
> - This task is a followup of getting rid of Yarn dependent classes.
> - Add AMS service skeleton to the stack
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/conf/YarnConfig.java fe5a553
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractTimelineAggregator.java 2630846
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java bc1fcf5
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 19f41b5
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java f74c4a9
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricAggregatorHourly.java 6418322
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricAggregatorMinute.java 8661821
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregator.java fe2f791
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregatorHourly.java 1caf809
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java PRE-CREATION
> ambari-metrics/ambari-metrics-hadoop-timelineservice/src/main/java/org/apache/hadoop/yarn/util/timeline/TimelineUtilsExt.java 31e8017
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-hbase-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-hbase-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-hbase-policy.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-hbase-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/configuration/ams-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/files/hbaseSmokeVerify.sh PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/__init__.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/hbase.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/hbase_master.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/hbase_regionserver.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/hbase_service.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/hbase_client_jaas.conf.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/hbase_grant_permissions.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/hbase_master_jaas.conf.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/hbase_regionserver_jaas.conf.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/package/templates/regionservers.j2 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27168/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sid Wagle
>
>