You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2013/03/19 23:37:47 UTC

Review Request: FLUME-1955: fileSuffix does not work with compressed streams

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10031/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Minor patch to make fileSuffix work with compressed streams.


This addresses bug FLUME-1955.
    https://issues.apache.org/jira/browse/FLUME-1955


Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 774f297 
  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 741ac90 
  flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java 99e787e 

Diff: https://reviews.apache.org/r/10031/diff/


Testing
-------

Added unit test, some manual testing.


Thanks,

Mike Percy


Re: Review Request: FLUME-1955: fileSuffix does not work with compressed streams

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10031/#review18112
-----------------------------------------------------------

Ship it!


Ship It!

- Hari Shreedharan


On March 19, 2013, 10:37 p.m., Mike Percy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10031/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 10:37 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Minor patch to make fileSuffix work with compressed streams.
> 
> 
> This addresses bug FLUME-1955.
>     https://issues.apache.org/jira/browse/FLUME-1955
> 
> 
> Diffs
> -----
> 
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 774f297 
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 741ac90 
>   flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java 99e787e 
> 
> Diff: https://reviews.apache.org/r/10031/diff/
> 
> 
> Testing
> -------
> 
> Added unit test, some manual testing.
> 
> 
> Thanks,
> 
> Mike Percy
> 
>