You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dogukancagatay (via GitHub)" <gi...@apache.org> on 2025/09/12 07:54:54 UTC
[PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
dogukancagatay opened a new pull request, #14059:
URL: https://github.com/apache/iceberg/pull/14059
This pull request removes deprecated code and functionality scheduled for removal in the 1.11.0 release.
Contributes to #13054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "dogukancagatay (via GitHub)" <gi...@apache.org>.
dogukancagatay commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2356447975
##########
build.gradle:
##########
@@ -136,7 +136,7 @@ subprojects {
revapi {
oldGroup = project.group
oldName = project.name
- oldVersion = "1.9.0"
+ oldVersion = "1.10.0"
Review Comment:
Rebased main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "dogukancagatay (via GitHub)" <gi...@apache.org>.
dogukancagatay commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2349649230
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -186,7 +185,12 @@ private static OAuthTokenResponse refreshToken(
}
return fetchToken(
- client, Map.of(), config.credential(), config.scope(), config.oauth2ServerUri());
+ client,
+ Map.of(),
+ config.credential(),
+ config.scope(),
+ config.oauth2ServerUri(),
+ optionalOAuthParams);
Review Comment:
Reverted the behavior change. I will open another PR for the behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "dogukancagatay (via GitHub)" <gi...@apache.org>.
dogukancagatay commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2356444544
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -122,7 +122,7 @@ public S3FileIO() {}
* @param s3 s3 supplier
*/
public S3FileIO(SerializableSupplier<S3Client> s3) {
- this(s3, null, new S3FileIOProperties());
+ this.s3 = s3;
Review Comment:
Fixed the constructors. However, I am wondering why no test failed, we must be missing some coverage, or the values are redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2354798259
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -134,45 +134,8 @@ public S3FileIO(SerializableSupplier<S3Client> s3) {
* @param s3Async s3Async supplier
*/
public S3FileIO(SerializableSupplier<S3Client> s3, SerializableSupplier<S3AsyncClient> s3Async) {
- this(s3, s3Async, new S3FileIOProperties());
- }
-
- /**
- * Constructor with custom s3 supplier and S3FileIO properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier)} with {@link S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(SerializableSupplier<S3Client> s3, S3FileIOProperties s3FileIOProperties) {
- this(s3, null, s3FileIOProperties);
- }
-
- /**
- * Constructor with custom s3 supplier, s3Async supplier and S3FileIO properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3Async s3Async supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier, SerializableSupplier)} with {@link
- * S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(
- SerializableSupplier<S3Client> s3,
- SerializableSupplier<S3AsyncClient> s3Async,
- S3FileIOProperties s3FileIOProperties) {
this.s3 = s3;
this.s3Async = s3Async;
- this.createStack = Thread.currentThread().getStackTrace();
- this.properties = SerializableMap.copyOf(s3FileIOProperties.properties());
Review Comment:
we want to get rid of the `S3FileIOProperties` usage in the constructors, so we should change this to `this.properties = SerializableMap.copyOf(Maps.newHashMap())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #14059:
URL: https://github.com/apache/iceberg/pull/14059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2354787003
##########
build.gradle:
##########
@@ -136,7 +136,7 @@ subprojects {
revapi {
oldGroup = project.group
oldName = project.name
- oldVersion = "1.9.0"
+ oldVersion = "1.10.0"
Review Comment:
can you please rebase the PR as this change should already be on main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2353303951
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -134,45 +134,8 @@ public S3FileIO(SerializableSupplier<S3Client> s3) {
* @param s3Async s3Async supplier
*/
public S3FileIO(SerializableSupplier<S3Client> s3, SerializableSupplier<S3AsyncClient> s3Async) {
- this(s3, s3Async, new S3FileIOProperties());
- }
-
- /**
- * Constructor with custom s3 supplier and S3FileIO properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier)} with {@link S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(SerializableSupplier<S3Client> s3, S3FileIOProperties s3FileIOProperties) {
- this(s3, null, s3FileIOProperties);
- }
-
- /**
- * Constructor with custom s3 supplier, s3Async supplier and S3FileIO properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3Async s3Async supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier, SerializableSupplier)} with {@link
- * S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(
- SerializableSupplier<S3Client> s3,
- SerializableSupplier<S3AsyncClient> s3Async,
- S3FileIOProperties s3FileIOProperties) {
this.s3 = s3;
this.s3Async = s3Async;
- this.createStack = Thread.currentThread().getStackTrace();
- this.properties = SerializableMap.copyOf(s3FileIOProperties.properties());
Review Comment:
I think we still need these two lines in order to keep the same behavior as before. The second will be
```
this.properties = SerializableMap.copyOf(new S3FileIOProperties().properties());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2353334789
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -122,7 +122,7 @@ public S3FileIO() {}
* @param s3 s3 supplier
*/
public S3FileIO(SerializableSupplier<S3Client> s3) {
- this(s3, null, new S3FileIOProperties());
+ this.s3 = s3;
Review Comment:
same as the 2 arg constructor, to keep the same behavior as before, we still need
```
this.createStack = Thread.currentThread().getStackTrace();
this.properties = SerializableMap.copyOf(new S3FileIOProperties().properties());
```
After fixing the 2 arg constructor, call the 2 arg constructor
```
this(s3, /* s3Async = */ null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2350424814
##########
.palantir/revapi.yml:
##########
@@ -404,6 +404,63 @@ acceptedBreaks:
old: "method org.apache.iceberg.orc.ORC.WriteBuilder org.apache.iceberg.orc.ORC.WriteBuilder::config(java.lang.String,\
\ java.lang.String)"
justification: "Removing deprecations for 1.2.0"
+ "1.10.0":
Review Comment:
nit: Should this be placed after `"1.9.0"` so the sequence is `"1.0.0"`, `"1.1.0"`, `"1.2.0"`, `"1.3.0"` …, `"1.10.0"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2358514715
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -122,7 +122,7 @@ public S3FileIO() {}
* @param s3 s3 supplier
*/
public S3FileIO(SerializableSupplier<S3Client> s3) {
- this(s3, null, new S3FileIOProperties());
+ this(s3, /* s3Async= */ null);
Review Comment:
```suggestion
this(s3, null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2347486598
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -186,7 +185,12 @@ private static OAuthTokenResponse refreshToken(
}
return fetchToken(
- client, Map.of(), config.credential(), config.scope(), config.oauth2ServerUri());
+ client,
+ Map.of(),
+ config.credential(),
+ config.scope(),
+ config.oauth2ServerUri(),
+ optionalOAuthParams);
Review Comment:
Do we need a test for this functional improvement?
Could we split this PR into 1) deprecation removal only 2) the behavior change with a test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "dogukancagatay (via GitHub)" <gi...@apache.org>.
dogukancagatay commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2356449364
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -134,45 +134,8 @@ public S3FileIO(SerializableSupplier<S3Client> s3) {
* @param s3Async s3Async supplier
*/
public S3FileIO(SerializableSupplier<S3Client> s3, SerializableSupplier<S3AsyncClient> s3Async) {
- this(s3, s3Async, new S3FileIOProperties());
- }
-
- /**
- * Constructor with custom s3 supplier and S3FileIO properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier)} with {@link S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(SerializableSupplier<S3Client> s3, S3FileIOProperties s3FileIOProperties) {
- this(s3, null, s3FileIOProperties);
- }
-
- /**
- * Constructor with custom s3 supplier, s3Async supplier and S3FileIO properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3Async s3Async supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier, SerializableSupplier)} with {@link
- * S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(
- SerializableSupplier<S3Client> s3,
- SerializableSupplier<S3AsyncClient> s3Async,
- S3FileIOProperties s3FileIOProperties) {
this.s3 = s3;
this.s3Async = s3Async;
- this.createStack = Thread.currentThread().getStackTrace();
- this.properties = SerializableMap.copyOf(s3FileIOProperties.properties());
Review Comment:
Sure, replaced S3FileIOProperties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#issuecomment-3348033583
hi @dogukancagatay
we're gathering feedback on removing spark 3.4 in the upcoming 1.11 release.
could you chime in on the [slack thread](https://apache-iceberg.slack.com/archives/C03LG1D563F/p1759163920874249)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2346921903
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -186,7 +185,12 @@ private static OAuthTokenResponse refreshToken(
}
return fetchToken(
- client, Map.of(), config.credential(), config.scope(), config.oauth2ServerUri());
+ client,
+ Map.of(),
+ config.credential(),
+ config.scope(),
+ config.oauth2ServerUri(),
+ optionalOAuthParams);
Review Comment:
The `fetchToken` call now forwards `optionalOAuthParams` (previous code didn’t). Is this a functional fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "dogukancagatay (via GitHub)" <gi...@apache.org>.
dogukancagatay commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2347237088
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -186,7 +185,12 @@ private static OAuthTokenResponse refreshToken(
}
return fetchToken(
- client, Map.of(), config.credential(), config.scope(), config.oauth2ServerUri());
+ client,
+ Map.of(),
+ config.credential(),
+ config.scope(),
+ config.oauth2ServerUri(),
+ optionalOAuthParams);
Review Comment:
I see this as a functional improvement rather than a fix. My assumption was that replacing the deprecated method was intended to allow passing these optional parameters, which were previously ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core, Data, Spark: Remove deprecations for 1.11.0 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2354798259
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -134,45 +134,8 @@ public S3FileIO(SerializableSupplier<S3Client> s3) {
* @param s3Async s3Async supplier
*/
public S3FileIO(SerializableSupplier<S3Client> s3, SerializableSupplier<S3AsyncClient> s3Async) {
- this(s3, s3Async, new S3FileIOProperties());
- }
-
- /**
- * Constructor with custom s3 supplier and S3FileIO properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier)} with {@link S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(SerializableSupplier<S3Client> s3, S3FileIOProperties s3FileIOProperties) {
- this(s3, null, s3FileIOProperties);
- }
-
- /**
- * Constructor with custom s3 supplier, s3Async supplier and S3FileIO properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3Async s3Async supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier, SerializableSupplier)} with {@link
- * S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(
- SerializableSupplier<S3Client> s3,
- SerializableSupplier<S3AsyncClient> s3Async,
- S3FileIOProperties s3FileIOProperties) {
this.s3 = s3;
this.s3Async = s3Async;
- this.createStack = Thread.currentThread().getStackTrace();
- this.properties = SerializableMap.copyOf(s3FileIOProperties.properties());
Review Comment:
we want to get rid of the `S3FileIOProperties` usage in this class, so we should change this to `this.properties = SerializableMap.copyOf(Maps.newHashMap())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org