You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Houston Putman (Jira)" <ji...@apache.org> on 2020/09/15 02:42:00 UTC
[jira] [Comment Edited] (SOLR-14789) Absorb and maintain
docker-solr functionality for Solr 9.0+
[ https://issues.apache.org/jira/browse/SOLR-14789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195826#comment-17195826 ]
Houston Putman edited comment on SOLR-14789 at 9/15/20, 2:41 AM:
-----------------------------------------------------------------
There isn't discussion on this ticket, but that doesn't mean that there wasn't discussion happening. Discussion happened on [JIRA|https://issues.apache.org/jira/browse/SOLR-11245], the [dev list|https://mail-archives.apache.org/mod_mbox/lucene-dev/202002.mbox/%3CCAD4GwrOSJX9x29S4a7e5g2j%3D9wsuMhYxFmNkrwrRHfnv0tPFOg%40mail.gmail.com%3E], [slack|https://the-asf.slack.com/archives/CEKUCUNE9/p1597865287041800] and obviously the [github PR|https://github.com/apache/lucene-solr/pull/1769]. I think that covers the bases pretty well.
Re-reading those, there's discussion from multiple community members, committers & PMC members and I see many opinions that the docker-solr repo should be rehomed to lucene-solr.
I'm also not sure how this was a code dump. The PR had comments from 5 community members, all of which were addressed and iterated on. The PR was open for 3 weeks and you were even tagged from the first day, but did not reply or give any feedback. I understand that you are busy and have other things that are going on, but there has been over a month of discussion (plus the mailing list from back in february).
I very much believe that the code that generates the solr docker image should live in the same repo as Solr, and I'm happy to discuss that further. As mentioned in the title of the issue, this is only meant for master, so there is time for us to improve the docker images for 9.0+ as well as the processes for generating them. The docker-solr repo will continue to be used for 8.x releases.
was (Author: houston):
There isn't discussion on this ticket, but that doesn't mean that there wasn't discussion happening. Discussion happened on JIRA, the [dev list|https://mail-archives.apache.org/mod_mbox/lucene-dev/202002.mbox/%3CCAD4GwrOSJX9x29S4a7e5g2j%3D9wsuMhYxFmNkrwrRHfnv0tPFOg%40mail.gmail.com%3E], [slack|https://the-asf.slack.com/archives/CEKUCUNE9/p1597865287041800] and obviously the [github PR|https://github.com/apache/lucene-solr/pull/1769]. I think that covers the bases pretty well.
Re-reading those, there's discussion from multiple community members, committers & PMC members and I see many opinions that the docker-solr repo should be rehomed to lucene-solr.
I'm also not sure how this was a code dump. The PR had comments from 5 community members, all of which were addressed and iterated on. The PR was open for 3 weeks and you were even tagged from the first day, but did not reply or give any feedback. I understand that you are busy and have other things that are going on, but there has been over a month of discussion (plus the mailing list from back in february).
I very much believe that the code that generates the solr docker image should live in the same repo as Solr, and I'm happy to discuss that further. As mentioned in the title of the issue, this is only meant for master, so there is time for us to improve the docker images for 9.0+ as well as the processes for generating them. The docker-solr repo will continue to be used for 8.x releases.
> Absorb and maintain docker-solr functionality for Solr 9.0+
> -----------------------------------------------------------
>
> Key: SOLR-14789
> URL: https://issues.apache.org/jira/browse/SOLR-14789
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Docker
> Affects Versions: master (9.0)
> Reporter: Houston Putman
> Assignee: Houston Putman
> Priority: Blocker
> Fix For: master (9.0)
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Migrate the docker image building and testing from the [https://github.com/docker-solr/docker-solr] repo into Solr. This is only applicable for 9.0+. Backporting Docker functionality to Solr 8x will be handled separately.
>
> This is meant to be a first pass migration and not solve all issues. The goal is:
> * Docker images be built in a flexible way that will allow for release and local builds to share the same business logic
> * Building and testing should be integrated with the gradle build
> * Maintain current usage documentation in their current form, but documentation on building images should go in the ref-guide. The usage documentation will be migrated separately.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org