You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/02 18:16:19 UTC

[GitHub] [beam] dpmills commented on pull request #13459: Change StreamingDataflowWorker from encoding key

dpmills commented on pull request #13459:
URL: https://github.com/apache/beam/pull/13459#issuecomment-737406172


   I don't think anything relies on the current behavior, and shardingKey and workToken seem like better values to log anyways.  However, I've seen String.format cause performance problems before (IIRC it has to parse the format string each time, and you are calling it once per bundle here), so it's probably best to use a faster formatting method (Long.toHexString and StringBuilder etc).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org