[GitHub] libcloud pull request #1167: Made pytest-runner optional

[vaygr <gi...@git.apache.org>]

GitHub user vaygr opened a pull request:

    https://github.com/apache/libcloud/pull/1167

    Made pytest-runner optional

    ## Switch to optional pytest-runner, required only for tests
    
    ### Description
    
    This fixes what was introduced by b4ce936: a forced dependency of the [pytest-runner](https://github.com/pytest-dev/pytest-runner) for any `setup.py` target, including `build` and `install`, which is not really appropriate, since it should be required only for testing, when you invoke `python setup.py test` or its aliases.
    
    Such a forced dependency makes distribution packaging more complicated, since pytest-runner pulls other dependencies (like setuptools_scm) which may have other dependencies or Python version requirements for no reason.
    
    It is also breaks libcloud installation on older distros (e.g. Debian Wheezy), where libcloud **2.0.0** worked just perfectly, but anything above it couldn't because pytest-runner and/or its dependencies cannot be installed.
    
    Plus, testing should always be optional.
    
    Thankfully, there's an [official solution](https://github.com/pytest-dev/pytest-runner#conditional-requirement) to make sure pytest-runner is invoked when it's really needed.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] Code linting

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vaygr/libcloud pytest-runner-optional

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1167
    
----
commit 40629b1d6dbd9822cbae5984f96f6932f01dbf15
Author: Vlad Glagolev <sc...@...>
Date:   2018-01-25T16:19:36Z

    Made pytest-runner optional

commit 05d46fecef34ed166a9146ef67eeb1ad85de3130
Author: Vlad Glagolev <sc...@...>
Date:   2018-01-25T16:24:04Z

    PEP8++

----


---

[GitHub] libcloud pull request #1167: Made pytest-runner optional

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/1167


---