You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/04/14 19:43:27 UTC
Review Request 20329: Shade protobuf dependency.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20329/
-----------------------------------------------------------
Review request for mesos, Patrick Wendell and Vinod Kone.
Repository: mesos-git
Description
-------
Still considering other things we should/could be doing to clean up the way we compile against protobuf today ... thoughts?
Diffs
-----
src/java/mesos.pom.in 8f9b747b2b737ae9c1b1cab7dc3d7d0555de8f1b
Diff: https://reviews.apache.org/r/20329/diff/
Testing
-------
make maven-install
What's the best way to test this?
Thanks,
Benjamin Hindman
Re: Review Request 20329: Shade protobuf dependency.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20329/#review40287
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20329]
All tests passed.
- Mesos ReviewBot
On April 14, 2014, 5:44 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20329/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 5:44 p.m.)
>
>
> Review request for mesos, Patrick Wendell and Vinod Kone.
>
>
> Bugs: MESOS-1203
> https://issues.apache.org/jira/browse/MESOS-1203
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Still considering other things we should/could be doing to clean up the way we compile against protobuf today ... thoughts?
>
>
> Diffs
> -----
>
> src/java/mesos.pom.in 8f9b747b2b737ae9c1b1cab7dc3d7d0555de8f1b
>
> Diff: https://reviews.apache.org/r/20329/diff/
>
>
> Testing
> -------
>
> make maven-install
>
> What's the best way to test this?
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20329: Shade protobuf dependency.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20329/#review40345
-----------------------------------------------------------
Ship it!
LGTM modulo testing.
- Vinod Kone
On April 14, 2014, 5:44 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20329/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 5:44 p.m.)
>
>
> Review request for mesos, Patrick Wendell and Vinod Kone.
>
>
> Bugs: MESOS-1203
> https://issues.apache.org/jira/browse/MESOS-1203
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Still considering other things we should/could be doing to clean up the way we compile against protobuf today ... thoughts?
>
>
> Diffs
> -----
>
> src/java/mesos.pom.in 8f9b747b2b737ae9c1b1cab7dc3d7d0555de8f1b
>
> Diff: https://reviews.apache.org/r/20329/diff/
>
>
> Testing
> -------
>
> make maven-install
>
> What's the best way to test this?
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20329: Shade protobuf dependency.
Posted by Tobi Knaup <to...@knaup.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20329/#review40471
-----------------------------------------------------------
Ship it!
lgtm! For testing, jar tf should show the shaded namespace.
- Tobi Knaup
On April 14, 2014, 5:44 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20329/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 5:44 p.m.)
>
>
> Review request for mesos, Patrick Wendell and Vinod Kone.
>
>
> Bugs: MESOS-1203
> https://issues.apache.org/jira/browse/MESOS-1203
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Still considering other things we should/could be doing to clean up the way we compile against protobuf today ... thoughts?
>
>
> Diffs
> -----
>
> src/java/mesos.pom.in 8f9b747b2b737ae9c1b1cab7dc3d7d0555de8f1b
>
> Diff: https://reviews.apache.org/r/20329/diff/
>
>
> Testing
> -------
>
> make maven-install
>
> What's the best way to test this?
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 20329: Shade protobuf dependency.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20329/
-----------------------------------------------------------
(Updated April 14, 2014, 5:44 p.m.)
Review request for mesos, Patrick Wendell and Vinod Kone.
Changes
-------
Added bug.
Bugs: MESOS-1203
https://issues.apache.org/jira/browse/MESOS-1203
Repository: mesos-git
Description
-------
Still considering other things we should/could be doing to clean up the way we compile against protobuf today ... thoughts?
Diffs
-----
src/java/mesos.pom.in 8f9b747b2b737ae9c1b1cab7dc3d7d0555de8f1b
Diff: https://reviews.apache.org/r/20329/diff/
Testing
-------
make maven-install
What's the best way to test this?
Thanks,
Benjamin Hindman