You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "eldenmoon (via GitHub)" <gi...@apache.org> on 2023/08/17 03:48:21 UTC
[GitHub] [doris] eldenmoon opened a new pull request, #23083: Branch 2.0 var
eldenmoon opened a new pull request, #23083:
URL: https://github.com/apache/doris/pull/23083
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #23083: [Draft] Branch 2.0 variant
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #23083:
URL: https://github.com/apache/doris/pull/23083#discussion_r1302729740
##########
be/src/udf/udf.h:
##########
@@ -79,6 +79,12 @@ class FunctionContext {
return _check_overflow_for_decimal = check_overflow_for_decimal;
}
+ void set_string_as_jsonb_string(bool string_as_jsonb_string) {
+ _string_as_jsonb_string = string_as_jsonb_string;
+ }
+
+ bool string_as_jsonb_string() const { return _string_as_jsonb_string; }
Review Comment:
warning: function 'string_as_jsonb_string' should be marked [[nodiscard]] [modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool string_as_jsonb_string() const { return _string_as_jsonb_string; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #23083: Branch 2.0 var
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #23083:
URL: https://github.com/apache/doris/pull/23083#discussion_r1296648158
##########
be/src/olap/field.h:
##########
@@ -57,6 +58,7 @@ class Field {
size_t index_size() const { return _index_size; }
int32_t unique_id() const { return _unique_id; }
const std::string& name() const { return _name; }
+ const vectorized::PathInData& path() const { return _path; }
Review Comment:
warning: function 'path' should be marked [[nodiscard]] [modernize-use-nodiscard]
```suggestion
[[nodiscard]] const vectorized::PathInData& path() const { return _path; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #23083: Branch 2.0 var
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #23083:
URL: https://github.com/apache/doris/pull/23083#issuecomment-1681568441
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Draft] Branch 2.0 variant [doris]
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on PR #23083:
URL: https://github.com/apache/doris/pull/23083#issuecomment-1786683995
use branch-2.0-var
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Draft] Branch 2.0 variant [doris]
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang closed pull request #23083: [Draft] Branch 2.0 variant
URL: https://github.com/apache/doris/pull/23083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #23083: Branch 2.0 var
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #23083:
URL: https://github.com/apache/doris/pull/23083#issuecomment-1681574314
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #23083: [Draft] Branch 2.0 variant
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #23083:
URL: https://github.com/apache/doris/pull/23083#discussion_r1318601665
##########
be/src/udf/udf.h:
##########
@@ -79,6 +79,22 @@ class FunctionContext {
return _check_overflow_for_decimal = check_overflow_for_decimal;
}
+ void set_string_as_jsonb_string(bool string_as_jsonb_string) {
+ _string_as_jsonb_string = string_as_jsonb_string;
+ }
+
+ void set_jsonb_string_as_string(bool jsonb_string_as_string) {
+ _jsonb_string_as_string = jsonb_string_as_string;
+ }
+
+ // Cast flag, when enable string_as_jsonb_string, string casting to jsonb will not parse string
+ // instead just insert a string literal
+ bool string_as_jsonb_string() const { return _string_as_jsonb_string; }
+
+ // Cast flag, when enable jsonb_string_as_string, jsonb string casting to string will not parse string
+ // instead just insert a string literal
+ bool jsonb_string_as_string() const { return _jsonb_string_as_string; }
Review Comment:
warning: function 'jsonb_string_as_string' should be marked [[nodiscard]] [modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool jsonb_string_as_string() const { return _jsonb_string_as_string; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org