[jira] [Created] (SOLR-6541) Enhancement for SOLR-6452 StatsComponent "missing" stat won't work with docValues=true and indexed=false

["Vitaliy Zhovtyuk (JIRA)" <ji...@apache.org>]

Vitaliy Zhovtyuk created SOLR-6541:
--------------------------------------

             Summary: Enhancement for SOLR-6452 StatsComponent "missing" stat won't work with docValues=true and indexed=false
                 Key: SOLR-6541
                 URL: https://issues.apache.org/jira/browse/SOLR-6541
             Project: Solr
          Issue Type: Improvement
    Affects Versions: 4.10, 6.0
            Reporter: Vitaliy Zhovtyuk
            Priority: Minor
             Fix For: 5.0, 6.0


This issue is refactoring of solution provided in SOLR-6452 StatsComponent "missing" stat won't work with docValues=true and indexed=false.
I think the following points need to be addressed:
1. Accumulate methods should not return stats specific numbers (it is generic). Attached solution with container class. Also made them private scoped.
Returning just missing fields from accumulate methods does not allow you to extend it with additional counts field, therefore i propose to leave void.
2. Reduced visibility of fields in FieldFacetStats.
3. Methods FieldFacetStats#accumulateMissing and FieldFacetStats#accumulateTermNum does not throw any IO exception
4. We don't need intermediate maps to accumulate missing counts. Method  org.apache.solr.handler.component.FieldFacetStats#facetMissingNum 
can be changed to work directly on StatsValues structure and removed org.apache.solr.handler.component.FieldFacetStats#accumulateMissing. 
We don't need to have it in 2 phases.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org