You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/09 22:05:54 UTC
[GitHub] [iceberg] jackye1995 opened a new pull request, #6551: Spec: add view-uuid to view spec
jackye1995 opened a new pull request, #6551:
URL: https://github.com/apache/iceberg/pull/6551
As discussed in #6420 , add a UUID field in view spec so that a storage table can refer to a view it's backing by its ID. @rdblue @amogh-jahagirdar @jzhuge @JanKaul
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] JanKaul commented on pull request #6551: Spec: add view-uuid to view spec
Posted by GitBox <gi...@apache.org>.
JanKaul commented on PR #6551:
URL: https://github.com/apache/iceberg/pull/6551#issuecomment-1376845383
If the materialized view spec is the main reason for this PR, I think we should wait with merging this PR until the materialized view spec is finalized.
I would like to consider an alternative solution for referencing the associated view from the storage table. This might be off-topic but the following should give some context.
The current design for materialized views uses a storage table and an associated view. In my opinion it would be a cleaner solution for users if only one of these objects appears in the catalog because logically the materialized view is also just one object.
This way however, the uuid of the associated view cannot be used as a reference from the storage table, since it is not registered in the catalog.
I therefore propose to use the view metadata location, which has the form `<version>-<random-uuid>.metadata.json`, as the reference to the associated view definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6551: Spec: add view-uuid to view spec
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on PR #6551:
URL: https://github.com/apache/iceberg/pull/6551#issuecomment-1377531453
> If the materialized view spec is the main reason for this PR, I think we should wait with merging this PR until the materialized view spec is finalized.
But overall a UUID to uniquely identify the view seems like a generally good thing to have regardless of MV, that's why I am trying to see if it could be merged separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6551: Spec: add view-uuid to view spec
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6551:
URL: https://github.com/apache/iceberg/pull/6551#issuecomment-1376764770
> what's the use case for that? In my mind view should always be refreshed and kept up to date based on the representation
I was thinking more like, we can `replace view` in another branch for experimentation. Instead of replacing them on the main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6551: Spec: add view-uuid to view spec
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on PR #6551:
URL: https://github.com/apache/iceberg/pull/6551#issuecomment-1377570196
> I was thinking more like, we can replace view in another branch for experimentation. Instead of replacing them on the main branch.
That might not justify adding a full branching and tagging feature to view, feels a bit of an overkill to me at first glance, but REPLACE is a good point, it's similar to how we use branch to have a more sophisticated WAP workflow. Maybe WAP could be the first step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spec: add view-uuid to view spec [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra closed pull request #6551: Spec: add view-uuid to view spec
URL: https://github.com/apache/iceberg/pull/6551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6551: Spec: add view-uuid to view spec
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on PR #6551:
URL: https://github.com/apache/iceberg/pull/6551#issuecomment-1376761665
> If we have a plans to support branching with views. We can add optional refs too in the spec (similar to the Table spec).
what's the use case for that? In my mind view should always be refreshed and kept up to date based on the representation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spec: add view-uuid to view spec [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #6551:
URL: https://github.com/apache/iceberg/pull/6551#issuecomment-1752805845
Closing this as it has been addressed as part of https://github.com/apache/iceberg/pull/8591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org