You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ChiaPing Tsai (JIRA)" <ji...@apache.org> on 2016/10/30 17:28:58 UTC

[jira] [Updated] (HBASE-16969) RegionCoprocessorServiceExec should override the toString() for logging

     [ https://issues.apache.org/jira/browse/HBASE-16969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ChiaPing Tsai updated HBASE-16969:
----------------------------------
    Summary: RegionCoprocessorServiceExec should override the toString() for logging  (was: RegionCoprocessorServiceExec should override the toString for logging)

> RegionCoprocessorServiceExec should override the toString() for logging
> -----------------------------------------------------------------------
>
>                 Key: HBASE-16969
>                 URL: https://issues.apache.org/jira/browse/HBASE-16969
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0, 1.3.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-16969.branch-1.v0.patch, HBASE-16969.v0.patch, HBASE-16969.v1.patch
>
>
> The toString() method is used to log in BatchErrors#makeException.
> {code:title=BatchErrors.java|borderStyle=solid}
> synchronized RetriesExhaustedWithDetailsException makeException(boolean logDetails) {
>   if (logDetails) {LOG.error("Exception occurred! Exception details: " + throwables + ";\nActions: " + actions);
>  }
> {code}
> If RegionCoprocessorServiceExec doesn’t override the toString(), we will see the hash code in the log message. That message is useless for debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)