You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/09/13 09:18:07 UTC

[GitHub] [echarts] jjansen72 commented on pull request #17636: fix: add width, height, x,y to CustomSeriesRenderItemParamsCoordSys type

jjansen72 commented on PR #17636:
URL: https://github.com/apache/echarts/pull/17636#issuecomment-1245130378

   > `CustomSeriesRenderItemParamsCoordSys` does not contain those properties. You are probably using bmap so the type should be changed [with bmap](https://github.com/apache/echarts/blob/master/extension-src/bmap/BMapCoordSys.ts#L94). But this file uses `@ts-nocheck`, so changing this typing won't help. So I would like to suggest converting types in your own code and leave this PR closed. Thanks for your contribution!
   
   I'm confused as well. The example (https://echarts.apache.org/examples/en/editor.html?c=custom-profile) is working, but the type of `params.coordSys` seems to be wrong. Could you give us an example of how to change the types? Or could it be, that the example is outdated?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org