[GitHub] [netbeans] arusinha commented on a change in pull request #1144: [NETBEANS-2284]:NB build with jdk11

[GitBox <gi...@apache.org>]

arusinha commented on a change in pull request #1144: [NETBEANS-2284]:NB build with jdk11
URL: https://github.com/apache/netbeans/pull/1144#discussion_r294692877
 
 

 ##########
 File path: java/maven.indexer/src/org/netbeans/modules/maven/indexer/OnStop.java
 ##########
 @@ -41,7 +41,7 @@ public void run() {
                 }
                 if (t.isAlive()) {
                     LOG.warning("...hard stop required.");
-                    t.stop(new Cancellation());
+                    t.interrupt();
 
 Review comment:
      In JDK-8 , find below the implemention
    @Deprecated
       public final synchronized void stop(Throwable obj) {
           throw new UnsupportedOperationException();
       }
   Unless the method is overridden in some child Thread class, this is least likely to cause an issue

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists