You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Remko Popma <re...@gmail.com> on 2016/04/28 19:51:03 UTC
Allocation Instrumenter
Hi Colin,
I'm contacting you because you are listed as one of the contributors to the
allocation-instrumenter <https://github.com/google/allocation-instrumenter>
project on GitHub.
We are working on Log4j 2 <http://logging.apache.org/log4j/2.x/>, and the
main theme of the upcoming 2.6 release is making Log4j 2 garbage-free
<https://issues.apache.org/jira/browse/LOG4J2-1270> in steady state running.
We use the allocation instrumenter in our JUnit tests to verify that things
are working as expected.
However, on our build server we see our test fail spuriously.
I believe this is a bug in AllocationRecorder (to do with accessing a
volatile field that has been nulled out by a shutdown hook, details here
<https://github.com/google/allocation-instrumenter/issues/15>).
Could you please take a look?
If you no longer maintain this project, can you point us to the person who
does?
Many thanks!
Remko Popma
Re: Allocation Instrumenter
Posted by Matt Sicker <bo...@gmail.com>.
There's a fork with some activity:
https://github.com/malamut2/large-object-watchdog
On 3 May 2016 at 19:12, Remko Popma <re...@gmail.com> wrote:
> Shall we first create a Git pull request that implements the fix to make
> it minimum effort for the maintainer to address this?
>
> Any volunteers? :-)
>
> Sent from my iPhone
>
> On 2016/05/04, at 6:26, Ralph Goers <ra...@dslextreme.com> wrote:
>
> I have no idea what can be done under the apache github account.
>
> Ralph
>
> On May 3, 2016, at 1:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> Do we fork it under one of our accounts or the apache github account?
>
> Gary
>
> On May 3, 2016 12:02 PM, "Ralph Goers" <ra...@dslextreme.com> wrote:
> >
> > Guess we have to fork it?
> >
> > Ralph
> >
> >> On May 3, 2016, at 11:48 AM, Gary Gregory <ga...@gmail.com>
> wrote:
> >>
> >> Yikes, no reply on
> https://github.com/google/allocation-instrumenter/issues/15
> >>
> >> G
> >>
> >> On Thu, Apr 28, 2016 at 10:51 AM, Remko Popma <re...@gmail.com>
> wrote:
> >>>
> >>> Hi Colin,
> >>>
> >>> I'm contacting you because you are listed as one of the contributors
> to the allocation-instrumenter project on GitHub.
> >>>
> >>> We are working on Log4j 2, and the main theme of the upcoming 2.6
> release is making Log4j 2 garbage-free in steady state running.
> >>> We use the allocation instrumenter in our JUnit tests to verify that
> things are working as expected.
> >>>
> >>> However, on our build server we see our test fail spuriously.
> >>> I believe this is a bug in AllocationRecorder (to do with accessing a
> volatile field that has been nulled out by a shutdown hook, details here).
> >>>
> >>> Could you please take a look?
> >>> If you no longer maintain this project, can you point us to the person
> who does?
> >>>
> >>> Many thanks!
> >>> Remko Popma
> >>>
> >>>
> >>
> >>
> >>
> >> --
> >> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >> Java Persistence with Hibernate, Second Edition
> >> JUnit in Action, Second Edition
> >> Spring Batch in Action
> >> Blog: http://garygregory.wordpress.com
> >> Home: http://garygregory.com/
> >> Tweet! http://twitter.com/GaryGregory
> >
> >
>
>
>
--
Matt Sicker <bo...@gmail.com>
Re: Allocation Instrumenter
Posted by Remko Popma <re...@gmail.com>.
Shall we first create a Git pull request that implements the fix to make it minimum effort for the maintainer to address this?
Any volunteers? :-)
Sent from my iPhone
> On 2016/05/04, at 6:26, Ralph Goers <ra...@dslextreme.com> wrote:
>
> I have no idea what can be done under the apache github account.
>
> Ralph
>
>> On May 3, 2016, at 1:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> Do we fork it under one of our accounts or the apache github account?
>>
>> Gary
>>
>> On May 3, 2016 12:02 PM, "Ralph Goers" <ra...@dslextreme.com> wrote:
>> >
>> > Guess we have to fork it?
>> >
>> > Ralph
>> >
>> >> On May 3, 2016, at 11:48 AM, Gary Gregory <ga...@gmail.com> wrote:
>> >>
>> >> Yikes, no reply on https://github.com/google/allocation-instrumenter/issues/15
>> >>
>> >> G
>> >>
>> >> On Thu, Apr 28, 2016 at 10:51 AM, Remko Popma <re...@gmail.com> wrote:
>> >>>
>> >>> Hi Colin,
>> >>>
>> >>> I'm contacting you because you are listed as one of the contributors to the allocation-instrumenter project on GitHub.
>> >>>
>> >>> We are working on Log4j 2, and the main theme of the upcoming 2.6 release is making Log4j 2 garbage-free in steady state running.
>> >>> We use the allocation instrumenter in our JUnit tests to verify that things are working as expected.
>> >>>
>> >>> However, on our build server we see our test fail spuriously.
>> >>> I believe this is a bug in AllocationRecorder (to do with accessing a volatile field that has been nulled out by a shutdown hook, details here).
>> >>>
>> >>> Could you please take a look?
>> >>> If you no longer maintain this project, can you point us to the person who does?
>> >>>
>> >>> Many thanks!
>> >>> Remko Popma
>> >>>
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> >> Java Persistence with Hibernate, Second Edition
>> >> JUnit in Action, Second Edition
>> >> Spring Batch in Action
>> >> Blog: http://garygregory.wordpress.com
>> >> Home: http://garygregory.com/
>> >> Tweet! http://twitter.com/GaryGregory
>> >
>> >
>>
>
Re: Allocation Instrumenter
Posted by Ralph Goers <ra...@dslextreme.com>.
I have no idea what can be done under the apache github account.
Ralph
> On May 3, 2016, at 1:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> Do we fork it under one of our accounts or the apache github account?
>
> Gary
>
> On May 3, 2016 12:02 PM, "Ralph Goers" <ralph.goers@dslextreme.com <ma...@dslextreme.com>> wrote:
> >
> > Guess we have to fork it?
> >
> > Ralph
> >
> >> On May 3, 2016, at 11:48 AM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
> >>
> >> Yikes, no reply on https://github.com/google/allocation-instrumenter/issues/15 <https://github.com/google/allocation-instrumenter/issues/15>
> >>
> >> G
> >>
> >> On Thu, Apr 28, 2016 at 10:51 AM, Remko Popma <remko.popma@gmail.com <ma...@gmail.com>> wrote:
> >>>
> >>> Hi Colin,
> >>>
> >>> I'm contacting you because you are listed as one of the contributors to the allocation-instrumenter project on GitHub.
> >>>
> >>> We are working on Log4j 2, and the main theme of the upcoming 2.6 release is making Log4j 2 garbage-free in steady state running.
> >>> We use the allocation instrumenter in our JUnit tests to verify that things are working as expected.
> >>>
> >>> However, on our build server we see our test fail spuriously.
> >>> I believe this is a bug in AllocationRecorder (to do with accessing a volatile field that has been nulled out by a shutdown hook, details here).
> >>>
> >>> Could you please take a look?
> >>> If you no longer maintain this project, can you point us to the person who does?
> >>>
> >>> Many thanks!
> >>> Remko Popma
> >>>
> >>>
> >>
> >>
> >>
> >> --
> >> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
> >> Java Persistence with Hibernate, Second Edition
> >> JUnit in Action, Second Edition
> >> Spring Batch in Action
> >> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
> >> Home: http://garygregory.com/ <http://garygregory.com/>
> >> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
> >
> >
Re: Allocation Instrumenter
Posted by Gary Gregory <ga...@gmail.com>.
Do we fork it under one of our accounts or the apache github account?
Gary
On May 3, 2016 12:02 PM, "Ralph Goers" <ra...@dslextreme.com> wrote:
>
> Guess we have to fork it?
>
> Ralph
>
>> On May 3, 2016, at 11:48 AM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> Yikes, no reply on
https://github.com/google/allocation-instrumenter/issues/15
>>
>> G
>>
>> On Thu, Apr 28, 2016 at 10:51 AM, Remko Popma <re...@gmail.com>
wrote:
>>>
>>> Hi Colin,
>>>
>>> I'm contacting you because you are listed as one of the contributors to
the allocation-instrumenter project on GitHub.
>>>
>>> We are working on Log4j 2, and the main theme of the upcoming 2.6
release is making Log4j 2 garbage-free in steady state running.
>>> We use the allocation instrumenter in our JUnit tests to verify that
things are working as expected.
>>>
>>> However, on our build server we see our test fail spuriously.
>>> I believe this is a bug in AllocationRecorder (to do with accessing a
volatile field that has been nulled out by a shutdown hook, details here).
>>>
>>> Could you please take a look?
>>> If you no longer maintain this project, can you point us to the person
who does?
>>>
>>> Many thanks!
>>> Remko Popma
>>>
>>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
>
Re: Allocation Instrumenter
Posted by Ralph Goers <ra...@dslextreme.com>.
Guess we have to fork it?
Ralph
> On May 3, 2016, at 11:48 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> Yikes, no reply on https://github.com/google/allocation-instrumenter/issues/15 <https://github.com/google/allocation-instrumenter/issues/15>
>
> G
>
> On Thu, Apr 28, 2016 at 10:51 AM, Remko Popma <remko.popma@gmail.com <ma...@gmail.com>> wrote:
> Hi Colin,
>
> I'm contacting you because you are listed as one of the contributors to the allocation-instrumenter <https://github.com/google/allocation-instrumenter> project on GitHub.
>
> We are working on Log4j 2 <http://logging.apache.org/log4j/2.x/>, and the main theme of the upcoming 2.6 release is making Log4j 2 garbage-free <https://issues.apache.org/jira/browse/LOG4J2-1270> in steady state running.
> We use the allocation instrumenter in our JUnit tests to verify that things are working as expected.
>
> However, on our build server we see our test fail spuriously.
> I believe this is a bug in AllocationRecorder (to do with accessing a volatile field that has been nulled out by a shutdown hook, details here <https://github.com/google/allocation-instrumenter/issues/15>).
>
> Could you please take a look?
> If you no longer maintain this project, can you point us to the person who does?
>
> Many thanks!
> Remko Popma
>
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
Re: Allocation Instrumenter
Posted by Gary Gregory <ga...@gmail.com>.
Yikes, no reply on
https://github.com/google/allocation-instrumenter/issues/15
G
On Thu, Apr 28, 2016 at 10:51 AM, Remko Popma <re...@gmail.com> wrote:
> Hi Colin,
>
> I'm contacting you because you are listed as one of the contributors to
> the allocation-instrumenter
> <https://github.com/google/allocation-instrumenter> project on GitHub.
>
> We are working on Log4j 2 <http://logging.apache.org/log4j/2.x/>, and the
> main theme of the upcoming 2.6 release is making Log4j 2 garbage-free
> <https://issues.apache.org/jira/browse/LOG4J2-1270> in steady state
> running.
> We use the allocation instrumenter in our JUnit tests to verify that
> things are working as expected.
>
> However, on our build server we see our test fail spuriously.
> I believe this is a bug in AllocationRecorder (to do with accessing a
> volatile field that has been nulled out by a shutdown hook, details here
> <https://github.com/google/allocation-instrumenter/issues/15>).
>
> Could you please take a look?
> If you no longer maintain this project, can you point us to the person who
> does?
>
> Many thanks!
> Remko Popma
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Allocation Instrumenter
Posted by Remko Popma <re...@gmail.com>.
Created pull request with the fix that Ami suggested.
https://github.com/google/allocation-instrumenter/pull/16
On Wed, May 4, 2016 at 1:22 PM, Ami Fischman <fi...@google.com> wrote:
> Replied on public issue.
>
> On Tue, May 3, 2016 at 7:44 PM Remko Popma <re...@gmail.com> wrote:
>
>> (Added Jeremy Manson and Ami Fischman to recipients)
>>
>> Guys, we're interested in fixing this concurrency bug in
>> AllocationRecorder:
>> https://github.com/google/allocation-instrumenter/issues/15
>>
>> What would be the best way to accomplish this?
>>
>> Remko Popma
>>
>> On Friday, 29 April 2016, Remko Popma <re...@gmail.com> wrote:
>>
>>> Hi Colin,
>>>
>>> I'm contacting you because you are listed as one of the contributors to
>>> the allocation-instrumenter
>>> <https://github.com/google/allocation-instrumenter> project on GitHub.
>>>
>>> We are working on Log4j 2 <http://logging.apache.org/log4j/2.x/>, and
>>> the main theme of the upcoming 2.6 release is making Log4j 2
>>> garbage-free <https://issues.apache.org/jira/browse/LOG4J2-1270> in
>>> steady state running.
>>> We use the allocation instrumenter in our JUnit tests to verify that
>>> things are working as expected.
>>>
>>> However, on our build server we see our test fail spuriously.
>>> I believe this is a bug in AllocationRecorder (to do with accessing a
>>> volatile field that has been nulled out by a shutdown hook, details here
>>> <https://github.com/google/allocation-instrumenter/issues/15>).
>>>
>>> Could you please take a look?
>>> If you no longer maintain this project, can you point us to the person
>>> who does?
>>>
>>> Many thanks!
>>> Remko Popma
>>>
>>>
>>>
Re: Allocation Instrumenter
Posted by Remko Popma <re...@gmail.com>.
(Added Jeremy Manson and Ami Fischman to recipients)
Guys, we're interested in fixing this concurrency bug in
AllocationRecorder:
https://github.com/google/allocation-instrumenter/issues/15
What would be the best way to accomplish this?
Remko Popma
On Friday, 29 April 2016, Remko Popma <re...@gmail.com> wrote:
> Hi Colin,
>
> I'm contacting you because you are listed as one of the contributors to
> the allocation-instrumenter
> <https://github.com/google/allocation-instrumenter> project on GitHub.
>
> We are working on Log4j 2 <http://logging.apache.org/log4j/2.x/>, and the
> main theme of the upcoming 2.6 release is making Log4j 2 garbage-free
> <https://issues.apache.org/jira/browse/LOG4J2-1270> in steady state
> running.
> We use the allocation instrumenter in our JUnit tests to verify that
> things are working as expected.
>
> However, on our build server we see our test fail spuriously.
> I believe this is a bug in AllocationRecorder (to do with accessing a
> volatile field that has been nulled out by a shutdown hook, details here
> <https://github.com/google/allocation-instrumenter/issues/15>).
>
> Could you please take a look?
> If you no longer maintain this project, can you point us to the person who
> does?
>
> Many thanks!
> Remko Popma
>
>
>