You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2009/09/24 15:53:15 UTC
[jira] Created: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Remove dependency on EDU.oswego.cs.dl.util.concurrent
------------------------------------------------------
Key: JCR-2324
URL: https://issues.apache.org/jira/browse/JCR-2324
Project: Jackrabbit Content Repository
Issue Type: Task
Components: jackrabbit-jcr2spi
Reporter: Julian Reschke
Priority: Minor
EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762187#action_12762187 ]
Julian Reschke commented on JCR-2324:
-------------------------------------
Works for me. Thanks for figuring out what was wrong (essentially a bug in the test suite).
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-2324.patch, mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-2324:
--------------------------------
Attachment: mutex.patch
patch using Semaphore instead of Mutex/Sync (test still pass, but somebody should review this)
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig resolved JCR-2324.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Assignee: Michael Dürig
Fixed in revision: 822311
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Assignee: Michael Dürig
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: JCR-2324.patch, mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761534#action_12761534 ]
Michael Dürig commented on JCR-2324:
------------------------------------
Are you on the latest trunk? In particular make sure you have the fixes from JCR-2337 and JCR-2338.
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-2324.patch, mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762170#action_12762170 ]
Michael Dürig commented on JCR-2324:
------------------------------------
I fixed JCR-2346 which caused problems with JDK 1.6. Now it works for me both with 1.5 and 1.6 on Windows XP. Could you try again on your side?
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-2324.patch, mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761608#action_12761608 ]
Julian Reschke commented on JCR-2324:
-------------------------------------
Fails here as well (and actually in the same way these failed when I tried the same approach :-)
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-2324.patch, mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761503#action_12761503 ]
Marcel Reutegger commented on JCR-2324:
---------------------------------------
hmm, that doesn't work for me. I get lots of node type related errors when running tests in jackrabbit-spi2jcr. might be related to the replacement of ConcurrentReaderHashMap with ConcurrentHashMap, which is not exactly the same. It seems some tests now pick a different node type than before because the iteration order is different with the patch applied.
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-2324.patch, mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761233#action_12761233 ]
Michael Dürig commented on JCR-2324:
------------------------------------
PS: JCR-2324.patch includes Julian's initial patch and also handles InterruptedException as I suggested in an earlier comment.
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-2324.patch, mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761181#action_12761181 ]
Michael Dürig commented on JCR-2324:
------------------------------------
Works for me. One thing I noted however: The methods dispose() and onEventReceived() should probably not release the semaphore when an InterruptedException has been thrown. That was not a problem with Mutex since there release() was idempotent. I think this is different with Semaphore.
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-2324) Remove dependency on
EDU.oswego.cs.dl.util.concurrent
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig updated JCR-2324:
-------------------------------
Attachment: JCR-2324.patch
Patch removing the remaining dependencies to EDU.oswego.cs.dl.util.concurrent.
Please review.
> Remove dependency on EDU.oswego.cs.dl.util.concurrent
> ------------------------------------------------------
>
> Key: JCR-2324
> URL: https://issues.apache.org/jira/browse/JCR-2324
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-jcr2spi
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-2324.patch, mutex.patch
>
>
> EDU.oswego.cs.dl.util.concurrent is in maintenance mode, and http://g.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/package-summary.html advises to migrate to the JDK5 java.util.concurrent package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.