You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/16 06:47:03 UTC

[GitHub] [hudi] xicm opened a new pull request, #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

xicm opened a new pull request, #7675:
URL: https://github.com/apache/hudi/pull/7675

   ### Change Logs
   
   The preCombine method we are using is```T preCombine(T oldValue);```This method returns the newer record.
   
   For PartialUpdateAvroPayload we should return a new merged record, and this is implemented by ```T preCombine(T oldValue, Schema schema, Properties properties)```.
   
   With this change,  PartialUpdateAvroPayload will call ```T preCombine(T oldValue, Schema schema, Properties properties)``` , and other payloads still call ```T preCombine(T oldValue);```
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   none
   
   ### Risk level (write none, low medium or high below)
   none
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7675:
URL: https://github.com/apache/hudi/pull/7675#issuecomment-1384058597

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14337",
       "triggerID" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7c71fba0810ec2250cf139ca8876fcfbdbd10f1f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7c71fba0810ec2250cf139ca8876fcfbdbd10f1f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * be7dc35447d191ecdefe3cd209a94bc0963ec1bf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14337) 
   * 7c71fba0810ec2250cf139ca8876fcfbdbd10f1f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xicm commented on pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on PR #7675:
URL: https://github.com/apache/hudi/pull/7675#issuecomment-1409854509

   @danny0405 The problem has been fix by #7759, we can close this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7675:
URL: https://github.com/apache/hudi/pull/7675#issuecomment-1384526634

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14337",
       "triggerID" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7c71fba0810ec2250cf139ca8876fcfbdbd10f1f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14346",
       "triggerID" : "7c71fba0810ec2250cf139ca8876fcfbdbd10f1f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7c71fba0810ec2250cf139ca8876fcfbdbd10f1f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14346) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xicm commented on pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

Posted by GitBox <gi...@apache.org>.
xicm commented on PR #7675:
URL: https://github.com/apache/hudi/pull/7675#issuecomment-1384730362

   > A valid fix, can we add a test case for it
   
   Done. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7675:
URL: https://github.com/apache/hudi/pull/7675#issuecomment-1383600879

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * be7dc35447d191ecdefe3cd209a94bc0963ec1bf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xicm closed pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm closed pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called
URL: https://github.com/apache/hudi/pull/7675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7675:
URL: https://github.com/apache/hudi/pull/7675#issuecomment-1384066892

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14337",
       "triggerID" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7c71fba0810ec2250cf139ca8876fcfbdbd10f1f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14346",
       "triggerID" : "7c71fba0810ec2250cf139ca8876fcfbdbd10f1f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * be7dc35447d191ecdefe3cd209a94bc0963ec1bf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14337) 
   * 7c71fba0810ec2250cf139ca8876fcfbdbd10f1f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14346) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7675:
URL: https://github.com/apache/hudi/pull/7675#issuecomment-1384048857

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14337",
       "triggerID" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * be7dc35447d191ecdefe3cd209a94bc0963ec1bf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14337) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7675: [HUDI-5561] The preCombine method of PartialUpdateAvroPayload is not called

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7675:
URL: https://github.com/apache/hudi/pull/7675#issuecomment-1383605653

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14337",
       "triggerID" : "be7dc35447d191ecdefe3cd209a94bc0963ec1bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * be7dc35447d191ecdefe3cd209a94bc0963ec1bf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14337) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org