[GitHub] [iotdb] JackieTien97 commented on a change in pull request #5376: [IoTDB-2661] Add PlanNode visualizer tool

[GitBox <gi...@apache.org>]

JackieTien97 commented on a change in pull request #5376:
URL: https://github.com/apache/iotdb/pull/5376#discussion_r839082087



##########
File path: server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/PlanNode.java
##########
@@ -77,4 +82,8 @@ private int getChildrenCount(List<PlanNode> children) {
   }
 
   public abstract void serialize(ByteBuffer byteBuffer);
+
+  public List<String> getBoxString() {
+    return ImmutableList.of(String.format("PlanNode-%s", getId()));

Review comment:
       Better to make it an abstract method, otherwise other PlanNodes will get compile errors if they don't override this method. In this way we can let new PlanNode coders won't remember this `getBoxingString()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org