[GitHub] [rocketmq-operator] caigy commented on a diff in pull request #136: [ISSUE #135]Support Broker clusters in Conntroller mode

[GitBox <gi...@apache.org>]

caigy commented on code in PR #136:
URL: https://github.com/apache/rocketmq-operator/pull/136#discussion_r1012449822


##########
pkg/apis/rocketmq/v1alpha1/broker_types.go:
##########
@@ -31,9 +31,13 @@ type BrokerSpec struct {
 	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
 	// Important: Run "operator-sdk generate k8s" to regenerate code after modifying this file
 	// Add custom validation using kubebuilder tags: https://book-v1.book.kubebuilder.io/beyond_basics/generating_crd.html
+	// Size of broker clusters
 	Size int `json:"size"`
 	// NameServers defines the name service list e.g. 192.168.1.1:9876;192.168.1.2:9876
 	NameServers string `json:"nameServers,omitempty"`
+	// ClusterMode defines the way to be a broker cluster, valid values can be one of the following:
+	// STATIC(default), CONTROLLER, CONTAINER
+	ClusterMode string `json:"clusterMode,omitempty"`

Review Comment:
   This value is for `Broker Container` mode: https://github.com/apache/rocketmq/blob/develop/docs/cn/BrokerContainer.md



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org