You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/12/11 14:40:49 UTC
[PR] build(image): add branch name to the tags of build-env-* images [incubator-pegasus]
empiredan opened a new pull request, #1763:
URL: https://github.com/apache/incubator-pegasus/pull/1763
Since build-env-* images should be built for released versions and master branch, we could add branch name to their tags to create each image for each branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] build(images): append branch name to the tag of each build-env-* image to support building image for each branch [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #1763:
URL: https://github.com/apache/incubator-pegasus/pull/1763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] build(images): append branch name to the tag of each build-env-* image to support building image for each branch [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #1763:
URL: https://github.com/apache/incubator-pegasus/pull/1763#discussion_r1423802199
##########
docker/ci-env/Dockerfile:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-FROM apache/pegasus:build-env-centos7
+FROM apache/pegasus:build-env-centos7-master
Review Comment:
That's true, I've also not found where this image is referenced. I could create another pull requests to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] build(images): append branch name to the tag of each build-env-* image to support building image for each branch [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1763:
URL: https://github.com/apache/incubator-pegasus/pull/1763#discussion_r1423361109
##########
.github/workflows/build-push-env-docker.yml:
##########
@@ -62,6 +62,6 @@ jobs:
file: ./docker/pegasus-build-env/${{ matrix.dockertag }}/Dockerfile
push: true
tags: |
- apache/pegasus:build-env-${{ matrix.dockertag }}
+ apache/pegasus:build-env-${{ matrix.dockertag }}-${{ github.ref_name }}
Review Comment:
https://github.com/apache/incubator-pegasus/blob/71eae1b7a2ec37cb88ee0f8530859fbb4a1c0380/docker/thirdparties-src/Dockerfile
and https://github.com/apache/incubator-pegasus/blob/71eae1b7a2ec37cb88ee0f8530859fbb4a1c0380/docker/thirdparties-bin/Dockerfile are using images like apache/pegasus:build-env-centos7, you should also consider this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] build(images): append branch name to the tag of each build-env-* image to support building image for each branch [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on PR #1763:
URL: https://github.com/apache/incubator-pegasus/pull/1763#issuecomment-1857385643
https://github.com/apache/incubator-pegasus/pull/1763#discussion_r1423802199 has been resolved in https://github.com/apache/incubator-pegasus/pull/1773.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] build(image): add branch name to the tags of build-env-* images [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on PR #1763:
URL: https://github.com/apache/incubator-pegasus/pull/1763#issuecomment-1850222574
Manual test has been run to test branch [build-env-image-tag-add-branch](https://github.com/apache/incubator-pegasus/tree/build-env-image-tag-add-branch):
https://github.com/apache/incubator-pegasus/actions/workflows/build-push-env-docker.yml
Images have been built on dockerhub:
https://hub.docker.com/r/apache/pegasus/tags?page=1&name=build-env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] build(images): append branch name to the tag of each build-env-* image to support building image for each branch [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #1763:
URL: https://github.com/apache/incubator-pegasus/pull/1763#discussion_r1423685556
##########
.github/workflows/build-push-env-docker.yml:
##########
@@ -62,6 +62,6 @@ jobs:
file: ./docker/pegasus-build-env/${{ matrix.dockertag }}/Dockerfile
push: true
tags: |
- apache/pegasus:build-env-${{ matrix.dockertag }}
+ apache/pegasus:build-env-${{ matrix.dockertag }}-${{ github.ref_name }}
Review Comment:
OK, the images that are depending on build-env-* have also been updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] build(images): append branch name to the tag of each build-env-* image to support building image for each branch [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1763:
URL: https://github.com/apache/incubator-pegasus/pull/1763#discussion_r1423783365
##########
docker/ci-env/Dockerfile:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-FROM apache/pegasus:build-env-centos7
+FROM apache/pegasus:build-env-centos7-master
Review Comment:
This Dockerfile seems not used any more, it can be safely removed later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org