You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/08/21 22:10:35 UTC
[kudu-CR] [webui] Convert /tablet and its offshoots to mustache
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11288
Change subject: [webui] Convert /tablet and its offshoots to mustache
......................................................................
[webui] Convert /tablet and its offshoots to mustache
This patch converts the following pages to mustache templates:
* /tablet
* /tablet-consensus-status
* /tablet-rowsetlayout-svg
* /log-anchors
It does the conversion as simply as possible and makes no changes to
the content exposed, except it linkifies the tablet id in a couple of
cases.
Follow-ups will make improvements and add more information.
Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
---
M src/kudu/server/webui_util.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/tserver/tserver_path_handlers.h
A www/log-anchors.mustache
A www/tablet-consensus-status.mustache
A www/tablet-rowsetlayout-svg.mustache
A www/tablet.mustache
7 files changed, 201 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/11288/1
--
To view, visit http://gerrit.cloudera.org:8080/11288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Gerrit-Change-Number: 11288
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Convert /tablet and its offshoots to mustache
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11288
to look at the new patch set (#3).
Change subject: [webui] Convert /tablet and its offshoots to mustache
......................................................................
[webui] Convert /tablet and its offshoots to mustache
This patch converts the following pages to mustache templates:
* /tablet
* /tablet-consensus-status
* /tablet-rowsetlayout-svg
* /log-anchors
It does the conversion as simply as possible and makes no changes to
the content exposed, except it linkifies the tablet id in a couple of
cases.
Follow-ups will make improvements and add more information.
Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
---
M src/kudu/server/webui_util.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/tserver/tserver_path_handlers.h
A www/log-anchors.mustache
A www/tablet-consensus-status.mustache
A www/tablet-rowsetlayout-svg.mustache
A www/tablet.mustache
7 files changed, 201 insertions(+), 129 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/11288/3
--
To view, visit http://gerrit.cloudera.org:8080/11288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Gerrit-Change-Number: 11288
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Convert /tablet and its offshoots to mustache
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11288 )
Change subject: [webui] Convert /tablet and its offshoots to mustache
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc
File src/kudu/tserver/tserver_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@148
PS2, Line 148: Tablet
> nit: replace 'Tablet' --> 'request'?
Done
http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@398
PS2, Line 398: EasyJson* output = resp->output;
> nit: here and elsewhere move this closer to the first usage of output (in t
Done
http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@442
PS2, Line 442: if (!LoadTablet(tserver_, req, &tablet_id, &replica, resp)) return
> Just for my edification: how does mustache renders the page in the case if
If the tablet isn't found or the id is invalid it prints a message saying so.
A tablet must have a log so I think there's always a registry. If there's no log anchors currently then there's a header and nothing underneath.
--
To view, visit http://gerrit.cloudera.org:8080/11288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Gerrit-Change-Number: 11288
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 20:50:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [webui] Convert /tablet and its offshoots to mustache
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11288 )
Change subject: [webui] Convert /tablet and its offshoots to mustache
......................................................................
[webui] Convert /tablet and its offshoots to mustache
This patch converts the following pages to mustache templates:
* /tablet
* /tablet-consensus-status
* /tablet-rowsetlayout-svg
* /log-anchors
It does the conversion as simply as possible and makes no changes to
the content exposed, except it linkifies the tablet id in a couple of
cases.
Follow-ups will make improvements and add more information.
Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Reviewed-on: http://gerrit.cloudera.org:8080/11288
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/server/webui_util.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/tserver/tserver_path_handlers.h
A www/log-anchors.mustache
A www/tablet-consensus-status.mustache
A www/tablet-rowsetlayout-svg.mustache
A www/tablet.mustache
7 files changed, 201 insertions(+), 129 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Will Berkeley: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Gerrit-Change-Number: 11288
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Convert /tablet and its offshoots to mustache
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11288 )
Change subject: [webui] Convert /tablet and its offshoots to mustache
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Gerrit-Change-Number: 11288
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 22:12:13 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] Convert /tablet and its offshoots to mustache
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11288 )
Change subject: [webui] Convert /tablet and its offshoots to mustache
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Gerrit-Change-Number: 11288
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 21:44:36 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] Convert /tablet and its offshoots to mustache
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11288 )
Change subject: [webui] Convert /tablet and its offshoots to mustache
......................................................................
Removed reviewer Kudu Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/11288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Gerrit-Change-Number: 11288
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Convert /tablet and its offshoots to mustache
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11288 )
Change subject: [webui] Convert /tablet and its offshoots to mustache
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Looks good, just a few nits.
http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc
File src/kudu/tserver/tserver_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@148
PS2, Line 148: Tablet
nit: replace 'Tablet' --> 'request'?
http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@398
PS2, Line 398: EasyJson* output = resp->output;
nit: here and elsewhere move this closer to the first usage of output (in this case that's line 410 below).
http://gerrit.cloudera.org:8080/#/c/11288/2/src/kudu/tserver/tserver_path_handlers.cc@442
PS2, Line 442: if (!LoadTablet(tserver_, req, &tablet_id, &replica, resp)) return
Just for my edification: how does mustache renders the page in the case if the expected 'tablet_id' and 'log_anchors' are missing?
--
To view, visit http://gerrit.cloudera.org:8080/11288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Gerrit-Change-Number: 11288
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 22 Aug 2018 19:20:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [webui] Convert /tablet and its offshoots to mustache
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11288
to look at the new patch set (#2).
Change subject: [webui] Convert /tablet and its offshoots to mustache
......................................................................
[webui] Convert /tablet and its offshoots to mustache
This patch converts the following pages to mustache templates:
* /tablet
* /tablet-consensus-status
* /tablet-rowsetlayout-svg
* /log-anchors
It does the conversion as simply as possible and makes no changes to
the content exposed, except it linkifies the tablet id in a couple of
cases.
Follow-ups will make improvements and add more information.
Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
---
M src/kudu/server/webui_util.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/tserver/tserver_path_handlers.h
A www/log-anchors.mustache
A www/tablet-consensus-status.mustache
A www/tablet-rowsetlayout-svg.mustache
A www/tablet.mustache
7 files changed, 201 insertions(+), 129 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/11288/2
--
To view, visit http://gerrit.cloudera.org:8080/11288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea14f5504b9665b9c349efc9b3b13fc3fe19d8b2
Gerrit-Change-Number: 11288
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins