You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2010/02/09 22:07:27 UTC
[jira] Created: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
---------------------------------------------------------------------------------------------------
Key: HADOOP-6551
URL: https://issues.apache.org/jira/browse/HADOOP-6551
Project: Hadoop Common
Issue Type: Bug
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6551:
-----------------------------------
Hadoop Flags: [Reviewed]
+1
Looks good
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: h-6551.patch, h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836156#action_12836156 ]
Hudson commented on HADOOP-6551:
--------------------------------
Integrated in Hadoop-Common-trunk #255 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/255/])
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6551.patch, h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6551:
----------------------------------
Status: Patch Available (was: Open)
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835656#action_12835656 ]
Hudson commented on HADOOP-6551:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #176 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/176/])
. Delegation token renewing and cancelling should provide
meaningful exceptions when there are failures instead of returning
false. (omalley)
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6551.patch, h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834009#action_12834009 ]
Hadoop QA commented on HADOOP-6551:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12435913/h-6551.patch
against trunk revision 910169.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/362/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/362/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/362/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/362/console
This message is automatically generated.
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6551:
----------------------------------
Attachment: h-6551.patch
Here is a new version of the patch. It replaces the IllegalArgumentException with InvalidToken exception.
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: h-6551.patch, h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6551:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Status: Resolved (was: Patch Available)
I just committed this.
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6551.patch, h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6551:
----------------------------------
Attachment: h-6551.patch
Here's a patch that updates the methods to throw exceptions to the user rather than just a boolean. It also updates renew to return a time when the token now expires.
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834595#action_12834595 ]
Hadoop QA commented on HADOOP-6551:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436066/h-6551.patch
against trunk revision 910741.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/8/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/8/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/8/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/8/console
This message is automatically generated.
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: h-6551.patch, h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6551:
----------------------------------
Status: Open (was: Patch Available)
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: h-6551.patch, h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6551) Delegation tokens when renewed or
cancelled should throw an exception that explains what went wrong
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6551:
----------------------------------
Status: Patch Available (was: Open)
> Delegation tokens when renewed or cancelled should throw an exception that explains what went wrong
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6551
> URL: https://issues.apache.org/jira/browse/HADOOP-6551
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: h-6551.patch, h-6551.patch
>
>
> Currently the renew and cancel delegation token method will return false if something goes wrong, but we need an error message and an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.