You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "RaigorJiang (via GitHub)" <gi...@apache.org> on 2023/02/14 11:59:22 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #24163: Make authentication method match the Authority rule configuration
RaigorJiang opened a new pull request, #24163:
URL: https://github.com/apache/shardingsphere/pull/24163
Fixes #24155.
Changes proposed in this pull request:
- Find user in rule to get authenticator
- Add tese case for `MySQLClearPasswordAuthenticatorTest`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24163: Make authentication method match the Authority rule configuration
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24163:
URL: https://github.com/apache/shardingsphere/pull/24163#issuecomment-1429671933
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24163?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24163](https://codecov.io/gh/apache/shardingsphere/pull/24163?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3694856) into [master](https://codecov.io/gh/apache/shardingsphere/commit/55b641bf66a6093feab8ec337898c6f7492a4ed6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55b641b) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 3694856 differs from pull request most recent head 3c3655a. Consider uploading reports for the commit 3c3655a to get more accurate results
```diff
@@ Coverage Diff @@
## master #24163 +/- ##
============================================
+ Coverage 50.11% 50.13% +0.01%
- Complexity 1578 1579 +1
============================================
Files 3258 3258
Lines 53504 53504
Branches 9851 9850 -1
============================================
+ Hits 26816 26822 +6
+ Misses 24331 24324 -7
- Partials 2357 2358 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tadata/user/yaml/config/YamlUserConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/24163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS91c2VyL3lhbWwvY29uZmlnL1lhbWxVc2VyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...ysql/authentication/MySQLAuthenticationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/24163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2F1dGhlbnRpY2F0aW9uL015U1FMQXV0aGVudGljYXRpb25FbmdpbmUuamF2YQ==) | `92.85% <100.00%> (+0.12%)` | :arrow_up: |
| [...authenticator/MySQLClearPasswordAuthenticator.java](https://codecov.io/gh/apache/shardingsphere/pull/24163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2F1dGhlbnRpY2F0aW9uL2F1dGhlbnRpY2F0b3IvTXlTUUxDbGVhclBhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `83.33% <0.00%> (+83.33%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #24163: Make authentication method match the Authority rule configuration
Posted by "tristaZero (via GitHub)" <gi...@apache.org>.
tristaZero merged PR #24163:
URL: https://github.com/apache/shardingsphere/pull/24163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org