You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/23 02:21:40 UTC
[GitHub] [iotdb] ericpai commented on a diff in pull request #6387: [IOTDB-3484] Modify user docs about how to use udf api
ericpai commented on code in PR #6387:
URL: https://github.com/apache/iotdb/pull/6387#discussion_r904458379
##########
docs/Download/README.md:
##########
@@ -102,6 +102,7 @@ Legacy version are available here: [https://archive.apache.org/dist/iotdb/](http
- **Identifiers that are not quoted with backquotes are not allowed to be pure numbers and only allowed to contain letters, Chinese characters, and underscores. If the above occurs in an identifier, use backquotes to enclose the identifier.**
- **Identifiers no longer support quoting with single and double quotes, please use backquotes instead.**
- **When using the path node name in the Session API, it needs to be consistent with that in the SQL statement. If the path node is a pure number 111, it needs to be enclosed in backquotes in the SQL statement and written as \`111\`, then when using the Session API, the corresponding parameter also needs to be written as \`111\`.**
+ - In order to ensure the stability of UDF-related APIs, in version 0.14, UDF-related APIs are separated into a independent module and no longer depend on the tsfile package. The implemented UDFs need to rewrite the code, replace `TsDataType` with `Type`, and replace `org .apache.iotdb.tsfile.utils.Binary` with `org.apache.iotdb.udf.api.type.Binary`, then redo the packaging and loading process.
Review Comment:
```suggestion
- In order to ensure the stability of UDF-related APIs, in version 0.14, UDF-related APIs are separated into an independent module and no longer depend on the tsfile package. The implemented UDFs need to rewrite the code, replace `TsDataType` with `Type`, and replace `org .apache.iotdb.tsfile.utils.Binary` with `org.apache.iotdb.udf.api.type.Binary`, then redo the packaging and loading process.
```
##########
docs/zh/UserGuide/Process-Data/UDF-User-Defined-Function.md:
##########
@@ -41,15 +41,15 @@ IoTDB 支持两种类型的 UDF 函数,如下表所示。
``` xml
<dependency>
<groupId>org.apache.iotdb</groupId>
- <artifactId>iotdb-server</artifactId>
+ <artifactId>udf</artifactId>
Review Comment:
```suggestion
<artifactId>udf-api</artifactId>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org