You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2019/06/06 16:31:01 UTC
[allura:tickets] #8299 More precise markdown @username regex
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** open
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Thu Jun 06, 2019 04:31 PM UTC
**Owner:** nobody
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8299 More precise markdown @username regex
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> closed
- **assigned_to**: Shalitha Suranga
- **Reviewer**: Dave Brondsema
- **Comment**:
Nice, works better now :)
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** closed
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Mon Jul 01, 2019 05:31 PM UTC
**Owner:** Shalitha Suranga
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8299 More precise markdown @username regex
Posted by Shalitha Suranga <sh...@gmail.com>.
- **status**: open --> in-progress
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Wed Jun 26, 2019 08:19 PM UTC
**Owner:** nobody
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8299 More precise markdown @username regex
Posted by Shalitha Suranga <sh...@gmail.com>.
Hi..
I have updated autocomplete regex in ss/8299
Thanks
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Mon Jul 01, 2019 05:06 PM UTC
**Owner:** nobody
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8299 More precise markdown @username regex
Posted by Dave Brondsema <da...@brondsema.net>.
There's also weird regex matching behavior when typing in the editor. `@foo.` will trigger the autocomplete again when you type the `.` It also happens with other punctuation like `@foo=`. And can happen at the beginning like `@//.?`
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** open
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Thu Jun 06, 2019 04:31 PM UTC
**Owner:** nobody
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8299 More precise markdown @username regex
Posted by Dave Brondsema <da...@brondsema.net>.
In the test, since `@nouser1` isn't a user the new assertion isn't a very strong one. Better to test with `test@admin1.com` I think. Besides that I think this will be good to merge to handle the server-side parsing.
Note my comment above about the behavior when typing in the editor too. That is really a separate issue but similar. Not too critical, so can be dealt with later if you wish.
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** open
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Mon Jun 24, 2019 04:27 PM UTC
**Owner:** nobody
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8299 More precise markdown @username regex
Posted by Shalitha Suranga <sh...@gmail.com>.
Hi.. acutually I missed to replace `nouser` with correct one. Now I updated the branch. Yeah we can keep this ticket open until I fix the editor typing improvement.
Thanks
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** open
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Tue Jun 25, 2019 05:53 PM UTC
**Owner:** nobody
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8299 More precise markdown @username regex
Posted by Shalitha Suranga <sh...@gmail.com>.
- **status**: in-progress --> review
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** review
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Mon Jul 01, 2019 05:31 PM UTC
**Owner:** nobody
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8299 More precise markdown @username regex
Posted by Dave Brondsema <da...@brondsema.net>.
Merged ss/8299
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** open
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Wed Jun 26, 2019 04:28 PM UTC
**Owner:** nobody
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8299 More precise markdown @username regex
Posted by Shalitha Suranga <sh...@gmail.com>.
Hi.. @brondsem
I made branch `ss/8299` and improved regex by adding `\B`. So it will not catch things like `johndoe@foo.com` and `johndoe@foo`.
---
** [tickets:#8299] More precise markdown @username regex**
**Status:** open
**Milestone:** unreleased
**Labels:** gsoc19
**Created:** Thu Jun 06, 2019 04:31 PM UTC by Dave Brondsema
**Last Updated:** Mon Jun 10, 2019 10:38 PM UTC
**Owner:** nobody
If there exists a user with username "foo" and some markdown content has johndoe@foo.com then we'll incorrectly get a username link of @foo in the middle of that email address.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.