You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/04/27 23:58:01 UTC
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15826
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
IMPALA-9701: fix data race in BTS
A benign data race in BufferedTupleStream was flagged
by TSAN.
Testing:
Reran the unit test under TSAN, it succeeded.
Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
---
M be/src/runtime/buffered-tuple-stream.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/15826/1
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15826 )
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5897/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 04:06:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15826 )
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5894/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 00:41:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15826 )
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15826/1/be/src/runtime/buffered-tuple-stream.cc
File be/src/runtime/buffered-tuple-stream.cc:
http://gerrit.cloudera.org:8080/#/c/15826/1/be/src/runtime/buffered-tuple-stream.cc@1082
PS1, Line 1082: // Only set 'attach_on_read' if needed. Otherwise, if this is the builtin
> nit: Only set 'attach_on_read' if needed (true only for single threaded bui
Done
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 03:22:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15826 )
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 03:22:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15826 )
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 08:34:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15826 )
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15826/1/be/src/runtime/buffered-tuple-stream.cc
File be/src/runtime/buffered-tuple-stream.cc:
http://gerrit.cloudera.org:8080/#/c/15826/1/be/src/runtime/buffered-tuple-stream.cc@1082
PS1, Line 1082: // Only set 'attach_on_read' if needed. Otherwise this creates a benign
nit: Only set 'attach_on_read' if needed (true only for single threaded built-in iterator mode)
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 03:01:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15826 )
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
IMPALA-9701: fix data race in BTS
A benign data race in BufferedTupleStream was flagged
by TSAN.
Testing:
Reran the unit test under TSAN, it succeeded.
Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Reviewed-on: http://gerrit.cloudera.org:8080/15826
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/buffered-tuple-stream.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15826
to look at the new patch set (#2).
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
IMPALA-9701: fix data race in BTS
A benign data race in BufferedTupleStream was flagged
by TSAN.
Testing:
Reran the unit test under TSAN, it succeeded.
Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
---
M be/src/runtime/buffered-tuple-stream.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/15826/2
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9701: fix data race in BTS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15826 )
Change subject: IMPALA-9701: fix data race in BTS
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5718/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Gerrit-Change-Number: 15826
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 03:22:23 +0000
Gerrit-HasComments: No