[GitHub] [incubator-doris] caiconghui commented on a change in pull request #5027: Support fe heartbeat use thrift protocol to get stable response

[GitBox <gi...@apache.org>]

caiconghui commented on a change in pull request #5027:
URL: https://github.com/apache/incubator-doris/pull/5027#discussion_r536621505



##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1301,4 +1301,13 @@
      */
     @ConfField
     public static boolean enable_alpha_rowset = false;
+
+    /**
+     * This config is used to solve fe heartbeat response read_timeout problem,

Review comment:
       for non master fe, the thread for processing request in fe thrift server is usually idle, and thrift protocol is more lightweight when we keep a long connection opened. But I still confused that why heartbeat by http is easy to readtimout, we just made period http request to fe server, such metric collect,  count running transaction in every db. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org