[GitHub] [tvm] wrongtest-intellif commented on a diff in pull request #12315: [TOPI][OP]change float multiplication of resize op to integer division

[GitBox <gi...@apache.org>]

wrongtest-intellif commented on code in PR #12315:
URL: https://github.com/apache/tvm/pull/12315#discussion_r941005802


##########
tests/python/topi/python/test_topi_upsampling.py:
##########
@@ -101,6 +101,38 @@ def check_target(target, dev):
         check_target(target, dev)
 
 
+@tvm.testing.uses_gpu

Review Comment:
   why uses_gpu?



##########
python/tvm/topi/image/resize.py:
##########
@@ -23,6 +23,22 @@
 from .. import tag
 
 
+def can_multiple2div(image, target):

Review Comment:
   The names seem to be not so clear. Can they be named as below?
   `can_multiple2div` -> `can_convert_multiply_to_intdiv`
   `image` -> `origin_size`
   `target` -> `scaled_size`



##########
tests/python/topi/python/test_topi_upsampling.py:
##########
@@ -101,6 +101,38 @@ def check_target(target, dev):
         check_target(target, dev)
 
 
+@tvm.testing.uses_gpu
+def test_int_div_upsampling():

Review Comment:
   can you kindly describe the purpose of this check in the docstring?



##########
python/tvm/topi/image/resize.py:
##########
@@ -23,6 +23,22 @@
 from .. import tag
 
 
+def can_multiple2div(image, target):
+    """Check whether can transform multiplion to division"""

Review Comment:
   typo `multiplion` -> `multiplication`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org